mirrors/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-08-07 06:37:17 +02:00
Code Issues Projects Releases Wiki Activity

fix: os.MkdirTemp with t.TempDir (#15860)

Browse Source 
Signed-off-by: Surya Prakash <surya0prakash@proton.me>
This commit is contained in:
SuryaPrakash 2025-01-31 20:02:20 +05:30 committed by GitHub
parent 3389cdf957
commit cb3b17a14c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tsdb/tsdbutil/dir_locker_testutil.go
View File

@ -60,11 +60,7 @@ func TestDirLockerUsage(t *testing.T, open func(t *testing.T, data string, creat
for _, c := range cases { for _, c := range cases {
t.Run(fmt.Sprintf("%+v", c), func(t *testing.T) { t.Run(fmt.Sprintf("%+v", c), func(t *testing.T) {
tmpdir, err := os.MkdirTemp("", "test") tmpdir := t.TempDir()
require.NoError(t, err)
t.Cleanup(func() {
require.NoError(t, os.RemoveAll(tmpdir))
})
// Test preconditions (file already exists + lockfile option) // Test preconditions (file already exists + lockfile option)
if c.fileAlreadyExists { if c.fileAlreadyExists {
@ -82,7 +78,7 @@ func TestDirLockerUsage(t *testing.T, open func(t *testing.T, data string, creat
// Check that the lockfile is always deleted // Check that the lockfile is always deleted
if !c.lockFileDisabled { if !c.lockFileDisabled {
_, err = os.Stat(locker.path) _, err := os.Stat(locker.path)
require.True(t, os.IsNotExist(err), "lockfile was not deleted") require.True(t, os.IsNotExist(err), "lockfile was not deleted")
} }
}) })