mirrors/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-12-08 19:11:02 +01:00
Code Issues Projects Releases Wiki Activity

[TEST] Refactor BenchmarkIntersect to reduce memory allocations

Browse Source 
Extract functions which pre-create all the memory for the benchmark itself.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
This commit is contained in:
Bryan Boreham 2025-10-31 16:20:18 +00:00
parent 393ab9e12e
commit be8307db58
1 changed files with 41 additions and 55 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
tsdb/index/postings_test.go
View File

@ -285,92 +285,78 @@ func consumePostings(p Postings) error {
return p.Err() return p.Err()
} }
// Create ListPostings for a benchmark, collecting the original sets of references
// so they can be reset without additional memory allocations.
func createPostings(lps *[]*ListPostings, refs *[][]storage.SeriesRef, params ...storage.SeriesRef) {
var temp []storage.SeriesRef
for i := 0; i < len(params); i += 3 {
for j := params[i]; j < params[i+1]; j += params[i+2] {
temp = append(temp, j)
}
}
*lps = append(*lps, newListPostings(temp...))
*refs = append(*refs, temp)
}
// Reset the ListPostings to their original values each time round the benchmark loop.
func resetPostings(its []Postings, lps []*ListPostings, refs [][]storage.SeriesRef) {
for j := range refs {
lps[j].list = refs[j]
its[j] = lps[j]
}
}
func BenchmarkIntersect(t *testing.B) { func BenchmarkIntersect(t *testing.B) {
t.Run("LongPostings1", func(bench *testing.B) { t.Run("LongPostings1", func(bench *testing.B) {
var a, b, c, d []storage.SeriesRef var lps []*ListPostings
var refs [][]storage.SeriesRef
for i := 0; i < 10000000; i += 2 { createPostings(&lps, &refs, 0, 10000000, 2)
a = append(a, storage.SeriesRef(i)) createPostings(&lps, &refs, 5000000, 5000100, 4, 5090000, 5090600, 4)
} createPostings(&lps, &refs, 4990000, 5100000, 1)
for i := 5000000; i < 5000100; i += 4 { createPostings(&lps, &refs, 4000000, 6000000, 1)
b = append(b, storage.SeriesRef(i)) its := make([]Postings, len(refs))
}
for i := 5090000; i < 5090600; i += 4 {
b = append(b, storage.SeriesRef(i))
}
for i := 4990000; i < 5100000; i++ {
c = append(c, storage.SeriesRef(i))
}
for i := 4000000; i < 6000000; i++ {
d = append(d, storage.SeriesRef(i))
}
bench.ResetTimer() bench.ResetTimer()
bench.ReportAllocs() bench.ReportAllocs()
for bench.Loop() { for bench.Loop() {
i1 := newListPostings(a...) resetPostings(its, lps, refs)
i2 := newListPostings(b...) if err := consumePostings(Intersect(its...)); err != nil {
i3 := newListPostings(c...)
i4 := newListPostings(d...)
if err := consumePostings(Intersect(i1, i2, i3, i4)); err != nil {
bench.Fatal(err) bench.Fatal(err)
} }
} }
}) })
t.Run("LongPostings2", func(bench *testing.B) { t.Run("LongPostings2", func(bench *testing.B) {
var a, b, c, d []storage.SeriesRef var lps []*ListPostings
var refs [][]storage.SeriesRef
for i := range 12500000 { createPostings(&lps, &refs, 0, 12500000, 1)
a = append(a, storage.SeriesRef(i)) createPostings(&lps, &refs, 7500000, 12500000, 1)
} createPostings(&lps, &refs, 9000000, 20000000, 1)
for i := 7500000; i < 12500000; i++ { createPostings(&lps, &refs, 10000000, 12000000, 1)
b = append(b, storage.SeriesRef(i)) its := make([]Postings, len(refs))
}
for i := 9000000; i < 20000000; i++ {
c = append(c, storage.SeriesRef(i))
}
for i := 10000000; i < 12000000; i++ {
d = append(d, storage.SeriesRef(i))
}
bench.ResetTimer() bench.ResetTimer()
bench.ReportAllocs() bench.ReportAllocs()
for bench.Loop() { for bench.Loop() {
i1 := newListPostings(a...) resetPostings(its, lps, refs)
i2 := newListPostings(b...) if err := consumePostings(Intersect(its...)); err != nil {
i3 := newListPostings(c...)
i4 := newListPostings(d...)
if err := consumePostings(Intersect(i1, i2, i3, i4)); err != nil {
bench.Fatal(err) bench.Fatal(err)
} }
} }
}) })
// Many matchers.
t.Run("ManyPostings", func(bench *testing.B) { t.Run("ManyPostings", func(bench *testing.B) {
var lps []*ListPostings var lps []*ListPostings
var refs [][]storage.SeriesRef var refs [][]storage.SeriesRef
// Create 100 matchers, making sure all memory allocation is done before starting the loop.
for range 100 { for range 100 {
var temp []storage.SeriesRef createPostings(&lps, &refs, 1, 100, 1)
for j := storage.SeriesRef(1); j < 100; j++ {
temp = append(temp, j)
}
lps = append(lps, newListPostings(temp...))
refs = append(refs, temp)
} }
its := make([]Postings, len(refs)) its := make([]Postings, len(refs))
bench.ResetTimer() bench.ResetTimer()
bench.ReportAllocs() bench.ReportAllocs()
for bench.Loop() { for bench.Loop() {
// Reset the ListPostings to their original values each time round the loop. resetPostings(its, lps, refs)
for j := range refs {
lps[j].list = refs[j]
its[j] = lps[j]
}
if err := consumePostings(Intersect(its...)); err != nil { if err := consumePostings(Intersect(its...)); err != nil {
bench.Fatal(err) bench.Fatal(err)
} }