mirrors/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-08-07 06:37:17 +02:00
Code Issues Projects Releases Wiki Activity

Make sure we never call trackStaleness with nil cache entry

Browse Source 
Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com>
This commit is contained in:
Lukasz Mierzwa 2025-04-29 09:24:27 +01:00
parent 6687bf5653
commit bb690a23b9
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
scrape/scrape.go
View File

@ -1820,8 +1820,9 @@ loop:
// it in the scrape cache because we don't need to emit StaleNaNs for it when it disappears. // it in the scrape cache because we don't need to emit StaleNaNs for it when it disappears.
if !seriesCached && sampleAdded { if !seriesCached && sampleAdded {
ce = sl.cache.addRef(met, ref, lset, hash) ce = sl.cache.addRef(met, ref, lset, hash)
if parsedTimestamp == nil || sl.trackTimestampsStaleness { if ce != nil && (parsedTimestamp == nil || sl.trackTimestampsStaleness) {
// Bypass staleness logic if there is an explicit timestamp. // Bypass staleness logic if there is an explicit timestamp.
// But make sure we only do this if we have a cache entry (ce) for our series.
sl.cache.trackStaleness(hash, ce) sl.cache.trackStaleness(hash, ce)
} }
if sampleAdded && sampleLimitErr == nil && bucketLimitErr == nil { if sampleAdded && sampleLimitErr == nil && bucketLimitErr == nil {