mirrors/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2026-05-05 04:16:15 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #18058 from zenador/fix-avg-over-time-nh

Browse Source 
promql: fix avg_over_time for single native histogram
This commit is contained in:
Björn Rabenstein 2026-02-11 12:42:27 +01:00 committed by GitHub
commit b84d7dcc56
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
promql/functions.go
View File

@ -848,7 +848,7 @@ func funcAvgOverTime(_ []Vector, matrixVal Matrix, args parser.Expressions, enh
var (
sum = s.Histograms[0].H.Copy()
mean, kahanC *histogram.FloatHistogram
count float64
count = 1.
incrementalMean bool
nhcbBoundsReconciled bool
err error

15
promql/promqltest/testdata/native_histograms.test vendored
View File

@ -1545,6 +1545,21 @@ eval instant at 3m avg_over_time(histogram_sum_over_time_incremental_6[4m:1m])
clear
# Test avg_over_time with a single histogram sample (regression test for division by zero bug).
load 1m
single_histogram_sample {{schema:3 sum:5 count:4 buckets:[1 2 1]}}
single_nhcb_sample {{schema:-53 sum:1 count:5 custom_values:[5 10] buckets:[1 4]}}
# avg_over_time should return the histogram unchanged when there's only one sample, not Inf/NaN.
eval instant at 0m avg_over_time(single_histogram_sample[1m])
{} {{schema:3 sum:5 count:4 buckets:[1 2 1]}}
# Test with native histogram with custom buckets (NHCB).
eval instant at 0m avg_over_time(single_nhcb_sample[1m])
{} {{schema:-53 sum:1 count:5 custom_values:[5 10] buckets:[1 4]}}
clear
# Test native histograms with sub operator.
load 10m
histogram_sub_1{idx="0"} {{schema:0 count:41 sum:2345.6 z_bucket:5 z_bucket_w:0.001 buckets:[1 3 1 2 1 1 1] n_buckets:[0 1 4 2 7 0 0 0 0 5 5 2]}}x1