mirrors/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2026-05-04 20:06:12 +02:00
Code Issues Projects Releases Wiki Activity

remote: validate snappy decoded length before allocation in read endpoint

Browse Source 
Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
This commit is contained in:
Julien Pivotto 2026-04-27 11:57:37 +02:00
parent f227287843
commit a75e3011d9
2 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
storage/remote/codec.go
View File

@ -67,6 +67,14 @@ func DecodeReadRequest(r *http.Request) (*prompb.ReadRequest, error) {
return nil, err
}
decodedLen, err := snappy.DecodedLen(compressed)
if err != nil {
return nil, err
}
if decodedLen > decodeReadLimit {
return nil, fmt.Errorf("snappy: decoded length %d exceeds limit %d", decodedLen, decodeReadLimit)
}
reqBuf, err := snappy.Decode(nil, compressed)
if err != nil {
return nil, err

12
storage/remote/codec_test.go
View File

@ -17,6 +17,7 @@ import (
"bytes"
"fmt"
"io"
"net/http"
"sync"
"testing"
@ -616,6 +617,17 @@ func TestMergeLabels(t *testing.T) {
}
}
func TestDecodeReadRequestTooLarge(t *testing.T) {
// 5-byte snappy stream whose header claims 256 MiB decoded length,
// well above decodeReadLimit (32 MiB).
bomb := []byte{0x80, 0x80, 0x80, 0x80, 0x01}
req, err := http.NewRequest(http.MethodPost, "/", bytes.NewReader(bomb))
require.NoError(t, err)
_, err = DecodeReadRequest(req)
require.ErrorContains(t, err, "exceeds limit")
}
func TestDecodeWriteRequest(t *testing.T) {
buf, _, _, err := buildWriteRequest(nil, writeRequestFixture.Timeseries, nil, nil, nil, nil, "snappy")
require.NoError(t, err)