mirrors/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-08-05 21:57:09 +02:00
Code Issues Projects Releases Wiki Activity

PromQL: Fix printing +min()

Browse Source 
Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
This commit is contained in:
Julien Pivotto 2025-07-01 11:57:31 +02:00
parent 3af0bdee68
commit 984c8de0da
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
promql/parser/printer.go
View File

@ -157,7 +157,15 @@ func (node *DurationExpr) String() string {
expr = fmt.Sprintf("max(%s, %s)", node.LHS, node.RHS) expr = fmt.Sprintf("max(%s, %s)", node.LHS, node.RHS)
case node.LHS == nil: case node.LHS == nil:
// This is a unary duration expression. // This is a unary duration expression.
expr = fmt.Sprintf("%s%s", node.Op, node.RHS) switch node.Op {
case SUB:
expr = fmt.Sprintf("%s%s", node.Op, node.RHS)
case ADD:
expr = node.RHS.String()
default:
// This should never happen.
panic(fmt.Sprintf("unexpected unary duration expression: %s", node.Op))
}
default: default:
expr = fmt.Sprintf("%s %s %s", node.LHS, node.Op, node.RHS) expr = fmt.Sprintf("%s %s %s", node.LHS, node.Op, node.RHS)
} }

4
promql/parser/printer_test.go
View File

@ -199,6 +199,10 @@ func TestExprString(t *testing.T) {
in: "foo offset +(5*2)", in: "foo offset +(5*2)",
out: "foo offset (5 * 2)", out: "foo offset (5 * 2)",
}, },
{
in: "foo offset +min(10s, 20s)",
out: "foo offset min(10s, 20s)",
},
{ {
in: "foo offset -min(10s, 20s)", in: "foo offset -min(10s, 20s)",
}, },