From 9325caa41c9e4aeb263adf86b2ffe40bd2e0b610 Mon Sep 17 00:00:00 2001 From: Ganesh Vernekar <15064823+codesome@users.noreply.github.com> Date: Thu, 18 Aug 2022 22:47:12 +0530 Subject: [PATCH] Remove a TODO that is no longer valid (#11186) Signed-off-by: Ganesh Vernekar Signed-off-by: Ganesh Vernekar --- promql/engine_test.go | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/promql/engine_test.go b/promql/engine_test.go index 6438c14421..41723d5f63 100644 --- a/promql/engine_test.go +++ b/promql/engine_test.go @@ -3422,21 +3422,11 @@ func TestSparseHistogram_HistogramQuantile(t *testing.T) { }, } + test, err := NewTest(t, "") + require.NoError(t, err) + t.Cleanup(test.Close) for i, c := range cases { t.Run(c.text, func(t *testing.T) { - // TODO(codesome): Check if TSDB is handling these histograms properly. - // When testing, the 3rd case of both positive and - // negative buckets did not get any histograms in the - // query engine when the storage was shared, even with a - // good time gap between all histograms. It is possible - // that the recode is failing. It was fine between the - // first two cases where there is a change of bucket - // layout. - - test, err := NewTest(t, "") - require.NoError(t, err) - t.Cleanup(test.Close) - seriesName := "sparse_histogram_series" lbls := labels.FromStrings("__name__", seriesName) engine := test.QueryEngine() @@ -3461,7 +3451,7 @@ func TestSparseHistogram_HistogramQuantile(t *testing.T) { require.Len(t, vector, 1) require.Nil(t, vector[0].H) - require.Equal(t, sc.value, vector[0].V) + require.True(t, almostEqual(sc.value, vector[0].V)) }) } })