mirrors/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-08-06 06:07:11 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #16754 from simonpasquier/fix-promql-panic

Browse Source 
fix: prevent invalid array access in aggregate expression
This commit is contained in:
Julien 2025-06-20 13:53:59 +02:00 committed by GitHub
commit 8f75da3fd6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
promql/parser/parse.go
View File

@ -451,6 +451,11 @@ func (p *parser) newAggregateExpr(op Item, modifier, args Node) (ret *AggregateE
ret = modifier.(*AggregateExpr)
arguments := args.(Expressions)
if len(p.closingParens) == 0 {
// Prevents invalid array accesses.
// The error is already captured by the parser.
return
}
ret.PosRange = posrange.PositionRange{
Start: op.Pos,
End: p.closingParens[0],

5
promql/parser/parse_test.go
View File

@ -4540,6 +4540,11 @@ var testExpr = []struct {
PosRange: posrange.PositionRange{Start: 0, End: 20},
},
},
{
input: "sum(rate(",
fail: true,
errMsg: "unclosed left parenthesis",
},
}
func makeInt64Pointer(val int64) *int64 {