From 8a2921e3851d886367308aaedc7545ee4cd8138a Mon Sep 17 00:00:00 2001 From: bwplotka Date: Wed, 14 Jan 2026 13:57:48 +0000 Subject: [PATCH] addressed feedback Signed-off-by: bwplotka --- storage/fanout.go | 4 ++-- storage/remote/write.go | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/storage/fanout.go b/storage/fanout.go index c5102b442f..95c6499952 100644 --- a/storage/fanout.go +++ b/storage/fanout.go @@ -289,7 +289,7 @@ func (f *fanoutAppender) Rollback() (err error) { f.logger.Error("Squashed rollback error on rollback", "err", rollbackErr) } } - return nil + return err } type fanoutAppenderV2 struct { @@ -340,5 +340,5 @@ func (f *fanoutAppenderV2) Rollback() (err error) { f.logger.Error("Squashed rollback error on rollback", "err", rollbackErr) } } - return nil + return err } diff --git a/storage/remote/write.go b/storage/remote/write.go index 91000a1d25..6a336dc06b 100644 --- a/storage/remote/write.go +++ b/storage/remote/write.go @@ -382,6 +382,7 @@ type timestampTrackerV2 struct { baseTimestampTracker } +// Append implements storage.AppenderV2. func (t *timestampTrackerV2) Append(ref storage.SeriesRef, _ labels.Labels, _, ts int64, _ float64, h *histogram.Histogram, fh *histogram.FloatHistogram, opts storage.AOptions) (storage.SeriesRef, error) { switch { case fh != nil, h != nil: