From 856de30c09b2ca77cf8ab73f9d52bc5e6aef4e7b Mon Sep 17 00:00:00 2001 From: Fabian Reinartz Date: Sun, 13 Nov 2016 18:16:02 +0100 Subject: [PATCH] Check error before defer closing If an error is returned the file might be nil and a Close call would cause a panic. --- storage/local/persistence_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/storage/local/persistence_test.go b/storage/local/persistence_test.go index 9756b41a83..2b37857668 100644 --- a/storage/local/persistence_test.go +++ b/storage/local/persistence_test.go @@ -1097,11 +1097,12 @@ func TestQuranatineSeriesFile(t *testing.T) { t.Errorf("Unexpected state of quarantined file %q. Expected it to exist: %t. os.Stat returned: %s.", quarantinedFile, seriesFileShouldExist, err) } f, err := os.Open(hintFile) - defer f.Close() if err != nil { t.Errorf("Could not open hint file %q: %s", hintFile, err) return } + defer f.Close() + scanner := bufio.NewScanner(f) for _, want := range contentHintFile { if !scanner.Scan() {