mirrors/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-09-21 22:01:01 +02:00
Code Issues Projects Releases Wiki Activity

Only add series to scrape cache if they were appended to TSDB

Browse Source 
Scrape cache is used to emit StaleNaN markers after a series disappears so it should only hold entries for series that did end up in TSDB, which is not always the case due to sample_limit.

Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com>
This commit is contained in:
Lukasz Mierzwa 2025-04-28 16:05:37 +01:00
parent c75768739a
commit 6687bf5653
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
scrape/scrape.go
View File

@ -1103,9 +1103,6 @@ func (c *scrapeCache) trackStaleness(hash uint64, ce *cacheEntry) {
func (c *scrapeCache) forEachStale(f func(storage.SeriesRef, labels.Labels) bool) { func (c *scrapeCache) forEachStale(f func(storage.SeriesRef, labels.Labels) bool) {
for h, ce := range c.seriesPrev { for h, ce := range c.seriesPrev {
if ce == nil {
continue
}
if _, ok := c.seriesCur[h]; !ok { if _, ok := c.seriesCur[h]; !ok {
if !f(ce.ref, ce.lset) { if !f(ce.ref, ce.lset) {
break break
@ -1817,7 +1814,11 @@ loop:
break loop break loop
} }
if !seriesCached { // If series wasn't cached (is new, not seen on previous scrape) we need need to add it to the scrape cache.
// But we only do this for series that were appended to TSDB without errors.
// If a series was new but we didn't append it due to sample_limit or other errors then we don't need
// it in the scrape cache because we don't need to emit StaleNaNs for it when it disappears.
if !seriesCached && sampleAdded {
ce = sl.cache.addRef(met, ref, lset, hash) ce = sl.cache.addRef(met, ref, lset, hash)
if parsedTimestamp == nil || sl.trackTimestampsStaleness { if parsedTimestamp == nil || sl.trackTimestampsStaleness {
// Bypass staleness logic if there is an explicit timestamp. // Bypass staleness logic if there is an explicit timestamp.