mirrors/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-12-08 19:11:02 +01:00
Code Issues Projects Releases Wiki Activity

Merge pull request #16642 from rajagopalanand/restore-for-state-refactor

Browse Source 
refactor: Move 'for' state restoration metric to defer block
This commit is contained in:
Björn Rabenstein 2025-06-04 18:04:31 +02:00 committed by GitHub
commit 5f28c6be62
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
rules/group.go
View File

@ -270,12 +270,7 @@ func (g *Group) run(ctx context.Context) {
g.evalIterationFunc(ctx, g, evalTimestamp) g.evalIterationFunc(ctx, g, evalTimestamp)
} }
restoreStartTime := time.Now() g.RestoreForState(time.Now())
g.RestoreForState(restoreStartTime)
totalRestoreTimeSeconds := time.Since(restoreStartTime).Seconds()
g.metrics.GroupLastRestoreDuration.WithLabelValues(GroupKey(g.file, g.name)).Set(totalRestoreTimeSeconds)
g.logger.Debug("'for' state restoration completed", "duration_seconds", totalRestoreTimeSeconds)
g.shouldRestore = false
} }
for { for {
@ -742,6 +737,12 @@ func (g *Group) cleanupStaleSeries(ctx context.Context, ts time.Time) {
// RestoreForState restores the 'for' state of the alerts // RestoreForState restores the 'for' state of the alerts
// by looking up last ActiveAt from storage. // by looking up last ActiveAt from storage.
func (g *Group) RestoreForState(ts time.Time) { func (g *Group) RestoreForState(ts time.Time) {
defer func() {
totalRestoreTimeSeconds := time.Since(ts).Seconds()
g.metrics.GroupLastRestoreDuration.WithLabelValues(GroupKey(g.file, g.name)).Set(totalRestoreTimeSeconds)
g.logger.Debug("'for' state restoration completed", "duration_seconds", totalRestoreTimeSeconds)
g.shouldRestore = false
}()
maxtMS := int64(model.TimeFromUnixNano(ts.UnixNano())) maxtMS := int64(model.TimeFromUnixNano(ts.UnixNano()))
// We allow restoration only if alerts were active before after certain time. // We allow restoration only if alerts were active before after certain time.
mint := ts.Add(-g.opts.OutageTolerance) mint := ts.Add(-g.opts.OutageTolerance)