From 4b9d0fb92ff3a6e8e5ceaa28ebed1eeda8e39b1a Mon Sep 17 00:00:00 2001 From: Arthur Silva Sens Date: Tue, 8 Jul 2025 07:37:19 -0300 Subject: [PATCH] Revert: OTLP Support including scope metadata as metric labels (#16842) Reverts #16730 and #16760 This is being done because we've noticed a problem in the spec that could lead to name collisions if attributes name, version or schema_url are added to the scope. They would collide with the already reserved labels otel_scope_name, otel_scope_version and otel_scope_schema_url. Since this new configuration option never made it into a release, we can safely remove it from the 3.5 release. We'll sort this out for the 3.6 release Signed-off-by: Arthur Silva Sens --- CHANGELOG.md | 1 - config/config.go | 3 - config/config_test.go | 14 - .../otlp_promote_scope_metadata.good.yml | 2 - docs/configuration/configuration.md | 3 - .../prometheusremotewrite/helper.go | 33 +- .../prometheusremotewrite/helper_test.go | 441 +----------------- .../prometheusremotewrite/histograms.go | 4 - .../prometheusremotewrite/histograms_test.go | 194 +------- .../prometheusremotewrite/metrics_to_prw.go | 34 +- .../number_data_points.go | 6 +- .../number_data_points_test.go | 137 +----- storage/remote/write_handler.go | 1 - 13 files changed, 59 insertions(+), 814 deletions(-) delete mode 100644 config/testdata/otlp_promote_scope_metadata.good.yml diff --git a/CHANGELOG.md b/CHANGELOG.md index 0cce790e96..84d1e67562 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,7 +7,6 @@ * [FEATURE] PromQL: Add experimental type and unit metadata labels, behind feature flag `type-and-unit-labels`. #16228 #16632 #16718 #16743 * [FEATURE] PromQL: Add `ts_of_(min|max|last)_over_time`, behind feature flag `experimental-promql-functions`. #16722 #16733 * [FEATURE] Scraping: Add global option `always_scrape_classic_histograms` to scrape a classic histogram even if it is also exposed as native. #16452 -* [FEATURE] OTLP: Support promoting OTel scope name/version/schema URL/attributes as metric labels, via `otlp.promote_scope_metadata`. #16730 #16760 * [FEATURE] OTLP: New config options `promote_all_resource_attributes` and `ignore_resource_attributes`. #16426 * [FEATURE] Discovery: New service discovery for STACKIT Cloud. #16401 * [ENHANCEMENT] Hetzner SD: Add `label_selector` to filter servers. #16512 diff --git a/config/config.go b/config/config.go index 3eb2c17602..a60cfcb6b9 100644 --- a/config/config.go +++ b/config/config.go @@ -1588,9 +1588,6 @@ type OTLPConfig struct { TranslationStrategy translationStrategyOption `yaml:"translation_strategy,omitempty"` KeepIdentifyingResourceAttributes bool `yaml:"keep_identifying_resource_attributes,omitempty"` ConvertHistogramsToNHCB bool `yaml:"convert_histograms_to_nhcb,omitempty"` - // PromoteScopeMetadata controls whether to promote OTel scope metadata (i.e. name, version, schema URL, and attributes) to metric labels. - // As per OTel spec, the aforementioned scope metadata should be identifying, i.e. made into metric labels. - PromoteScopeMetadata bool `yaml:"promote_scope_metadata,omitempty"` } // UnmarshalYAML implements the yaml.Unmarshaler interface. diff --git a/config/config_test.go b/config/config_test.go index afa46bf84c..1e3a04fb93 100644 --- a/config/config_test.go +++ b/config/config_test.go @@ -1808,20 +1808,6 @@ func TestOTLPConvertHistogramsToNHCB(t *testing.T) { }) } -func TestOTLPPromoteScopeMetadata(t *testing.T) { - t.Run("good config", func(t *testing.T) { - want, err := LoadFile(filepath.Join("testdata", "otlp_promote_scope_metadata.good.yml"), false, promslog.NewNopLogger()) - require.NoError(t, err) - - out, err := yaml.Marshal(want) - require.NoError(t, err) - var got Config - require.NoError(t, yaml.UnmarshalStrict(out, &got)) - - require.True(t, got.OTLPConfig.PromoteScopeMetadata) - }) -} - func TestOTLPAllowUTF8(t *testing.T) { t.Run("good config - NoUTF8EscapingWithSuffixes", func(t *testing.T) { fpath := filepath.Join("testdata", "otlp_allow_utf8.good.yml") diff --git a/config/testdata/otlp_promote_scope_metadata.good.yml b/config/testdata/otlp_promote_scope_metadata.good.yml deleted file mode 100644 index d88f657abd..0000000000 --- a/config/testdata/otlp_promote_scope_metadata.good.yml +++ /dev/null @@ -1,2 +0,0 @@ -otlp: - promote_scope_metadata: true diff --git a/docs/configuration/configuration.md b/docs/configuration/configuration.md index 45f099af4e..afda28fb8c 100644 --- a/docs/configuration/configuration.md +++ b/docs/configuration/configuration.md @@ -214,9 +214,6 @@ otlp: [ keep_identifying_resource_attributes: | default = false ] # Configures optional translation of OTLP explicit bucket histograms into native histograms with custom buckets. [ convert_histograms_to_nhcb: | default = false ] - # Enables promotion of OTel scope metadata (i.e. name, version, schema URL, and attributes) to metric labels. - # This is disabled by default for backwards compatibility, but according to OTel spec, scope metadata _should_ be identifying, i.e. translated to metric labels. - [ promote_scope_metadata: | default = false ] # Settings related to the remote read feature. remote_read: diff --git a/storage/remote/otlptranslator/prometheusremotewrite/helper.go b/storage/remote/otlptranslator/prometheusremotewrite/helper.go index 630c010429..c40a8c7be4 100644 --- a/storage/remote/otlptranslator/prometheusremotewrite/helper.go +++ b/storage/remote/otlptranslator/prometheusremotewrite/helper.go @@ -115,7 +115,7 @@ var seps = []byte{'\xff'} // Unpaired string values are ignored. String pairs overwrite OTLP labels if collisions happen and // if logOnOverwrite is true, the overwrite is logged. Resulting label names are sanitized. // If settings.PromoteResourceAttributes is not empty, it's a set of resource attributes that should be promoted to labels. -func createAttributes(resource pcommon.Resource, attributes pcommon.Map, scope scope, settings Settings, +func createAttributes(resource pcommon.Resource, attributes pcommon.Map, settings Settings, ignoreAttrs []string, logOnOverwrite bool, extras ...string, ) []prompb.Label { resourceAttrs := resource.Attributes() @@ -124,14 +124,8 @@ func createAttributes(resource pcommon.Resource, attributes pcommon.Map, scope s promotedAttrs := settings.PromoteResourceAttributes.promotedAttributes(resourceAttrs) - promoteScope := settings.PromoteScopeMetadata && scope.name != "" - scopeLabelCount := 0 - if promoteScope { - // Include name, version and schema URL. - scopeLabelCount = scope.attributes.Len() + 3 - } // Calculate the maximum possible number of labels we could return so we can preallocate l. - maxLabelCount := attributes.Len() + len(settings.ExternalLabels) + len(promotedAttrs) + scopeLabelCount + len(extras)/2 + maxLabelCount := attributes.Len() + len(settings.ExternalLabels) + len(promotedAttrs) + len(extras)/2 if haveServiceName { maxLabelCount++ @@ -176,19 +170,6 @@ func createAttributes(resource pcommon.Resource, attributes pcommon.Map, scope s l[normalized] = lbl.Value } } - if promoteScope { - l["otel_scope_name"] = scope.name - l["otel_scope_version"] = scope.version - l["otel_scope_schema_url"] = scope.schemaURL - scope.attributes.Range(func(k string, v pcommon.Value) bool { - name := "otel_scope_" + k - if !settings.AllowUTF8 { - name = otlptranslator.NormalizeLabel(name) - } - l[name] = v.AsString() - return true - }) - } // Map service.name + service.namespace to job. if haveServiceName { @@ -259,7 +240,7 @@ func aggregationTemporality(metric pmetric.Metric) (pmetric.AggregationTemporali // However, work is under way to resolve this shortcoming through a feature called native histograms custom buckets: // https://github.com/prometheus/prometheus/issues/13485. func (c *PrometheusConverter) addHistogramDataPoints(ctx context.Context, dataPoints pmetric.HistogramDataPointSlice, - resource pcommon.Resource, settings Settings, baseName string, scope scope, + resource pcommon.Resource, settings Settings, baseName string, ) error { for x := 0; x < dataPoints.Len(); x++ { if err := c.everyN.checkContext(ctx); err != nil { @@ -268,7 +249,7 @@ func (c *PrometheusConverter) addHistogramDataPoints(ctx context.Context, dataPo pt := dataPoints.At(x) timestamp := convertTimeStamp(pt.Timestamp()) - baseLabels := createAttributes(resource, pt.Attributes(), scope, settings, nil, false) + baseLabels := createAttributes(resource, pt.Attributes(), settings, nil, false) // If the sum is unset, it indicates the _sum metric point should be // omitted @@ -459,7 +440,7 @@ func mostRecentTimestampInMetric(metric pmetric.Metric) pcommon.Timestamp { } func (c *PrometheusConverter) addSummaryDataPoints(ctx context.Context, dataPoints pmetric.SummaryDataPointSlice, resource pcommon.Resource, - settings Settings, baseName string, scope scope, + settings Settings, baseName string, ) error { for x := 0; x < dataPoints.Len(); x++ { if err := c.everyN.checkContext(ctx); err != nil { @@ -468,7 +449,7 @@ func (c *PrometheusConverter) addSummaryDataPoints(ctx context.Context, dataPoin pt := dataPoints.At(x) timestamp := convertTimeStamp(pt.Timestamp()) - baseLabels := createAttributes(resource, pt.Attributes(), scope, settings, nil, false) + baseLabels := createAttributes(resource, pt.Attributes(), settings, nil, false) // treat sum as a sample in an individual TimeSeries sum := &prompb.Sample{ @@ -621,7 +602,7 @@ func addResourceTargetInfo(resource pcommon.Resource, settings Settings, timesta // Do not pass identifying attributes as ignoreAttrs below. identifyingAttrs = nil } - labels := createAttributes(resource, attributes, scope{}, settings, identifyingAttrs, false, model.MetricNameLabel, name) + labels := createAttributes(resource, attributes, settings, identifyingAttrs, false, model.MetricNameLabel, name) haveIdentifier := false for _, l := range labels { if l.Name == model.JobLabel || l.Name == model.InstanceLabel { diff --git a/storage/remote/otlptranslator/prometheusremotewrite/helper_test.go b/storage/remote/otlptranslator/prometheusremotewrite/helper_test.go index 88d00ee980..2551f8fb39 100644 --- a/storage/remote/otlptranslator/prometheusremotewrite/helper_test.go +++ b/storage/remote/otlptranslator/prometheusremotewrite/helper_test.go @@ -43,17 +43,6 @@ func TestCreateAttributes(t *testing.T) { // This one is for testing conflict with auto-generated instance attribute. "instance": "resource value", } - scopeAttrs := pcommon.NewMap() - scopeAttrs.FromRaw(map[string]any{ - "attr1": "value1", - "attr2": "value2", - }) - defaultScope := scope{ - name: "test-scope", - version: "1.0.0", - schemaURL: "https://schema.com", - attributes: scopeAttrs, - } resource := pcommon.NewResource() for k, v := range resourceAttrs { @@ -65,19 +54,15 @@ func TestCreateAttributes(t *testing.T) { testCases := []struct { name string - scope scope promoteAllResourceAttributes bool promoteResourceAttributes []string - promoteScope bool ignoreResourceAttributes []string ignoreAttrs []string expectedLabels []prompb.Label }{ { - name: "Successful conversion without resource attribute promotion and without scope promotion", - scope: defaultScope, + name: "Successful conversion without resource attribute promotion", promoteResourceAttributes: nil, - promoteScope: false, expectedLabels: []prompb.Label{ { Name: "__name__", @@ -102,86 +87,8 @@ func TestCreateAttributes(t *testing.T) { }, }, { - name: "Successful conversion without resource attribute promotion and with scope promotion", - scope: defaultScope, + name: "Successful conversion with some attributes ignored", promoteResourceAttributes: nil, - promoteScope: true, - expectedLabels: []prompb.Label{ - { - Name: "__name__", - Value: "test_metric", - }, - { - Name: "instance", - Value: "service ID", - }, - { - Name: "job", - Value: "service name", - }, - { - Name: "metric_attr", - Value: "metric value", - }, - { - Name: "metric_attr_other", - Value: "metric value other", - }, - { - Name: "otel_scope_name", - Value: defaultScope.name, - }, - { - Name: "otel_scope_schema_url", - Value: defaultScope.schemaURL, - }, - { - Name: "otel_scope_version", - Value: defaultScope.version, - }, - { - Name: "otel_scope_attr1", - Value: "value1", - }, - { - Name: "otel_scope_attr2", - Value: "value2", - }, - }, - }, - { - name: "Successful conversion without resource attribute promotion and with scope promotion, but without scope", - scope: scope{}, - promoteResourceAttributes: nil, - promoteScope: true, - expectedLabels: []prompb.Label{ - { - Name: "__name__", - Value: "test_metric", - }, - { - Name: "instance", - Value: "service ID", - }, - { - Name: "job", - Value: "service name", - }, - { - Name: "metric_attr", - Value: "metric value", - }, - { - Name: "metric_attr_other", - Value: "metric value other", - }, - }, - }, - { - name: "Successful conversion with some attributes ignored and with scope promotion", - scope: defaultScope, - promoteResourceAttributes: nil, - promoteScope: true, ignoreAttrs: []string{"metric-attr-other"}, expectedLabels: []prompb.Label{ { @@ -200,33 +107,11 @@ func TestCreateAttributes(t *testing.T) { Name: "metric_attr", Value: "metric value", }, - { - Name: "otel_scope_name", - Value: defaultScope.name, - }, - { - Name: "otel_scope_schema_url", - Value: defaultScope.schemaURL, - }, - { - Name: "otel_scope_version", - Value: defaultScope.version, - }, - { - Name: "otel_scope_attr1", - Value: "value1", - }, - { - Name: "otel_scope_attr2", - Value: "value2", - }, }, }, { - name: "Successful conversion with resource attribute promotion and with scope promotion", - scope: defaultScope, + name: "Successful conversion with resource attribute promotion", promoteResourceAttributes: []string{"non-existent-attr", "existent-attr"}, - promoteScope: true, expectedLabels: []prompb.Label{ { Name: "__name__", @@ -252,33 +137,11 @@ func TestCreateAttributes(t *testing.T) { Name: "existent_attr", Value: "resource value", }, - { - Name: "otel_scope_name", - Value: defaultScope.name, - }, - { - Name: "otel_scope_schema_url", - Value: defaultScope.schemaURL, - }, - { - Name: "otel_scope_version", - Value: defaultScope.version, - }, - { - Name: "otel_scope_attr1", - Value: "value1", - }, - { - Name: "otel_scope_attr2", - Value: "value2", - }, }, }, { - name: "Successful conversion with resource attribute promotion and with scope promotion, conflicting resource attributes are ignored", - scope: defaultScope, + name: "Successful conversion with resource attribute promotion, conflicting resource attributes are ignored", promoteResourceAttributes: []string{"non-existent-attr", "existent-attr", "metric-attr", "job", "instance"}, - promoteScope: true, expectedLabels: []prompb.Label{ { Name: "__name__", @@ -304,33 +167,11 @@ func TestCreateAttributes(t *testing.T) { Name: "metric_attr_other", Value: "metric value other", }, - { - Name: "otel_scope_name", - Value: defaultScope.name, - }, - { - Name: "otel_scope_schema_url", - Value: defaultScope.schemaURL, - }, - { - Name: "otel_scope_version", - Value: defaultScope.version, - }, - { - Name: "otel_scope_attr1", - Value: "value1", - }, - { - Name: "otel_scope_attr2", - Value: "value2", - }, }, }, { - name: "Successful conversion with resource attribute promotion and with scope promotion, attributes are only promoted once", - scope: defaultScope, + name: "Successful conversion with resource attribute promotion, attributes are only promoted once", promoteResourceAttributes: []string{"existent-attr", "existent-attr"}, - promoteScope: true, expectedLabels: []prompb.Label{ { Name: "__name__", @@ -356,33 +197,11 @@ func TestCreateAttributes(t *testing.T) { Name: "metric_attr_other", Value: "metric value other", }, - { - Name: "otel_scope_name", - Value: defaultScope.name, - }, - { - Name: "otel_scope_schema_url", - Value: defaultScope.schemaURL, - }, - { - Name: "otel_scope_version", - Value: defaultScope.version, - }, - { - Name: "otel_scope_attr1", - Value: "value1", - }, - { - Name: "otel_scope_attr2", - Value: "value2", - }, }, }, { - name: "Successful conversion promoting all resource attributes and with scope promotion", - scope: defaultScope, + name: "Successful conversion promoting all resource attributes", promoteAllResourceAttributes: true, - promoteScope: true, expectedLabels: []prompb.Label{ { Name: "__name__", @@ -416,33 +235,11 @@ func TestCreateAttributes(t *testing.T) { Name: "service_instance_id", Value: "service ID", }, - { - Name: "otel_scope_name", - Value: defaultScope.name, - }, - { - Name: "otel_scope_schema_url", - Value: defaultScope.schemaURL, - }, - { - Name: "otel_scope_version", - Value: defaultScope.version, - }, - { - Name: "otel_scope_attr1", - Value: "value1", - }, - { - Name: "otel_scope_attr2", - Value: "value2", - }, }, }, { - name: "Successful conversion promoting all resource attributes and with scope promotion, ignoring 'service.instance.id'", - scope: defaultScope, + name: "Successful conversion promoting all resource attributes, ignoring 'service.instance.id'", promoteAllResourceAttributes: true, - promoteScope: true, ignoreResourceAttributes: []string{ "service.instance.id", }, @@ -475,26 +272,6 @@ func TestCreateAttributes(t *testing.T) { Name: "service_name", Value: "service name", }, - { - Name: "otel_scope_name", - Value: defaultScope.name, - }, - { - Name: "otel_scope_schema_url", - Value: defaultScope.schemaURL, - }, - { - Name: "otel_scope_version", - Value: defaultScope.version, - }, - { - Name: "otel_scope_attr1", - Value: "value1", - }, - { - Name: "otel_scope_attr2", - Value: "value2", - }, }, }, } @@ -506,9 +283,8 @@ func TestCreateAttributes(t *testing.T) { PromoteResourceAttributes: tc.promoteResourceAttributes, IgnoreResourceAttributes: tc.ignoreResourceAttributes, }), - PromoteScopeMetadata: tc.promoteScope, } - lbls := createAttributes(resource, attrs, tc.scope, settings, tc.ignoreAttrs, false, model.MetricNameLabel, "test_metric") + lbls := createAttributes(resource, attrs, settings, tc.ignoreAttrs, false, model.MetricNameLabel, "test_metric") require.ElementsMatch(t, lbls, tc.expectedLabels) }) @@ -534,28 +310,14 @@ func Test_convertTimeStamp(t *testing.T) { } func TestPrometheusConverter_AddSummaryDataPoints(t *testing.T) { - scopeAttrs := pcommon.NewMap() - scopeAttrs.FromRaw(map[string]any{ - "attr1": "value1", - "attr2": "value2", - }) - defaultScope := scope{ - name: "test-scope", - version: "1.0.0", - schemaURL: "https://schema.com", - attributes: scopeAttrs, - } - ts := pcommon.Timestamp(time.Now().UnixNano()) tests := []struct { - name string - metric func() pmetric.Metric - scope scope - promoteScope bool - want func() map[uint64]*prompb.TimeSeries + name string + metric func() pmetric.Metric + want func() map[uint64]*prompb.TimeSeries }{ { - name: "summary with start time and without scope promotion", + name: "summary with start time", metric: func() pmetric.Metric { metric := pmetric.NewMetric() metric.SetName("test_summary") @@ -567,8 +329,6 @@ func TestPrometheusConverter_AddSummaryDataPoints(t *testing.T) { return metric }, - scope: defaultScope, - promoteScope: false, want: func() map[uint64]*prompb.TimeSeries { countLabels := []prompb.Label{ {Name: model.MetricNameLabel, Value: "test_summary" + countStr}, @@ -602,79 +362,7 @@ func TestPrometheusConverter_AddSummaryDataPoints(t *testing.T) { }, }, { - name: "summary with start time and with scope promotion", - metric: func() pmetric.Metric { - metric := pmetric.NewMetric() - metric.SetName("test_summary") - metric.SetEmptySummary() - - dp := metric.Summary().DataPoints().AppendEmpty() - dp.SetTimestamp(ts) - dp.SetStartTimestamp(ts) - - return metric - }, - scope: defaultScope, - promoteScope: true, - want: func() map[uint64]*prompb.TimeSeries { - scopeLabels := []prompb.Label{ - { - Name: "otel_scope_attr1", - Value: "value1", - }, - { - Name: "otel_scope_attr2", - Value: "value2", - }, - { - Name: "otel_scope_name", - Value: defaultScope.name, - }, - { - Name: "otel_scope_schema_url", - Value: defaultScope.schemaURL, - }, - { - Name: "otel_scope_version", - Value: defaultScope.version, - }, - } - countLabels := append([]prompb.Label{ - {Name: model.MetricNameLabel, Value: "test_summary" + countStr}, - }, scopeLabels...) - sumLabels := append([]prompb.Label{ - {Name: model.MetricNameLabel, Value: "test_summary" + sumStr}, - }, scopeLabels...) - createdLabels := append([]prompb.Label{ - { - Name: model.MetricNameLabel, - Value: "test_summary" + createdSuffix, - }, - }, scopeLabels...) - return map[uint64]*prompb.TimeSeries{ - timeSeriesSignature(countLabels): { - Labels: countLabels, - Samples: []prompb.Sample{ - {Value: 0, Timestamp: convertTimeStamp(ts)}, - }, - }, - timeSeriesSignature(sumLabels): { - Labels: sumLabels, - Samples: []prompb.Sample{ - {Value: 0, Timestamp: convertTimeStamp(ts)}, - }, - }, - timeSeriesSignature(createdLabels): { - Labels: createdLabels, - Samples: []prompb.Sample{ - {Value: float64(convertTimeStamp(ts)), Timestamp: convertTimeStamp(ts)}, - }, - }, - } - }, - }, - { - name: "summary without start time and without scope promotion", + name: "summary without start time", metric: func() pmetric.Metric { metric := pmetric.NewMetric() metric.SetName("test_summary") @@ -685,7 +373,6 @@ func TestPrometheusConverter_AddSummaryDataPoints(t *testing.T) { return metric }, - promoteScope: false, want: func() map[uint64]*prompb.TimeSeries { countLabels := []prompb.Label{ {Name: model.MetricNameLabel, Value: "test_summary" + countStr}, @@ -720,11 +407,9 @@ func TestPrometheusConverter_AddSummaryDataPoints(t *testing.T) { metric.Summary().DataPoints(), pcommon.NewResource(), Settings{ - PromoteScopeMetadata: tt.promoteScope, - ExportCreatedMetric: true, + ExportCreatedMetric: true, }, metric.Name(), - tt.scope, ) testutil.RequireEqual(t, tt.want(), converter.unique) @@ -734,28 +419,14 @@ func TestPrometheusConverter_AddSummaryDataPoints(t *testing.T) { } func TestPrometheusConverter_AddHistogramDataPoints(t *testing.T) { - scopeAttrs := pcommon.NewMap() - scopeAttrs.FromRaw(map[string]any{ - "attr1": "value1", - "attr2": "value2", - }) - defaultScope := scope{ - name: "test-scope", - version: "1.0.0", - schemaURL: "https://schema.com", - attributes: scopeAttrs, - } - ts := pcommon.Timestamp(time.Now().UnixNano()) tests := []struct { - name string - metric func() pmetric.Metric - scope scope - promoteScope bool - want func() map[uint64]*prompb.TimeSeries + name string + metric func() pmetric.Metric + want func() map[uint64]*prompb.TimeSeries }{ { - name: "histogram with start time and without scope promotion", + name: "histogram with start time", metric: func() pmetric.Metric { metric := pmetric.NewMetric() metric.SetName("test_hist") @@ -767,8 +438,6 @@ func TestPrometheusConverter_AddHistogramDataPoints(t *testing.T) { return metric }, - scope: defaultScope, - promoteScope: false, want: func() map[uint64]*prompb.TimeSeries { countLabels := []prompb.Label{ {Name: model.MetricNameLabel, Value: "test_hist" + countStr}, @@ -802,76 +471,6 @@ func TestPrometheusConverter_AddHistogramDataPoints(t *testing.T) { } }, }, - { - name: "histogram with start time and with scope promotion", - metric: func() pmetric.Metric { - metric := pmetric.NewMetric() - metric.SetName("test_hist") - metric.SetEmptyHistogram().SetAggregationTemporality(pmetric.AggregationTemporalityCumulative) - - pt := metric.Histogram().DataPoints().AppendEmpty() - pt.SetTimestamp(ts) - pt.SetStartTimestamp(ts) - - return metric - }, - scope: defaultScope, - promoteScope: true, - want: func() map[uint64]*prompb.TimeSeries { - scopeLabels := []prompb.Label{ - { - Name: "otel_scope_attr1", - Value: "value1", - }, - { - Name: "otel_scope_attr2", - Value: "value2", - }, - { - Name: "otel_scope_name", - Value: defaultScope.name, - }, - { - Name: "otel_scope_schema_url", - Value: defaultScope.schemaURL, - }, - { - Name: "otel_scope_version", - Value: defaultScope.version, - }, - } - countLabels := append([]prompb.Label{ - {Name: model.MetricNameLabel, Value: "test_hist" + countStr}, - }, scopeLabels...) - infLabels := append([]prompb.Label{ - {Name: model.MetricNameLabel, Value: "test_hist_bucket"}, - {Name: model.BucketLabel, Value: "+Inf"}, - }, scopeLabels...) - createdLabels := append([]prompb.Label{ - {Name: model.MetricNameLabel, Value: "test_hist" + createdSuffix}, - }, scopeLabels...) - return map[uint64]*prompb.TimeSeries{ - timeSeriesSignature(countLabels): { - Labels: countLabels, - Samples: []prompb.Sample{ - {Value: 0, Timestamp: convertTimeStamp(ts)}, - }, - }, - timeSeriesSignature(infLabels): { - Labels: infLabels, - Samples: []prompb.Sample{ - {Value: 0, Timestamp: convertTimeStamp(ts)}, - }, - }, - timeSeriesSignature(createdLabels): { - Labels: createdLabels, - Samples: []prompb.Sample{ - {Value: float64(convertTimeStamp(ts)), Timestamp: convertTimeStamp(ts)}, - }, - }, - } - }, - }, { name: "histogram without start time", metric: func() pmetric.Metric { @@ -919,11 +518,9 @@ func TestPrometheusConverter_AddHistogramDataPoints(t *testing.T) { metric.Histogram().DataPoints(), pcommon.NewResource(), Settings{ - ExportCreatedMetric: true, - PromoteScopeMetadata: tt.promoteScope, + ExportCreatedMetric: true, }, metric.Name(), - tt.scope, ) require.Equal(t, tt.want(), converter.unique) diff --git a/storage/remote/otlptranslator/prometheusremotewrite/histograms.go b/storage/remote/otlptranslator/prometheusremotewrite/histograms.go index 855e122213..c5f47fd9d0 100644 --- a/storage/remote/otlptranslator/prometheusremotewrite/histograms.go +++ b/storage/remote/otlptranslator/prometheusremotewrite/histograms.go @@ -37,7 +37,6 @@ const defaultZeroThreshold = 1e-128 // as native histogram samples. func (c *PrometheusConverter) addExponentialHistogramDataPoints(ctx context.Context, dataPoints pmetric.ExponentialHistogramDataPointSlice, resource pcommon.Resource, settings Settings, promName string, temporality pmetric.AggregationTemporality, - scope scope, ) (annotations.Annotations, error) { var annots annotations.Annotations for x := 0; x < dataPoints.Len(); x++ { @@ -56,7 +55,6 @@ func (c *PrometheusConverter) addExponentialHistogramDataPoints(ctx context.Cont lbls := createAttributes( resource, pt.Attributes(), - scope, settings, nil, true, @@ -254,7 +252,6 @@ func convertBucketsLayout(bucketCounts []uint64, offset, scaleDown int32, adjust func (c *PrometheusConverter) addCustomBucketsHistogramDataPoints(ctx context.Context, dataPoints pmetric.HistogramDataPointSlice, resource pcommon.Resource, settings Settings, promName string, temporality pmetric.AggregationTemporality, - scope scope, ) (annotations.Annotations, error) { var annots annotations.Annotations @@ -274,7 +271,6 @@ func (c *PrometheusConverter) addCustomBucketsHistogramDataPoints(ctx context.Co lbls := createAttributes( resource, pt.Attributes(), - scope, settings, nil, true, diff --git a/storage/remote/otlptranslator/prometheusremotewrite/histograms_test.go b/storage/remote/otlptranslator/prometheusremotewrite/histograms_test.go index eb8e80ee0f..766e774458 100644 --- a/storage/remote/otlptranslator/prometheusremotewrite/histograms_test.go +++ b/storage/remote/otlptranslator/prometheusremotewrite/histograms_test.go @@ -620,27 +620,13 @@ func validateNativeHistogramCount(t *testing.T, h prompb.Histogram) { } func TestPrometheusConverter_addExponentialHistogramDataPoints(t *testing.T) { - scopeAttrs := pcommon.NewMap() - scopeAttrs.FromRaw(map[string]any{ - "attr1": "value1", - "attr2": "value2", - }) - defaultScope := scope{ - name: "test-scope", - version: "1.0.0", - schemaURL: "https://schema.com", - attributes: scopeAttrs, - } - tests := []struct { - name string - metric func() pmetric.Metric - scope scope - promoteScope bool - wantSeries func() map[uint64]*prompb.TimeSeries + name string + metric func() pmetric.Metric + wantSeries func() map[uint64]*prompb.TimeSeries }{ { - name: "histogram data points with same labels and without scope promotion", + name: "histogram data points with same labels", metric: func() pmetric.Metric { metric := pmetric.NewMetric() metric.SetName("test_hist") @@ -664,8 +650,6 @@ func TestPrometheusConverter_addExponentialHistogramDataPoints(t *testing.T) { return metric }, - scope: defaultScope, - promoteScope: false, wantSeries: func() map[uint64]*prompb.TimeSeries { labels := []prompb.Label{ {Name: model.MetricNameLabel, Value: "test_hist"}, @@ -701,73 +685,7 @@ func TestPrometheusConverter_addExponentialHistogramDataPoints(t *testing.T) { }, }, { - name: "histogram data points with same labels and with scope promotion", - metric: func() pmetric.Metric { - metric := pmetric.NewMetric() - metric.SetName("test_hist") - metric.SetEmptyExponentialHistogram().SetAggregationTemporality(pmetric.AggregationTemporalityCumulative) - - pt := metric.ExponentialHistogram().DataPoints().AppendEmpty() - pt.SetCount(7) - pt.SetScale(1) - pt.Positive().SetOffset(-1) - pt.Positive().BucketCounts().FromRaw([]uint64{4, 2}) - pt.Exemplars().AppendEmpty().SetDoubleValue(1) - pt.Attributes().PutStr("attr", "test_attr") - - pt = metric.ExponentialHistogram().DataPoints().AppendEmpty() - pt.SetCount(4) - pt.SetScale(1) - pt.Positive().SetOffset(-1) - pt.Positive().BucketCounts().FromRaw([]uint64{4, 2, 1}) - pt.Exemplars().AppendEmpty().SetDoubleValue(2) - pt.Attributes().PutStr("attr", "test_attr") - - return metric - }, - scope: defaultScope, - promoteScope: true, - wantSeries: func() map[uint64]*prompb.TimeSeries { - labels := []prompb.Label{ - {Name: model.MetricNameLabel, Value: "test_hist"}, - {Name: "attr", Value: "test_attr"}, - {Name: "otel_scope_name", Value: defaultScope.name}, - {Name: "otel_scope_schema_url", Value: defaultScope.schemaURL}, - {Name: "otel_scope_version", Value: defaultScope.version}, - {Name: "otel_scope_attr1", Value: "value1"}, - {Name: "otel_scope_attr2", Value: "value2"}, - } - return map[uint64]*prompb.TimeSeries{ - timeSeriesSignature(labels): { - Labels: labels, - Histograms: []prompb.Histogram{ - { - Count: &prompb.Histogram_CountInt{CountInt: 7}, - Schema: 1, - ZeroThreshold: defaultZeroThreshold, - ZeroCount: &prompb.Histogram_ZeroCountInt{ZeroCountInt: 0}, - PositiveSpans: []prompb.BucketSpan{{Offset: 0, Length: 2}}, - PositiveDeltas: []int64{4, -2}, - }, - { - Count: &prompb.Histogram_CountInt{CountInt: 4}, - Schema: 1, - ZeroThreshold: defaultZeroThreshold, - ZeroCount: &prompb.Histogram_ZeroCountInt{ZeroCountInt: 0}, - PositiveSpans: []prompb.BucketSpan{{Offset: 0, Length: 3}}, - PositiveDeltas: []int64{4, -2, -1}, - }, - }, - Exemplars: []prompb.Exemplar{ - {Value: 1}, - {Value: 2}, - }, - }, - } - }, - }, - { - name: "histogram data points with different labels and without scope promotion", + name: "histogram data points with different labels", metric: func() pmetric.Metric { metric := pmetric.NewMetric() metric.SetName("test_hist") @@ -791,8 +709,6 @@ func TestPrometheusConverter_addExponentialHistogramDataPoints(t *testing.T) { return metric }, - scope: defaultScope, - promoteScope: false, wantSeries: func() map[uint64]*prompb.TimeSeries { labels := []prompb.Label{ {Name: model.MetricNameLabel, Value: "test_hist"}, @@ -853,12 +769,10 @@ func TestPrometheusConverter_addExponentialHistogramDataPoints(t *testing.T) { metric.ExponentialHistogram().DataPoints(), pcommon.NewResource(), Settings{ - ExportCreatedMetric: true, - PromoteScopeMetadata: tt.promoteScope, + ExportCreatedMetric: true, }, namer.Build(TranslatorMetricFromOtelMetric(metric)), pmetric.AggregationTemporalityCumulative, - tt.scope, ) require.NoError(t, err) require.Empty(t, annots) @@ -1077,27 +991,13 @@ func TestHistogramToCustomBucketsHistogram(t *testing.T) { } func TestPrometheusConverter_addCustomBucketsHistogramDataPoints(t *testing.T) { - scopeAttrs := pcommon.NewMap() - scopeAttrs.FromRaw(map[string]any{ - "attr1": "value1", - "attr2": "value2", - }) - defaultScope := scope{ - name: "test-scope", - version: "1.0.0", - schemaURL: "https://schema.com", - attributes: scopeAttrs, - } - tests := []struct { - name string - metric func() pmetric.Metric - scope scope - promoteScope bool - wantSeries func() map[uint64]*prompb.TimeSeries + name string + metric func() pmetric.Metric + wantSeries func() map[uint64]*prompb.TimeSeries }{ { - name: "histogram data points with same labels and without scope promotion", + name: "histogram data points with same labels", metric: func() pmetric.Metric { metric := pmetric.NewMetric() metric.SetName("test_hist_to_nhcb") @@ -1121,8 +1021,6 @@ func TestPrometheusConverter_addCustomBucketsHistogramDataPoints(t *testing.T) { return metric }, - scope: defaultScope, - promoteScope: false, wantSeries: func() map[uint64]*prompb.TimeSeries { labels := []prompb.Label{ {Name: model.MetricNameLabel, Value: "test_hist_to_nhcb"}, @@ -1158,73 +1056,7 @@ func TestPrometheusConverter_addCustomBucketsHistogramDataPoints(t *testing.T) { }, }, { - name: "histogram data points with same labels and with scope promotion", - metric: func() pmetric.Metric { - metric := pmetric.NewMetric() - metric.SetName("test_hist_to_nhcb") - metric.SetEmptyHistogram().SetAggregationTemporality(pmetric.AggregationTemporalityCumulative) - - pt := metric.Histogram().DataPoints().AppendEmpty() - pt.SetCount(3) - pt.SetSum(3) - pt.BucketCounts().FromRaw([]uint64{2, 0, 1}) - pt.ExplicitBounds().FromRaw([]float64{5, 10}) - pt.Exemplars().AppendEmpty().SetDoubleValue(1) - pt.Attributes().PutStr("attr", "test_attr") - - pt = metric.Histogram().DataPoints().AppendEmpty() - pt.SetCount(11) - pt.SetSum(5) - pt.BucketCounts().FromRaw([]uint64{3, 8, 0}) - pt.ExplicitBounds().FromRaw([]float64{0, 1}) - pt.Exemplars().AppendEmpty().SetDoubleValue(2) - pt.Attributes().PutStr("attr", "test_attr") - - return metric - }, - scope: defaultScope, - promoteScope: true, - wantSeries: func() map[uint64]*prompb.TimeSeries { - labels := []prompb.Label{ - {Name: model.MetricNameLabel, Value: "test_hist_to_nhcb"}, - {Name: "attr", Value: "test_attr"}, - {Name: "otel_scope_name", Value: defaultScope.name}, - {Name: "otel_scope_schema_url", Value: defaultScope.schemaURL}, - {Name: "otel_scope_version", Value: defaultScope.version}, - {Name: "otel_scope_attr1", Value: "value1"}, - {Name: "otel_scope_attr2", Value: "value2"}, - } - return map[uint64]*prompb.TimeSeries{ - timeSeriesSignature(labels): { - Labels: labels, - Histograms: []prompb.Histogram{ - { - Count: &prompb.Histogram_CountInt{CountInt: 3}, - Sum: 3, - Schema: -53, - PositiveSpans: []prompb.BucketSpan{{Offset: 0, Length: 3}}, - PositiveDeltas: []int64{2, -2, 1}, - CustomValues: []float64{5, 10}, - }, - { - Count: &prompb.Histogram_CountInt{CountInt: 11}, - Sum: 5, - Schema: -53, - PositiveSpans: []prompb.BucketSpan{{Offset: 0, Length: 3}}, - PositiveDeltas: []int64{3, 5, -8}, - CustomValues: []float64{0, 1}, - }, - }, - Exemplars: []prompb.Exemplar{ - {Value: 1}, - {Value: 2}, - }, - }, - } - }, - }, - { - name: "histogram data points with different labels and without scope promotion", + name: "histogram data points with different labels", metric: func() pmetric.Metric { metric := pmetric.NewMetric() metric.SetName("test_hist_to_nhcb") @@ -1248,8 +1080,6 @@ func TestPrometheusConverter_addCustomBucketsHistogramDataPoints(t *testing.T) { return metric }, - scope: defaultScope, - promoteScope: false, wantSeries: func() map[uint64]*prompb.TimeSeries { labels := []prompb.Label{ {Name: model.MetricNameLabel, Value: "test_hist_to_nhcb"}, @@ -1312,11 +1142,9 @@ func TestPrometheusConverter_addCustomBucketsHistogramDataPoints(t *testing.T) { Settings{ ExportCreatedMetric: true, ConvertHistogramsToNHCB: true, - PromoteScopeMetadata: tt.promoteScope, }, namer.Build(TranslatorMetricFromOtelMetric(metric)), pmetric.AggregationTemporalityCumulative, - tt.scope, ) require.NoError(t, err) diff --git a/storage/remote/otlptranslator/prometheusremotewrite/metrics_to_prw.go b/storage/remote/otlptranslator/prometheusremotewrite/metrics_to_prw.go index 8d5c73e37c..595775d3b4 100644 --- a/storage/remote/otlptranslator/prometheusremotewrite/metrics_to_prw.go +++ b/storage/remote/otlptranslator/prometheusremotewrite/metrics_to_prw.go @@ -48,8 +48,6 @@ type Settings struct { KeepIdentifyingResourceAttributes bool ConvertHistogramsToNHCB bool AllowDeltaTemporality bool - // PromoteScopeMetadata controls whether to promote OTel scope metadata to metric labels. - PromoteScopeMetadata bool } // PrometheusConverter converts from OTel write format to Prometheus remote write format. @@ -92,23 +90,6 @@ func TranslatorMetricFromOtelMetric(metric pmetric.Metric) otlptranslator.Metric return m } -type scope struct { - name string - version string - schemaURL string - attributes pcommon.Map -} - -func newScopeFromScopeMetrics(scopeMetrics pmetric.ScopeMetrics) scope { - s := scopeMetrics.Scope() - return scope{ - name: s.Name(), - version: s.Version(), - schemaURL: scopeMetrics.SchemaUrl(), - attributes: s.Attributes(), - } -} - // FromMetrics converts pmetric.Metrics to Prometheus remote write format. func (c *PrometheusConverter) FromMetrics(ctx context.Context, md pmetric.Metrics, settings Settings) (annots annotations.Annotations, errs error) { namer := otlptranslator.MetricNamer{ @@ -136,9 +117,7 @@ func (c *PrometheusConverter) FromMetrics(ctx context.Context, md pmetric.Metric // use with the "target" info metric var mostRecentTimestamp pcommon.Timestamp for j := 0; j < scopeMetricsSlice.Len(); j++ { - scopeMetrics := scopeMetricsSlice.At(j) - scope := newScopeFromScopeMetrics(scopeMetrics) - metricSlice := scopeMetrics.Metrics() + metricSlice := scopeMetricsSlice.At(j).Metrics() // TODO: decide if instrumentation library information should be exported as labels for k := 0; k < metricSlice.Len(); k++ { @@ -182,7 +161,7 @@ func (c *PrometheusConverter) FromMetrics(ctx context.Context, md pmetric.Metric errs = multierr.Append(errs, fmt.Errorf("empty data points. %s is dropped", metric.Name())) break } - if err := c.addGaugeNumberDataPoints(ctx, dataPoints, resource, settings, promName, scope); err != nil { + if err := c.addGaugeNumberDataPoints(ctx, dataPoints, resource, settings, promName); err != nil { errs = multierr.Append(errs, err) if errors.Is(err, context.Canceled) || errors.Is(err, context.DeadlineExceeded) { return @@ -194,7 +173,7 @@ func (c *PrometheusConverter) FromMetrics(ctx context.Context, md pmetric.Metric errs = multierr.Append(errs, fmt.Errorf("empty data points. %s is dropped", metric.Name())) break } - if err := c.addSumNumberDataPoints(ctx, dataPoints, resource, metric, settings, promName, scope); err != nil { + if err := c.addSumNumberDataPoints(ctx, dataPoints, resource, metric, settings, promName); err != nil { errs = multierr.Append(errs, err) if errors.Is(err, context.Canceled) || errors.Is(err, context.DeadlineExceeded) { return @@ -208,7 +187,7 @@ func (c *PrometheusConverter) FromMetrics(ctx context.Context, md pmetric.Metric } if settings.ConvertHistogramsToNHCB { ws, err := c.addCustomBucketsHistogramDataPoints( - ctx, dataPoints, resource, settings, promName, temporality, scope, + ctx, dataPoints, resource, settings, promName, temporality, ) annots.Merge(ws) if err != nil { @@ -218,7 +197,7 @@ func (c *PrometheusConverter) FromMetrics(ctx context.Context, md pmetric.Metric } } } else { - if err := c.addHistogramDataPoints(ctx, dataPoints, resource, settings, promName, scope); err != nil { + if err := c.addHistogramDataPoints(ctx, dataPoints, resource, settings, promName); err != nil { errs = multierr.Append(errs, err) if errors.Is(err, context.Canceled) || errors.Is(err, context.DeadlineExceeded) { return @@ -238,7 +217,6 @@ func (c *PrometheusConverter) FromMetrics(ctx context.Context, md pmetric.Metric settings, promName, temporality, - scope, ) annots.Merge(ws) if err != nil { @@ -253,7 +231,7 @@ func (c *PrometheusConverter) FromMetrics(ctx context.Context, md pmetric.Metric errs = multierr.Append(errs, fmt.Errorf("empty data points. %s is dropped", metric.Name())) break } - if err := c.addSummaryDataPoints(ctx, dataPoints, resource, settings, promName, scope); err != nil { + if err := c.addSummaryDataPoints(ctx, dataPoints, resource, settings, promName); err != nil { errs = multierr.Append(errs, err) if errors.Is(err, context.Canceled) || errors.Is(err, context.DeadlineExceeded) { return diff --git a/storage/remote/otlptranslator/prometheusremotewrite/number_data_points.go b/storage/remote/otlptranslator/prometheusremotewrite/number_data_points.go index df25e17be0..e89dfd9815 100644 --- a/storage/remote/otlptranslator/prometheusremotewrite/number_data_points.go +++ b/storage/remote/otlptranslator/prometheusremotewrite/number_data_points.go @@ -29,7 +29,7 @@ import ( ) func (c *PrometheusConverter) addGaugeNumberDataPoints(ctx context.Context, dataPoints pmetric.NumberDataPointSlice, - resource pcommon.Resource, settings Settings, name string, scope scope, + resource pcommon.Resource, settings Settings, name string, ) error { for x := 0; x < dataPoints.Len(); x++ { if err := c.everyN.checkContext(ctx); err != nil { @@ -40,7 +40,6 @@ func (c *PrometheusConverter) addGaugeNumberDataPoints(ctx context.Context, data labels := createAttributes( resource, pt.Attributes(), - scope, settings, nil, true, @@ -67,7 +66,7 @@ func (c *PrometheusConverter) addGaugeNumberDataPoints(ctx context.Context, data } func (c *PrometheusConverter) addSumNumberDataPoints(ctx context.Context, dataPoints pmetric.NumberDataPointSlice, - resource pcommon.Resource, metric pmetric.Metric, settings Settings, name string, scope scope, + resource pcommon.Resource, metric pmetric.Metric, settings Settings, name string, ) error { for x := 0; x < dataPoints.Len(); x++ { if err := c.everyN.checkContext(ctx); err != nil { @@ -78,7 +77,6 @@ func (c *PrometheusConverter) addSumNumberDataPoints(ctx context.Context, dataPo lbls := createAttributes( resource, pt.Attributes(), - scope, settings, nil, true, diff --git a/storage/remote/otlptranslator/prometheusremotewrite/number_data_points_test.go b/storage/remote/otlptranslator/prometheusremotewrite/number_data_points_test.go index dfe0a810c8..ca01a162ec 100644 --- a/storage/remote/otlptranslator/prometheusremotewrite/number_data_points_test.go +++ b/storage/remote/otlptranslator/prometheusremotewrite/number_data_points_test.go @@ -30,27 +30,14 @@ import ( ) func TestPrometheusConverter_addGaugeNumberDataPoints(t *testing.T) { - scopeAttrs := pcommon.NewMap() - scopeAttrs.FromRaw(map[string]any{ - "attr1": "value1", - "attr2": "value2", - }) - defaultScope := scope{ - name: "test-scope", - version: "1.0.0", - schemaURL: "https://schema.com", - attributes: scopeAttrs, - } ts := uint64(time.Now().UnixNano()) tests := []struct { - name string - metric func() pmetric.Metric - scope scope - promoteScope bool - want func() map[uint64]*prompb.TimeSeries + name string + metric func() pmetric.Metric + want func() map[uint64]*prompb.TimeSeries }{ { - name: "gauge without scope promotion", + name: "gauge", metric: func() pmetric.Metric { return getIntGaugeMetric( "test", @@ -58,8 +45,6 @@ func TestPrometheusConverter_addGaugeNumberDataPoints(t *testing.T) { 1, ts, ) }, - scope: defaultScope, - promoteScope: false, want: func() map[uint64]*prompb.TimeSeries { labels := []prompb.Label{ {Name: model.MetricNameLabel, Value: "test"}, @@ -77,39 +62,6 @@ func TestPrometheusConverter_addGaugeNumberDataPoints(t *testing.T) { } }, }, - { - name: "gauge with scope promotion", - metric: func() pmetric.Metric { - return getIntGaugeMetric( - "test", - pcommon.NewMap(), - 1, ts, - ) - }, - scope: defaultScope, - promoteScope: true, - want: func() map[uint64]*prompb.TimeSeries { - labels := []prompb.Label{ - {Name: model.MetricNameLabel, Value: "test"}, - {Name: "otel_scope_name", Value: defaultScope.name}, - {Name: "otel_scope_schema_url", Value: defaultScope.schemaURL}, - {Name: "otel_scope_version", Value: defaultScope.version}, - {Name: "otel_scope_attr1", Value: "value1"}, - {Name: "otel_scope_attr2", Value: "value2"}, - } - return map[uint64]*prompb.TimeSeries{ - timeSeriesSignature(labels): { - Labels: labels, - Samples: []prompb.Sample{ - { - Value: 1, - Timestamp: convertTimeStamp(pcommon.Timestamp(ts)), - }, - }, - }, - } - }, - }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { @@ -121,11 +73,9 @@ func TestPrometheusConverter_addGaugeNumberDataPoints(t *testing.T) { metric.Gauge().DataPoints(), pcommon.NewResource(), Settings{ - ExportCreatedMetric: true, - PromoteScopeMetadata: tt.promoteScope, + ExportCreatedMetric: true, }, metric.Name(), - tt.scope, ) require.Equal(t, tt.want(), converter.unique) @@ -135,27 +85,14 @@ func TestPrometheusConverter_addGaugeNumberDataPoints(t *testing.T) { } func TestPrometheusConverter_addSumNumberDataPoints(t *testing.T) { - scopeAttrs := pcommon.NewMap() - scopeAttrs.FromRaw(map[string]any{ - "attr1": "value1", - "attr2": "value2", - }) - defaultScope := scope{ - name: "test-scope", - version: "1.0.0", - schemaURL: "https://schema.com", - attributes: scopeAttrs, - } ts := pcommon.Timestamp(time.Now().UnixNano()) tests := []struct { - name string - metric func() pmetric.Metric - scope scope - promoteScope bool - want func() map[uint64]*prompb.TimeSeries + name string + metric func() pmetric.Metric + want func() map[uint64]*prompb.TimeSeries }{ { - name: "sum without scope promotion", + name: "sum", metric: func() pmetric.Metric { return getIntSumMetric( "test", @@ -164,8 +101,6 @@ func TestPrometheusConverter_addSumNumberDataPoints(t *testing.T) { uint64(ts.AsTime().UnixNano()), ) }, - scope: defaultScope, - promoteScope: false, want: func() map[uint64]*prompb.TimeSeries { labels := []prompb.Label{ {Name: model.MetricNameLabel, Value: "test"}, @@ -184,41 +119,7 @@ func TestPrometheusConverter_addSumNumberDataPoints(t *testing.T) { }, }, { - name: "sum with scope promotion", - metric: func() pmetric.Metric { - return getIntSumMetric( - "test", - pcommon.NewMap(), - 1, - uint64(ts.AsTime().UnixNano()), - ) - }, - scope: defaultScope, - promoteScope: true, - want: func() map[uint64]*prompb.TimeSeries { - labels := []prompb.Label{ - {Name: model.MetricNameLabel, Value: "test"}, - {Name: "otel_scope_name", Value: defaultScope.name}, - {Name: "otel_scope_schema_url", Value: defaultScope.schemaURL}, - {Name: "otel_scope_version", Value: defaultScope.version}, - {Name: "otel_scope_attr1", Value: "value1"}, - {Name: "otel_scope_attr2", Value: "value2"}, - } - return map[uint64]*prompb.TimeSeries{ - timeSeriesSignature(labels): { - Labels: labels, - Samples: []prompb.Sample{ - { - Value: 1, - Timestamp: convertTimeStamp(ts), - }, - }, - }, - } - }, - }, - { - name: "sum with exemplars and without scope promotion", + name: "sum with exemplars", metric: func() pmetric.Metric { m := getIntSumMetric( "test", @@ -229,8 +130,6 @@ func TestPrometheusConverter_addSumNumberDataPoints(t *testing.T) { m.Sum().DataPoints().At(0).Exemplars().AppendEmpty().SetDoubleValue(2) return m }, - scope: defaultScope, - promoteScope: false, want: func() map[uint64]*prompb.TimeSeries { labels := []prompb.Label{ {Name: model.MetricNameLabel, Value: "test"}, @@ -250,7 +149,7 @@ func TestPrometheusConverter_addSumNumberDataPoints(t *testing.T) { }, }, { - name: "monotonic cumulative sum with start timestamp and without scope promotion", + name: "monotonic cumulative sum with start timestamp", metric: func() pmetric.Metric { metric := pmetric.NewMetric() metric.SetName("test_sum") @@ -264,8 +163,6 @@ func TestPrometheusConverter_addSumNumberDataPoints(t *testing.T) { return metric }, - scope: defaultScope, - promoteScope: false, want: func() map[uint64]*prompb.TimeSeries { labels := []prompb.Label{ {Name: model.MetricNameLabel, Value: "test_sum"}, @@ -290,7 +187,7 @@ func TestPrometheusConverter_addSumNumberDataPoints(t *testing.T) { }, }, { - name: "monotonic cumulative sum with no start time and without scope promotion", + name: "monotonic cumulative sum with no start time", metric: func() pmetric.Metric { metric := pmetric.NewMetric() metric.SetName("test_sum") @@ -302,8 +199,6 @@ func TestPrometheusConverter_addSumNumberDataPoints(t *testing.T) { return metric }, - scope: defaultScope, - promoteScope: false, want: func() map[uint64]*prompb.TimeSeries { labels := []prompb.Label{ {Name: model.MetricNameLabel, Value: "test_sum"}, @@ -319,7 +214,7 @@ func TestPrometheusConverter_addSumNumberDataPoints(t *testing.T) { }, }, { - name: "non-monotonic cumulative sum with start time and without scope promotion", + name: "non-monotonic cumulative sum with start time", metric: func() pmetric.Metric { metric := pmetric.NewMetric() metric.SetName("test_sum") @@ -331,8 +226,6 @@ func TestPrometheusConverter_addSumNumberDataPoints(t *testing.T) { return metric }, - scope: defaultScope, - promoteScope: false, want: func() map[uint64]*prompb.TimeSeries { labels := []prompb.Label{ {Name: model.MetricNameLabel, Value: "test_sum"}, @@ -359,11 +252,9 @@ func TestPrometheusConverter_addSumNumberDataPoints(t *testing.T) { pcommon.NewResource(), metric, Settings{ - ExportCreatedMetric: true, - PromoteScopeMetadata: tt.promoteScope, + ExportCreatedMetric: true, }, metric.Name(), - tt.scope, ) require.Equal(t, tt.want(), converter.unique) diff --git a/storage/remote/write_handler.go b/storage/remote/write_handler.go index fa760f0b49..21b51ba5ef 100644 --- a/storage/remote/write_handler.go +++ b/storage/remote/write_handler.go @@ -596,7 +596,6 @@ func (rw *rwExporter) ConsumeMetrics(ctx context.Context, md pmetric.Metrics) er KeepIdentifyingResourceAttributes: otlpCfg.KeepIdentifyingResourceAttributes, ConvertHistogramsToNHCB: otlpCfg.ConvertHistogramsToNHCB, AllowDeltaTemporality: rw.allowDeltaTemporality, - PromoteScopeMetadata: otlpCfg.PromoteScopeMetadata, }) if err != nil { rw.logger.Warn("Error translating OTLP metrics to Prometheus write request", "err", err)