mirrors/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-09-21 22:01:01 +02:00
Code Issues Projects Releases Wiki Activity

[PERF] PromQL: Replace some simple Sprintf with string concat

Browse Source 
This goes faster because there is no runtime format parsing.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
This commit is contained in:
Bryan Boreham 2025-05-12 15:08:03 +01:00
parent e44ee2f182
commit 49d9261693
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
promql/parser/printer.go
View File

@ -118,11 +118,11 @@ func (node *BinaryExpr) returnBool() string {
func (node *BinaryExpr) String() string { func (node *BinaryExpr) String() string {
matching := node.getMatchingStr() matching := node.getMatchingStr()
return fmt.Sprintf("%s %s%s%s %s", node.LHS, node.Op, node.returnBool(), matching, node.RHS) return node.LHS.String() + " " + node.Op.String() + node.returnBool() + matching + " " + node.RHS.String()
} }
func (node *BinaryExpr) ShortString() string { func (node *BinaryExpr) ShortString() string {
return fmt.Sprintf("%s%s%s", node.Op, node.returnBool(), node.getMatchingStr()) return node.Op.String() + node.returnBool() + node.getMatchingStr()
} }
func (node *BinaryExpr) getMatchingStr() string { func (node *BinaryExpr) getMatchingStr() string {
@ -180,7 +180,7 @@ func (node *DurationExpr) ShortString() string {
} }
func (node *Call) String() string { func (node *Call) String() string {
return fmt.Sprintf("%s(%s)", node.Func.Name, node.Args) return node.Func.Name + "(" + node.Args.String() + ")"
} }
func (node *Call) ShortString() string { func (node *Call) ShortString() string {
@ -294,15 +294,15 @@ func (node *NumberLiteral) String() string {
} }
func (node *ParenExpr) String() string { func (node *ParenExpr) String() string {
return fmt.Sprintf("(%s)", node.Expr) return "(" + node.Expr.String() + ")"
} }
func (node *StringLiteral) String() string { func (node *StringLiteral) String() string {
return fmt.Sprintf("%q", node.Val) return strconv.Quote(node.Val)
} }
func (node *UnaryExpr) String() string { func (node *UnaryExpr) String() string {
return fmt.Sprintf("%s%s", node.Op, node.Expr) return node.Op.String() + node.Expr.String()
} }
func (node *UnaryExpr) ShortString() string { func (node *UnaryExpr) ShortString() string {