mirrors/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-12-05 17:41:21 +01:00
Code Issues Projects Releases Wiki Activity

Add reviewer feedback

Browse Source 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
This commit is contained in:
Arve Knudsen 2025-10-16 16:08:01 +02:00
parent dd3a607d2d
commit 3de3a296dd
2 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
storage/remote/otlptranslator/prometheusremotewrite/helper.go
View File

@ -122,7 +122,7 @@ func (c *PrometheusConverter) createAttributes(resource pcommon.Resource, attrib
} }
} }
err := settings.PromoteResourceAttributes.addPromotedAttributes(c.builder, resourceAttrs, settings.AllowUTF8, settings.LabelNameUnderscoreSanitization, settings.LabelNamePreserveMultipleUnderscores) err := settings.PromoteResourceAttributes.addPromotedAttributes(c.builder, resourceAttrs, labelNamer)
if err != nil { if err != nil {
return labels.EmptyLabels(), err return labels.EmptyLabels(), err
} }

7
storage/remote/otlptranslator/prometheusremotewrite/metrics_to_prw.go
View File

@ -310,16 +310,11 @@ func NewPromoteResourceAttributes(otlpCfg config.OTLPConfig) *PromoteResourceAtt
} }
// addPromotedAttributes adds labels for promoted resourceAttributes to the builder. // addPromotedAttributes adds labels for promoted resourceAttributes to the builder.
func (s *PromoteResourceAttributes) addPromotedAttributes(builder *labels.Builder, resourceAttributes pcommon.Map, allowUTF8, underscoreSanitization, preserveMultipleUnderscores bool) error { func (s *PromoteResourceAttributes) addPromotedAttributes(builder *labels.Builder, resourceAttributes pcommon.Map, labelNamer otlptranslator.LabelNamer) error {
if s == nil { if s == nil {
return nil return nil
} }
labelNamer := otlptranslator.LabelNamer{
UTF8Allowed: allowUTF8,
UnderscoreLabelSanitization: underscoreSanitization,
PreserveMultipleUnderscores: preserveMultipleUnderscores,
}
if s.promoteAll { if s.promoteAll {
var err error var err error
resourceAttributes.Range(func(name string, value pcommon.Value) bool { resourceAttributes.Range(func(name string, value pcommon.Value) bool {