From 39c7fca0e9374ab3c033963dde98c8ce1371feae Mon Sep 17 00:00:00 2001 From: George Krajcsovits Date: Tue, 16 Dec 2025 12:40:45 +0100 Subject: [PATCH] Move CODEOWNERS from .github to root (#17664) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Move CODEOWNERS from .github to root The default maintainers are added to each line to make sure that prometheus team members can still approve if: - specific code owner is not responding - we require code owner review (not currently) Signed-off-by: György Krajcsovits * Apply suggestions from code review Co-authored-by: Bartlomiej Plotka Signed-off-by: George Krajcsovits * Update CODEOWNERS Co-authored-by: Bartlomiej Plotka Signed-off-by: George Krajcsovits * add notice about keeping the files in sync Signed-off-by: György Krajcsovits --------- Signed-off-by: György Krajcsovits Signed-off-by: George Krajcsovits Co-authored-by: Bartlomiej Plotka --- .github/CODEOWNERS | 10 ---------- CODEOWNERS | 26 ++++++++++++++++++++++---- MAINTAINERS.md | 2 ++ 3 files changed, 24 insertions(+), 14 deletions(-) delete mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS deleted file mode 100644 index 7f7cec9cda..0000000000 --- a/.github/CODEOWNERS +++ /dev/null @@ -1,10 +0,0 @@ -/web/ui @juliusv -/web/ui/module @juliusv @nexucis -/storage/remote @cstyan @bwplotka @tomwilkie -/storage/remote/otlptranslator @aknuds1 @jesusvazquez -/discovery/kubernetes @brancz -/tsdb @jesusvazquez -/promql @roidelapluie -/cmd/promtool @dgl -/documentation/prometheus-mixin @metalmatze - diff --git a/CODEOWNERS b/CODEOWNERS index c5b7f25349..7dda7dc1a4 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -2,9 +2,27 @@ # They are code owners by default for the whole repo. * @prometheus/default-maintainers -# Example adding a dedicated maintainer for AWS SD, and also "default -# maintainers" so that they do not need to bypass codeowners check to merge -# something. -# Example comes from +# +# Please keep this file in sync with the MAINTAINERS.md file! +# + +# Subsystems. +/Makefile @simonpasquier @SuperQ @prometheus/default-maintainers +/cmd/promtool @dgl @prometheus/default-maintainers +/documentation/prometheus-mixin @metalmatze @prometheus/default-maintainers +/model/histogram @beorn7 @krajorama @prometheus/default-maintainers +/web/ui @juliusv @prometheus/default-maintainers +/web/ui/module @juliusv @nexucis @prometheus/default-maintainers +/promql @roidelapluie @prometheus/default-maintainers +/storage/remote @cstyan @bwplotka @tomwilkie @npazosmendez @alexgreenbank @prometheus/default-maintainers +/storage/remote/otlptranslator @aknuds1 @jesusvazquez @ArthurSens @prometheus/default-maintainers +/tsdb @jesusvazquez @codesome @bwplotka @krajorama @prometheus/default-maintainers + +# Service discovery. +/discovery/kubernetes @brancz @prometheus/default-maintainers +/discovery/stackit @jkroepke @prometheus/default-maintainers +# Pending # https://github.com/prometheus/prometheus/pull/17105#issuecomment-3248209452 # /discovery/aws/ @matt-gp @prometheus/default-maintainers +# https://github.com/prometheus/prometheus/pull/15212#issuecomment-3575225179 +# /discovery/aliyun @KeyOfSpectator @prometheus/default-maintainers diff --git a/MAINTAINERS.md b/MAINTAINERS.md index 8d107b9774..c91b270bc6 100644 --- a/MAINTAINERS.md +++ b/MAINTAINERS.md @@ -1,5 +1,7 @@ # Maintainers +## Please keep this file in sync with the CODEOWNERS file! + General maintainers: * Bryan Boreham (bjboreham@gmail.com / @bboreham) * Ayoub Mrini (ayoubmrini424@gmail.com / @machine424)