mirrors/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-08-06 14:17:12 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #16234 from pr00se/remote-read-timeout-test

Browse Source 
Fix flaky TestReadClient/timeout test
This commit is contained in:
Ganesh Vernekar 2025-03-18 13:52:50 -04:00 committed by GitHub
commit 2a5ed8b8a5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
storage/remote/client_test.go
View File

@ -332,9 +332,9 @@ func TestReadClient(t *testing.T) {
},
{
name: "timeout",
httpHandler: sampledResponseHTTPHandler(t),
timeout: time.Nanosecond,
expectedErrorContains: "context deadline exceeded: request timed out after 1ns",
httpHandler: delayedResponseHTTPHandler(t, 15*time.Millisecond),
timeout: 5 * time.Millisecond,
expectedErrorContains: "context deadline exceeded: request timed out after 5ms",
},
}
@ -448,3 +448,16 @@ func sampledResponseHTTPHandler(t *testing.T) http.HandlerFunc {
require.NoError(t, err)
}
}
func delayedResponseHTTPHandler(t *testing.T, delay time.Duration) http.HandlerFunc {
return func(w http.ResponseWriter, _ *http.Request) {
time.Sleep(delay)
w.Header().Set("Content-Type", "application/x-protobuf")
b, err := proto.Marshal(&prompb.ReadResponse{})
require.NoError(t, err)
_, err = w.Write(snappy.Encode(nil, b))
require.NoError(t, err)
}
}