mirrors/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2025-08-06 14:17:12 +02:00
Code Issues Projects Releases Wiki Activity

chore(tsdb): add a few more testcases for unlock of unlocked mtx 16332 (#16848)

Browse Source 
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
This commit is contained in:
George Krajcsovits 2025-07-09 16:24:46 +02:00 committed by GitHub
parent 89f011ba13
commit 1d79f0f47e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 35 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
tsdb/head_test.go
View File

@ -6718,12 +6718,11 @@ func TestHeadAppender_AppendCT(t *testing.T) {
} }
func TestHeadAppender_AppendHistogramCTZeroSample(t *testing.T) { func TestHeadAppender_AppendHistogramCTZeroSample(t *testing.T) {
testHistogram := tsdbutil.GenerateTestHistogram(1)
type appendableSamples struct { type appendableSamples struct {
ts int64 ts int64
h *histogram.Histogram h *histogram.Histogram
fh *histogram.FloatHistogram fh *histogram.FloatHistogram
ct int64 ct int64 // 0 if no created timestamp.
} }
for _, tc := range []struct { for _, tc := range []struct {
name string name string
@ -6731,12 +6730,35 @@ func TestHeadAppender_AppendHistogramCTZeroSample(t *testing.T) {
expectedError error expectedError error
}{ }{
{ {
name: "CT lower than minValidTime initiates ErrOutOfBounds", name: "integer histogram CT lower than minValidTime initiates ErrOutOfBounds",
appendableSamples: []appendableSamples{ appendableSamples: []appendableSamples{
{ts: 100, h: testHistogram, ct: -1}, {ts: 100, h: tsdbutil.GenerateTestHistogram(1), ct: -1},
}, },
expectedError: storage.ErrOutOfBounds, expectedError: storage.ErrOutOfBounds,
}, },
{
name: "float histograms CT lower than minValidTime initiates ErrOutOfBounds",
appendableSamples: []appendableSamples{
{ts: 100, fh: tsdbutil.GenerateTestFloatHistogram(1), ct: -1},
},
expectedError: storage.ErrOutOfBounds,
},
{
name: "integer histogram CT duplicates an existing sample",
appendableSamples: []appendableSamples{
{ts: 100, h: tsdbutil.GenerateTestHistogram(1)},
{ts: 200, h: tsdbutil.GenerateTestHistogram(1), ct: 100},
},
expectedError: storage.ErrDuplicateSampleForTimestamp,
},
{
name: "float histogram CT duplicates an existing sample",
appendableSamples: []appendableSamples{
{ts: 100, fh: tsdbutil.GenerateTestFloatHistogram(1)},
{ts: 200, fh: tsdbutil.GenerateTestFloatHistogram(1), ct: 100},
},
expectedError: storage.ErrDuplicateSampleForTimestamp,
},
} { } {
t.Run(tc.name, func(t *testing.T) { t.Run(tc.name, func(t *testing.T) {
h, _ := newTestHead(t, DefaultBlockDuration, compression.None, false) h, _ := newTestHead(t, DefaultBlockDuration, compression.None, false)
@ -6745,18 +6767,21 @@ func TestHeadAppender_AppendHistogramCTZeroSample(t *testing.T) {
require.NoError(t, h.Close()) require.NoError(t, h.Close())
}() }()
a := h.Appender(context.Background())
lbls := labels.FromStrings("foo", "bar") lbls := labels.FromStrings("foo", "bar")
var ref storage.SeriesRef
for _, sample := range tc.appendableSamples { for _, sample := range tc.appendableSamples {
ref, err := a.AppendHistogramCTZeroSample(0, lbls, sample.ts, sample.ct, sample.h, sample.fh) a := h.Appender(context.Background())
var err error
if sample.ct != 0 {
ref, err = a.AppendHistogramCTZeroSample(ref, lbls, sample.ts, sample.ct, sample.h, sample.fh)
require.ErrorIs(t, err, tc.expectedError) require.ErrorIs(t, err, tc.expectedError)
_, err = a.AppendHistogram(ref, lbls, sample.ts, sample.h, sample.fh)
require.NoError(t, err)
} }
ref, err = a.AppendHistogram(ref, lbls, sample.ts, sample.h, sample.fh)
require.NoError(t, err)
require.NoError(t, a.Commit()) require.NoError(t, a.Commit())
}
}) })
} }
} }