From f9216588668f48b79627ee519e2541f2b503cb0d Mon Sep 17 00:00:00 2001 From: Dimitri Fontaine Date: Thu, 14 Sep 2017 15:30:29 +0200 Subject: [PATCH] Remove useless noise in the logs. The individual CAST decisions are visible in the CREATE TABLE statements that are logged a moment later. Also, calling `format-create-sql' on a column definition that's not finished to be casted will process default values before they get normalized, and issue WARNING to the poor user. Not helpful. Bye. --- src/sources/common/casting-rules.lisp | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/sources/common/casting-rules.lisp b/src/sources/common/casting-rules.lisp index 3a668be..e1a6646 100644 --- a/src/sources/common/casting-rules.lisp +++ b/src/sources/common/casting-rules.lisp @@ -152,12 +152,5 @@ :do (when (and (null target) using (null first-match-using)) (setf first-match-using using)) :until target - :finally (let ((coldef (make-pgsql-type source target using))) - (log-message :info "CAST ~a.~a ~a [~s, ~:[NULL~;NOT NULL~]~:[~*~;, ~a~]] TO ~a~@[ USING ~a~]" - table-name column-name ctype default - (string= "NO" nullable) - (string/= "" extra) extra - (format-create-sql coldef) - using) - (return coldef)))))) + :finally (return (make-pgsql-type source target using))))))