From d4b58a1f78a48fa5d3e2dc9bbb252228740f548d Mon Sep 17 00:00:00 2001
From: Dimitri Fontaine <dim@tapoueh.org>
Date: Sun, 21 Sep 2014 12:19:20 -0500
Subject: [PATCH] Review MySQL default options.

The default values for MySQL WITH clause options wasn't really tested
and broke on simple cases, the new set of defaults is known to work in
many cases (most?).

Other combinations of options will need some review work, and we might
need to consider preventing some of them, that's for another patch tho.
---
 src/sources/mysql.lisp | 16 ++++++++--------
 test/sakila.load       |  4 ++--
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/sources/mysql.lisp b/src/sources/mysql.lisp
index d7c8f49..2dce8d8 100644
--- a/src/sources/mysql.lisp
+++ b/src/sources/mysql.lisp
@@ -306,14 +306,14 @@
 			    state-before
 			    state-after
 			    state-indexes
-			    truncate
-			    data-only
-			    schema-only
-			    create-tables
-			    include-drop
-			    create-indexes
-			    reset-sequences
-			    foreign-keys
+			    (truncate        nil)
+			    (data-only       nil)
+			    (schema-only     nil)
+			    (create-tables   t)
+			    (include-drop    t)
+			    (create-indexes  t)
+			    (reset-sequences t)
+			    (foreign-keys    t)
 			    (identifier-case :downcase) ; or :quote
 			    only-tables
 			    including
diff --git a/test/sakila.load b/test/sakila.load
index 3b9c8aa..241d8e9 100644
--- a/test/sakila.load
+++ b/test/sakila.load
@@ -2,8 +2,8 @@ load database
      from      mysql://root@localhost/sakila
      into postgresql:///sakila
 
- WITH include drop, create tables, no truncate,
-      create indexes, reset sequences, foreign keys
+ -- WITH include drop, create tables, no truncate,
+ --      create indexes, reset sequences, foreign keys
 
   SET maintenance_work_mem to '128MB', work_mem to '12MB', search_path to 'sakila'