mirrors/pgloader
1
0
Fork 0
mirror of https://github.com/dimitri/pgloader.git synced 2026-05-05 02:46:10 +02:00
Code Issues Projects Releases Wiki Activity

Step back on (safety 0) optimization.

Browse Source 
It doesn't appear worth it at this time yet, too risky.
This commit is contained in:
Dimitri Fontaine 2018-01-24 23:26:37 +01:00
parent 6ae3bd1862
commit a603cd8882
2 changed files with 6 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/pg-copy/copy-db-write.lisp
View File

@ -55,12 +55,7 @@
over again, as we reproduced the data formating in pgloader code. The
reason we do that is to be able to lower the cost of retrying batches:
the formating has then already been done."
(declare (optimize
(speed 3)
#-ecl(safety 0) #+ecl(safety 1)
(space 0)
(debug 1)
(compilation-speed 0)))
(declare (optimize (speed 3) (space 0) (debug 1) (compilation-speed 0)))
(let* ((col-bytes (map 'vector
(lambda (col)
(if (col-null-p col) 2
@ -97,12 +92,7 @@
over again, as we reproduced the data formating in pgloader code. The
reason we do that is to be able to lower the cost of retrying batches:
the formating has then already been done."
(declare (optimize
(speed 3)
#-ecl(safety 0) #+ecl(safety 1)
(space 0)
(debug 1)
(compilation-speed 0)))
(declare (optimize (speed 3) (space 0) (debug 1) (compilation-speed 0)))
(let* ((col-bytes (map 'vector
(lambda (col)
(if (col-null-p col) 2

28
src/pg-copy/copy-format.lisp
View File

@ -41,12 +41,7 @@
(apply-transforms copy nbcols preprocessed-row (transforms copy))))))
(defun format-vector-row (nb-cols row)
(declare (optimize
(speed 3)
#-ecl(safety 0) #+ecl(safety 1)
(space 0)
(debug 1)
(compilation-speed 0)))
(declare (optimize (speed 3) (space 0) (debug 1) (compilation-speed 0)))
(let* ((lens (map 'vector
(lambda (col)
(if (col-null-p col) 2 (copy-utf-8-byte-length col)))
@ -66,12 +61,7 @@
(defun format-escaped-vector-row (nb-cols row)
"We've read data in the COPY format, so already escaped."
(declare (optimize
(speed 3)
#-ecl(safety 0) #+ecl(safety 1)
(space 0)
(debug 1)
(compilation-speed 0)))
(declare (optimize (speed 3) (space 0) (debug 1) (compilation-speed 0)))
(let* ((lens (map 'vector
(lambda (col)
(if (col-null-p col) 2 (utf-8-byte-length col)))
@ -133,12 +123,7 @@
(defun copy-utf-8-byte-length (string)
"Calculate the amount of bytes needed to encode a string."
(declare (type string string)
(optimize
(speed 3)
#-ecl(safety 0) #+ecl(safety 1)
(space 0)
(debug 1)
(compilation-speed 0)))
(optimize (speed 3) (space 0) (debug 1) (compilation-speed 0)))
(let ((length (length string))
(string (coerce string 'simple-string)))
(loop :for char :across string
@ -197,12 +182,7 @@ encoded form of that character."
"Convert a string into an array of unsigned bytes containing its
utf-8 representation."
(declare (type string string)
(optimize
(speed 3)
#-ecl(safety 0) #+ecl(safety 1)
(space 0)
(debug 1)
(compilation-speed 0)))
(optimize (speed 3) (space 0) (debug 1) (compilation-speed 0)))
(let ((string (coerce string 'simple-string)))
(declare (type (array (unsigned-byte 8)) buffer)
(type fixnum position))