mirrors/pgloader
1
0
Fork 0
mirror of https://github.com/dimitri/pgloader.git synced 2025-08-08 23:37:00 +02:00
Code Issues Projects Releases Wiki Activity

Fix user defined rules to cast ENUM to Text.

Browse Source 
The MySQL enum are casted to PostgreSQL enum types just fine, but sometimes
that's not what the user wants. In case when we have a CAST rule for an ENUM
column, recognize the fact and respect user choice.

Fixes #608.
This commit is contained in:
Dimitri Fontaine 2017-08-10 18:01:17 +02:00
parent 049a1199c2
commit 981b801ce7
1 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/sources/mysql/mysql-cast-rules.lisp
View File

@ -190,12 +190,22 @@
dtype dtype
ctype ctype
nil))) nil)))
(setf (column-type-name pgcol) ;;
(make-sqltype :name sqltype-name ;; We might have user-defined cast rules e.g. converting an ENUM
:type (intern (string-upcase dtype) ;; to text, in which case we have nothing to do here. We set a
(find-package "KEYWORD")) ;; PostgreSQL enum only when the casting rules already generated
:source-def ctype ;; the target type name.
:extra (explode-mysql-enum ctype))))) ;;
;; FIXME: why call enum-or-set-name twice, once from
;; *mysql-default-cast-rules* and once here explicitely?
;;
(when (string= sqltype-name (column-type-name pgcol))
(setf (column-type-name pgcol)
(make-sqltype :name sqltype-name
:type (intern (string-upcase dtype)
(find-package "KEYWORD"))
:source-def ctype
:extra (explode-mysql-enum ctype))))))
;; extra triggers ;; extra triggers
;; ;;