mirrors/pgloader
1
0
Fork 0
mirror of https://github.com/dimitri/pgloader.git synced 2026-05-04 10:31:02 +02:00
Code Issues Projects Releases Wiki Activity

Ensure unquoted file names for logs and data.

Browse Source 
The previous code could create files having as an example the following,
unhelpful name: \"errors\"/\"err\".\"errors\".log.

Fix #808.
This commit is contained in:
Dimitri Fontaine 2018-06-22 22:59:52 +02:00
parent ee44f19815
commit 8930734bea
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/utils/state.lisp
View File

@ -69,7 +69,9 @@
(defmethod pgtable-initialize-reject-files ((table pgtable) dbname)
"Prepare TABLE for being able to deal with rejected rows (log them)."
(let* ((table-name (format-table-name (pgtable-name table)))
(let* ((dbname (pgloader.quoting:ensure-unquoted dbname))
(table-name (pgloader.quoting:ensure-unquoted
(table-name (pgtable-name table))))
(data-pathname (reject-data-file table-name dbname))
(logs-pathname (reject-log-file table-name dbname)))
;; we also use that facility for things that are not tables
@ -83,13 +85,17 @@
(with-open-file (data data-pathname
:direction :output
:if-exists :rename
:if-does-not-exist nil)))
:if-does-not-exist nil)
;; avoid a warning about DATA being some unused lexical variable
(pathname data)))
(when (probe-file logs-pathname)
(with-open-file (logs logs-pathname
:direction :output
:if-exists :rename
:if-does-not-exist nil)))
:if-does-not-exist nil)
;; avoid a warning about LOGS being some unused lexical variable
(pathname logs)))
;; set the properties to the right pathnames
(setf (pgtable-reject-data table) data-pathname