From 267a1cc755d0579be3db6483fe21b24e89e8dd96 Mon Sep 17 00:00:00 2001 From: Dimitri Fontaine Date: Sat, 3 May 2014 15:55:02 +0200 Subject: [PATCH] The Useless Use Of Loop did strike. --- src/sources/csv.lisp | 3 +-- src/sources/fixed.lisp | 3 +-- src/sources/sources.lisp | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/sources/csv.lisp b/src/sources/csv.lisp index 6b823f3..a54dc2a 100644 --- a/src/sources/csv.lisp +++ b/src/sources/csv.lisp @@ -46,8 +46,7 @@ (pgloader.pgsql:list-columns (slot-value csv 'target-db) (slot-value csv 'target))))) (unless transforms - (setf (slot-value csv 'transforms) - (loop for c in columns collect nil))))) + (setf (slot-value csv 'transforms) (make-list (length columns)))))) ;;; ;;; Read a file format in CSV format, and call given function on each line. diff --git a/src/sources/fixed.lisp b/src/sources/fixed.lisp index 204d90a..95f4763 100644 --- a/src/sources/fixed.lisp +++ b/src/sources/fixed.lisp @@ -28,8 +28,7 @@ (pgloader.pgsql:list-columns (slot-value fixed 'target-db) (slot-value fixed 'target))))) (unless transforms - (setf (slot-value fixed 'transforms) - (loop :repeat (length columns) :collect nil))))) + (setf (slot-value fixed 'transforms) (make-list (length columns)))))) (declaim (inline parse-row)) diff --git a/src/sources/sources.lisp b/src/sources/sources.lisp index 9c39fd3..4342849 100644 --- a/src/sources/sources.lisp +++ b/src/sources/sources.lisp @@ -32,7 +32,7 @@ (slot-value source 'transforms)))) (unless transforms (setf (slot-value source 'transforms) - (loop for c in (slot-value source 'columns) collect nil)))))) + (make-list (length (slot-value source 'columns)))))))) (defgeneric map-rows (source &key process-row-fn) (:documentation