3637 Commits

Author SHA1 Message Date
Thomas Vachuska
529db0a9b5 Preparing GUI resources for dynamic injection of contributed content. Ready to go, but for now disabled in web.xml.
Change-Id: I0751077702835e7572b20037ba6ddc1950be6037
2015-02-23 16:42:14 -08:00
Ray Milkey
43a2822c10 Refactor tests to use shared mock implementations
Change-Id: Iba4e44b7bb88f8a31add9475a9155f85375ae61a
2015-02-23 22:44:24 +00:00
Madan Jampani
6b5b717d80 Gave threadpools more appropriate names.
Change-Id: Ib7ce71a3028363b1465fbd5775f84e2befaf80c1
2015-02-23 22:40:56 +00:00
Ray Milkey
5a7787a62c Unit test for intent accumulator
Change-Id: Id9f8c918bdddc7fe24e4eb283676fd94275e58cf
2015-02-23 13:58:21 -08:00
Madan Jampani
2af244a977 Never process incoming messages on the netty event loop thread pool.
Currently in a lot of places we are deserializing incoming messages on this threadpool and that could be significantly limiting throughput.

Change-Id: I83eb7e91004cea4addb28bc28f27e50de10028fe
2015-02-23 20:37:25 +00:00
Thomas Vachuska
a0509897a9 Preparing for dynamic GUI extensibility.
Change-Id: Ic25143bb9ad8919d7c9e70d932dde528a9227e6a
2015-02-23 11:31:37 -08:00
Thomas Vachuska
4c6c377110 Fixed javadocs.
Change-Id: I74064c7e6dce702c769272cfa5dba99a61ea5abc
2015-02-23 08:50:49 -08:00
Thomas Vachuska
a132e3acd3 Made intent perf app multi-threaded; doesn't seem to help.
Made Jono's changes to ECM per Madan's suggesion.
Added cell beast.
Re-enabled anti-entropy.
Added ability to push bits through test proxy for faster upload.

Change-Id: I1455d6d443a697d7a3973c88cb81bfdac0e1dd7f
2015-02-22 20:31:04 +00:00
Madan Jampani
2e5f87b548 Limit the amont of work that happens on netty event loop threads.
Currently we are kryo serializing/deserializing the message envelope which can potentially limit throughput.

Change-Id: I0ae9dab53bbb765b7618ceaefda1edf4f77b0b59
2015-02-22 10:37:15 -08:00
Thomas Vachuska
d32bfdcaa9 Fixing javadocs.
Change-Id: I49faf425e0f9aa53547caf42f1d4025fb8d9dba6
2015-02-21 16:39:25 -08:00
Thomas Vachuska
fe8c98ad0b Adding support for user interface extensions.
Change-Id: I1e41d16efc11be31ad4c2fb0c09e86e3dfd26706
2015-02-21 16:17:35 -08:00
Thomas Vachuska
6f94deddef Converted all executors that previously used namedThreads to use groupedThreads instead.
Change-Id: I048709308270de5b7552bc4e8395b0f7201d5949
2015-02-21 14:02:38 -08:00
Sho SHIMIZU
6c28f8371c ONOS-1066: Move IntentCompilers to the dedicated package
Change-Id: I3e588cab0559093d389c9d44d2c7df536cabe953
2015-02-21 18:05:12 +00:00
Sho SHIMIZU
b70521702d Remove dependency on PointToPointIntentCompiler
Create an installable intent, not relying on an IntentCompiler.
This change enables IntentCompilers to be moved to a dedicated package.

Reference: ONOS-1066

Change-Id: Ie5bca33720232afaa4d6642d4f9fda933f6d00e3
2015-02-21 18:01:51 +00:00
Sho SHIMIZU
0e738806ff Move unit tests to PointToPointIntentCompilerTest
The unit tests only depend on PointToPointIntentCompiler and it would be
obstacles when IntentCompiler subclasses are moved to a dedicated package

Change-Id: Ifbfe5ef2a4bae014d2b6cae599fe8860a54e01ca
Reference: ONOS-1066
2015-02-21 17:58:07 +00:00
Sho SHIMIZU
575a364517 Remove obsolete todo comment
Change-Id: I9ebb573e8c259abd71f2cc90bae20764c10cf620
2015-02-21 09:47:50 -08:00
Sho SHIMIZU
b0a47d41c8 ONOS-1048 - Define interfaces instead of using IntentManager
- Define IntentProcessor interface containing methods to process an intent
- Pull out IntentCompiler related tasks to CompilerRegistry
- Pull out IntentInstaller related tasks to InstallerRegistry
- Create an IntentProcessor subclass as inner class in IntentManager

Change-Id: Ia3e8d574a1053e7ddc9b961873ef758c9e0b1b26
2015-02-21 09:33:13 -08:00
Jonathan Hart
054da97e83 Implement command to view Raft partitions
Change-Id: I9d3cea49877d69c2d7935dadbbad2770349e793a
2015-02-21 17:00:39 +00:00
Pavlin Radoslavov
b9e50dff43 Fixed a bug when parsing configuration properties for ReactiveForwarding
by catching the appropriate exception.

Apparently, if a property is configured/enabled in file Foo.cfg, e.g.:
  flowTimeout = 10
then the corresponding object/value in the Dictionary returned by
ComponentContext.getProperties()
has class type String.

However, if the property is commented-out, e.g.:

then the Dictionary still contains an entry for "flowTimeout", but
its class type is Integer.

Also, updated similar code elsewhere that was catching the generic
Exception with catching more specific exception(s).

Change-Id: I33ec348eb9efe3188e22cfc8cee2bb704948726d
2015-02-21 15:57:17 +00:00
Brian O'Connor
71503cd103 PartitionManager: reduce number of partitions to improve stability
Change-Id: I972583c0ba397017b6bfa40f5ddf6f13253c6d45
2015-02-20 22:15:55 -08:00
Brian O'Connor
b289422189 EventuallyConsistentMapImpl: pushing serialization and sending to caller thread
This has the effect of limiting the caller so that it can't overrun the single thread that previously did the job.

If you let this back up, it will use all of your memory. :(

Change-Id: I0a3b93cfa7004e0430d228a68c60e2b7ba966d4e
2015-02-20 22:15:55 -08:00
Brian O'Connor
64a0369dfb IntentInstaller: changing from Set to Collection to improve perf
Change-Id: Ia7f0f7d893645c7528ac9f51acff133f6d82383d
2015-02-20 22:15:46 -08:00
Sho SHIMIZU
1ee563a503 Remove unnecessary non-null check assertions
Private methods need to ensure to return a non-null value

Change-Id: Ie1fffc52282660c4d32c8fbedd9f47049b2e74ae
2015-02-21 05:53:30 +00:00
Ray Milkey
8dc820868c Fix some compiler warnings about unchecked types
Change-Id: Ib360aa05fd0e194a65bbc0b624447e4bdb4ced93
2015-02-21 05:52:36 +00:00
Thomas Vachuska
0249b5377d Enhancing intent-perf logging
Fixing defect in distributed app mgmt
Reducing DB manager heartbeat aggressiveness

Change-Id: I9ba948a2b2166625c56566502143c0d27f9a2c44
2015-02-21 01:32:52 +00:00
Pavlin Radoslavov
ab8553a52a Fix a bug: there are two ECN bits in the IPv4 header, not three.
Change-Id: Ibdfce817f2a506644e0f9cd16f46cf6ab1f75eb7
2015-02-20 14:13:50 -08:00
Ray Milkey
144eec5207 Fix Javadoc warnings
Change-Id: I366f2b9f3c11645a3392e0689619bfbad7a9eedd
2015-02-20 20:54:26 +00:00
Yuta HIGUCHI
6a47964aad Instruction related fixes
- Removed redundant equality check. (ONOS-975)
- Enforced using Instruction Factory methods.
- cosmetic fixes.

Change-Id: I178b55f8568c1a9132f0aa88465b8b34dc2b2df2
2015-02-20 19:12:19 +00:00
Brian O'Connor
8fc739af47 Disabling anti-entropy messages to stabilize performance of intent store
Change-Id: Ic66c6d710e6bc4bc82496c38a5b9955e58f72e73
2015-02-19 22:32:15 -08:00
Brian O'Connor
2952e3b7b6 updates to EventuallyConsistenMapImpl to improve parallelism
Change-Id: I7bf29c02380f630e592d980d0795efc6ac13167a
2015-02-19 21:51:27 -08:00
Brian O'Connor
be28a87c0e Chaning IntentStore.isMaster to take a key
Change-Id: I2d04a6aa7418e06137b0688bcb4e3af060a02b63
2015-02-19 21:50:20 -08:00
Madan Jampani
7e6cfe305e ECMap: synchronization free removeInternal
Change-Id: I89b88d11b830de5ceb97fdc3fb91ae51bc1bb1cb
2015-02-20 02:20:36 +00:00
Jonathan Hart
3469e60239 Move sending advertisement outside synchronized block
Change-Id: I1709fecbec5e6f5ac245b535c14a5c0b2aea2820
2015-02-19 17:01:40 -08:00
Ray Milkey
71ade56cbf Refactor Intent subsystem to eliminate using FlowRuleBatchOperation
Change-Id: Iee76dac5fa9935713ffc370b34ac47d9286ff351
2015-02-20 00:59:03 +00:00
Madan Jampani
97cf7c4138 Using ClusterCommunicationService instead of ITopic for notifying cluster members of leadership events.
Change-Id: I164f30da436f3e4f65c4e938c25bb2aa2faa16c3
2015-02-20 00:56:07 +00:00
Ray Milkey
cc53abd74e Favor adapter classes over service interfaces in unit tests
In unit tests that are mocking an entire interface, instead
extend the Adapter class so the unused method overrides
are no longer needed.

Change-Id: I6e332cc5cb59410f163deea223fbc94e73d83917
2015-02-20 00:35:32 +00:00
Brian O'Connor
9b7a32d1e3 ClusterCommunicationManager: only serialize once for broadcast
Change-Id: Ife78af3c758c87eeb8a79cdbf51b5307b8b1ca88
2015-02-20 00:12:17 +00:00
Madan Jampani
337bb44579 ECMap: Moving message serialization to the background
Change-Id: I0de398c6ce77bfb0729db03ab2ec4ea7f55a8284
2015-02-19 22:49:08 +00:00
Madan Jampani
b28e4ad8de Fix EventuallyConsistentMapImpl unit tests.
Change-Id: I5d114bac40c16d0f67330ba2b4b922a4301666b2
2015-02-19 12:33:03 -08:00
Madan Jampani
04f46155be Disabling all tests in EventuallyConsistentMapImplTest temporarily.
Change-Id: I22f124b1ab5ae889396d9f29ac8e49e1c3349dca
2015-02-19 20:26:34 +00:00
Brian O'Connor
4e6c17d2b9 Fixing hash for Intent keys
Change-Id: Ie7807d95b3e58f2e79c6127251ef355b77ba05ff
2015-02-19 12:00:26 -08:00
Madan Jampani
2872628e44 EventuallyConsistentMap: move broadcasting to a separate backgroup thread.
Change-Id: If4499cef78e5eb8b54ec2e3336e95030ec37f7e1
2015-02-19 11:54:46 -08:00
Thomas Vachuska
718d399045 Fixing javadoc configuration and adding some package documentation.
Change-Id: Ibeb58b954b1d5ed1939a70afda3f5523807cee23
2015-02-19 19:08:12 +00:00
Thomas Vachuska
ecb63c5a01 Updated accumulator documentation and refactored names to remove the event heritage.
Change-Id: I2238ab1215281702e670a406fb901ba8a4ef85ce
2015-02-19 18:26:00 +00:00
Pavlin Radoslavov
a2626ef982 Implemented a mechanism to easily add and access Neighbor Discovery protocol
packet options.

Fixes ONOS-1011

Change-Id: I94daa3f3c1297fb9a7b44901927738a29aff030a
2015-02-19 17:17:56 +00:00
Brian O'Connor
4b2ba5f8bb EventuallyConsistentMap: changing to groupedThreads
Change-Id: Ie57afcc1013fa33172bf51f73980171d8ea3df29
2015-02-18 21:04:55 -08:00
Brian O'Connor
1fdfacd1f1 Fixing partition mapping
partition choice was sometimes negative

Change-Id: I97354360bebe6f8981f926f15661005adf7482c0
2015-02-18 21:04:55 -08:00
Brian O'Connor
fd079918d8 IdBlockStore: changing default size
Change-Id: I3d3bf42cbef4590c345cd6b1b4f871da8d617568
2015-02-18 21:04:54 -08:00
Brian O'Connor
b715f62e6c PathIntentInstaller: avoiding calls to Resource Store when unnecessary
Change-Id: I846ca543f922063ddc67a06353f43c590bd57d96
2015-02-18 21:04:54 -08:00
Brian O'Connor
bdc7f00e92 Changing IntentManager to use groupedThreads
Change-Id: I83854c2d6d6fcc8b10a0f50e625aa4be5ff255bb
2015-02-18 21:04:54 -08:00