Ray Milkey
019fba404e
Refactor exception handling in the OSPF protocol
...
- removed unnecessary throws of Exception from methods
- converted throws of generic Exception to specific OspfParseException
Change-Id: I9d07167d92f221a234e9eba4c6082deb165afc0b
2018-02-01 04:10:13 +00:00
Ray Milkey
fe0e085ed2
SONAR suggestions - boolean expressions that are known to be 'true' or 'false'
...
Change-Id: I4e089cb606ecf43444b4d567ad63d622f37506ce
2018-01-19 08:59:46 -08:00
Ray Milkey
9c9cde4d4d
SONAR Suggestion - protected members in final classes are pointless
...
Change-Id: Ie34d86aecf181e73867a14864d75e0db8a8f48f3
2018-01-17 00:18:50 +00:00
Ray Milkey
b68bbbc5ac
Sonar suggestion - use a secure random number generator
...
Change-Id: I28075845555bcbc384a49e07353b3192c413b8f7
2017-12-19 17:58:54 +00:00
Brian O'Connor
a09fe5b0b7
Updating Copyright line to Open Networking Foundation
...
Change-Id: Icba96d7f39a065b53f34a6aeb71afd1f7d51f774
2017-08-03 21:12:30 -07:00
Ray Milkey
e4afdb5f17
Fix Sonar errors: public data members in classes
...
Change-Id: I7aca37d5553436167ac6e7b2206392f88bddc118
2017-04-06 00:13:24 +00:00
kdarapu
f0da43dbdd
Addressed change request and rectified for hashcode also
# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
# On branch review/kishore_darapu/onos698
# Changes to be committed:
# modified: protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/types/OpaqueLsa10.java
# modified: protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/types/OpaqueLsa11.java
# modified: protocols/ospf/protocol/src/main/java/org/onosproject/ospf/protocol/lsa/types/OpaqueLsa9.java
#
...
Change-Id: I41021f62dc8c662f3c61c8ae1358f32e409143e3
2017-01-04 11:11:21 +00:00
kdarapu
e4da4a07b4
Byte array comparison always return true for Objects.equal
...
Change-Id: Ib3fa05b7ba8c00cfab347dfc9d7ddc5f79798b37
2017-01-04 11:04:38 +00:00
Ray Milkey
0bb1e10a3f
Javadoc fixes
...
- fix missing Javadoc @param and @throw annotations
- enable checkstyle checks for method javadocs on non-private methods
Change-Id: I9a370419a699bab3225d85f2f641927600b9f11c
2016-11-11 01:09:15 +00:00
Brian O'Connor
0a4e6742b8
Copyright update
...
Change-Id: I534d938da3820f6fb814aed3bb4a0855fa41ddd5
2016-09-16 06:48:34 +00:00
sunishvk
f7c5655c12
OSPF protocol manual merge from 1.6, due to cherry pick merge conflict
...
Change-Id: I93653e745468722ce95533537a79e897b4292f5d
2016-07-26 17:26:10 +00:00
Shashikanth VH
1560d40b0e
Ospf opaque LSA bug fix.
...
Change-Id: I9b2674195a754a0774013f9adf717764ea18c9a6
2016-04-27 15:19:15 +00:00
Brian O'Connor
5ab426f9ff
Updating copyrights
...
New format: 'Copyright .year-present Open Networking Laboratory'
Change-Id: I1a9e58b355b775e75245ad875a2d7a4df3f03098
2016-04-09 01:20:21 -07:00
Jonathan Hart
953bd00808
Remove usage of InetAddress.getLocalHost() in unit tests.
...
This does a DNS lookup which causes the test to fail if the DNS lookup fails.
Change-Id: I9fb3898e7b846e68915d90368849734ad61922f4
2016-03-30 13:31:00 -07:00
sunish vk
aa48da8d16
Fixed pom.xml issues and build issues. Corrected checkstyle issues
...
Change-Id: I90744f53e40f417ffe7ae62ffe138eea7a489bc0
2016-03-03 00:50:38 +00:00
Dhruv Dhody
43f3ce62b9
ONOS-2739 - OSPF Basic Packet Structures , which includes encoding and decoding
...
Change-Id: Ifaaa4d3640c6a4fec4931db54a1f03100cc9d9e6
2016-02-19 20:19:19 +00:00
Kiran Ramachandra
959353a5f4
ONOS-2739 - OSPF Basic Packet Structures , which includes encoding and decoding
...
Change-Id: Ic37fcf98dfb6c7a15a124b495aee8517a8df23c9
2016-02-19 19:57:45 +00:00
Mohamed Rahil
a3b9e99934
ONOS-2739 - OSPF Basic Packet Structures , which includes encoding and decoding
...
Change-Id: I3f09176ad4ccc330b8989f13b12f74dc86f53ae4
2016-02-19 19:43:43 +00:00
Mani
cdb2641b59
ONOS-2739 - OSPF Basic Packet Structures , which includes encoding and decoding
...
Change-Id: I33b48593ec38d28bdff215ce3a608a6d085a9077
2016-02-19 19:23:42 +00:00
Chidambar babu
86b3b1aa2e
ONOS-2739 - OSPF Basic Packet Structures , which includes encoding and decoding
...
Change-Id: I4bf4b7eb26a0e2b5006b41b24d67c7f21450b11b
2016-02-19 18:25:45 +00:00
