Also, the parent DefaultRestSBDevice had a faulty testUrl toString.
Change-Id: I15d9432402aa00d453c3b09cbf5e5c05e82549eb
Signed-off-by: Georgios Katsikas <katsikas.gp@gmail.com>
This patch enables per-rule byte and packet counters
on server NICs. A bug fix is also applied related to
IP protocol matches.
Change-Id: I96ba16d84ecffbde181fb58bf33c43aabbd98612
Signed-off-by: Georgios Katsikas <katsikas.gp@gmail.com>
The server device driver's flow installer allows to
devise NIC flow rules on entire src/dst IP subnets.
Change-Id: Ia7683c7bc131788ecf3465b08588d0c9bf81b6e6
Signed-off-by: Georgios Katsikas <katsikas.gp@gmail.com>
This patch introduces a graphical user interface
that visualizes the CPU utilization of server devices
using bar charts.
Code optimizations and a bug fix is applied after first
code review.
Additional bar plots are implemented, visualizing
average throughput and latency per core,
when these statistics are present.
Added external library in Bazel's BUILD file.
Fixed scaling and font issues in the UIs after getting
feedback from ONOS reviewers.
Change-Id: I92972ef871e6a91dd70cdffd8cd650f498ffca26
Signed-off-by: Georgios Katsikas <katsikas.gp@gmail.com>
Rather than sending one REST delete command per rule
the server driver batches multiple rule IDs into a
single delete command.
Also performed some memory optimizations and refactoring.
Smarter batching to avoid exceeding the memory constraints of
webservers.
Lowered the rule deletion batch size due to the message:
"Your HTTP header was too big for the memory constraints of
this webserver".
Batch size for rule deletion has become a configurable
property.
Change-Id: I3ff7a2a85bfa0c100d25da1ced3c83fad61edaf7
Signed-off-by: Georgios Katsikas <katsikas.gp@gmail.com>
This patch also performs some refactoring to make the
JSON parameters exchanged between the driver and the device
homogeneous (i.e., following the [a-z][A-Z]* pattern).
Code reviewed and minor refactoring.
Avoid exception when timing statistics are not present.
Handle device re-connections.
Server also reports a hardware queue index per core.
Addressed code reviewer's comments.
Change-Id: I6c9d0bbd5884267ee2fdb69bf50809694994c56d
Signed-off-by: Georgios Katsikas <katsikas.gp@gmail.com>
This patch complements Change 19229 to fix the issues
caused by multi-server deployments. Previously, only one
server device could be detected by ONOS due to the proxy field.
Also, when that device went offline, the driver did not notify the
RestController.
With this patch, the server device driver cooperates with the
RestController to provide a consistent server activity state for
multiple servers.
Addressed comments made by ONOS reviewers
Change-Id: Ifc0c556a2a5322fd2ee8b02065a2a507cf6b92fc
Signed-off-by: Georgios Katsikas <katsikas.gp@gmail.com>
This patch fixes two bugs in the flow rule programmable
module of the server device driver. The first bug was related
to the translation of IP addresses and masks into NIC flow
rule commands. The second bug was related to the command used
to explicitly remove a flow rule.
The first bug was detected after testing the server device driver
with large ACL configurations from Internet Service Providers.
Code review fixes applied.
Change-Id: I8f509e675e19aa05ca058b20cc5e53690c902693
Signed-off-by: Georgios Katsikas <katsikas.gp@gmail.com>
This patch fixes some weak assumptions regarding the way the
server device driver maps NIC names and port numbers.
Also, some necessary refactoring and stdout message fixes are
committed.
Addressed comments from ONOS developers
Change-Id: I6730d971ddf8d4fe97c2d3bef75f1432e7a4592e
Signed-off-by: Georgios Katsikas <katsikas.gp@gmail.com>
This patch extends the server device driver with the
ability to manage FlowRule objects on the network interface
cards (NICs) of commodity servers.
With a minimal modification in an existing ONOS class (i.e.,
DefaultFlowRule.java), the server device driver re-uses the
FlowRule and FlowEntry concepts to implement a sub-class
translator that converts FlowRule objects into NicFlowRule
objects.
Currently this new feature supports a handful of possible
NIC rule actions but it can be easily extended in the future.
Addressed comment made by ONOS reviewers and fixed two bugs.
One bug was related to rule installation (ability to send
an array of rules at the same time), while the other bug was
related to the hash code of a NicFlowRule.
Refactoring of this driver according to ONOS reviewers's
comments.
Change-Id: Ie76947df120d6e0df86acf9e5917e237653a8cea
Signed-off-by: Georgios Katsikas <katsikas.gp@gmail.com>
The fixes are related to the return values when
a device is not present. After this commit, empty
lists are returned instead of NULL to prevent exceptions.
Change-Id: I6ad03126a49dc6fe0f7afd55a860a9dba41d1cb0
Signed-off-by: Georgios Katsikas <katsikas.gp@gmail.com>
This device type is now advertized by the server
device driver. Also, the ONOS UI maps this new device
type to a glyph.
Change-Id: Ib4147676474b43202bbdff595a0fa0520b70fe91
Signed-off-by: Georgios Katsikas <katsikas.gp@gmail.com>
This method was not properly implemented but now
the driver can remove a list of designated controllers.
Refactoring was done according to received comments
Change-Id: I3f4c58d47da52305de491227ab44bd5add14041d
Signed-off-by: Georgios Katsikas <katsikas.gp@gmail.com>
This patch groups together Network Interface Card (NIC)-related
functionality in devices/nic folder because a subsequent patch
will further extend the functionality of NIC devices with the
ability to implement programmable FlowRules
(i.e, by implementing FlowRuleProgrammable).
Also, some common functionality is moved to BasicServerDriver,
thus removing redundancy from ServerDevicesDiscovery.
Removed forgotten dead code
Change-Id: Ic9088ad5a577608a628d5f62fbc1d08326801f3b
Signed-off-by: Georgios Katsikas <katsikas.gp@gmail.com>
Monitoring enhanced with timing stats
Copy constructors for Rx filter values
Driver is updated to provide port statistics to the REST SB controller
Drastic changes to make the driver ONOS compliant. NIC statistics have become 100% compliant with PortStatistics
CPU statistics also compatible with the ONOS approach
Separated timing statistics
Style fix
NIC is included
Proper representation of a CPU. Also some refactoring
Removed unused import and added important comment
CPU vendor has become a class and the servers are now reporting more detailed CPU info
Fixed port statistics' counters for servers
Various fixes that lead to more stable behavior
Additional checks to avoid null pointer exception
Fixed potential casting issues
Updated pom with affiliation information
Updated pom with URL
Bumped rivers to version 1.12
Updated BUCK for version 1.12
NIC speed has become long and NICs are retrieved in a sorted fashion
Fixed warning
Timing statistics contain autoscale measurements
Fixed CPU vendor ID for Intel
Bumped Metron's drivers to version 1.13. Fixed origin and URL in pom.xml
Updated RestServerSBDevice to comply with the extended ONOS RestSBDevice
Total refactoring of the driver to become more generic (NFV -> Server).
Also properly separated the statistics API from implementation.
Refactored server driver and bug fix that occured when port statistics
were called before a device is properly discovered.
Statistics API and implementation are grouped again.
Removed unnecessary stuff from pom and BUCK files
Fixed checkstyle warning
Added short readme to pom.xml
New ControllerConfig behavior added
This patch adds an new ControllerConfig behavior to the server
driver, allowing external applications to get, set, and remove
a server's controller configuration.
Common functions and variables are also shared between the
two basic modules of the driver.
Fixed checkstyle warnings
Refactored controller configuration module
Consistent values returned by the methods of the driver
Unit tests for ServerControllerConfig behavior
Fixed preconditions for NULL and arguments
Improved documentation
Updated pom and BUCK
Addressed comments about sharing some more methods
Refactored the Common.java to become a base class
that extends AbstractHandlerBehaviour and can share
a unique instance of the RestSBController with child
classes. Also, after the removal of some deprecated
methods of the HTTP SB controller, I had to perform
some compatibility changes in the respective methods
of this driver.
The only problem is that my tests are now broken(??)
and I had to remove their code for now until I fix
the issues.
Expose some members and methods of BasicDriver
Renamed BasicDriver to BasicServerDriver
Change-Id: I0126adcb714f7e32695d546cf40a9de342722083
Signed-off-by: Georgios Katsikas <katsikas.gp@gmail.com>
