The previous implementation was a huge switch statement. These
changes attempt to use polymorphism to avoid all of the branching
inherent in a switch.
Change-Id: If997f028346de02b883356bcde07f62674e319be
- Fixed instanceOf with wrong type (ONOS-974)
- Aligned #toString() format to be the same as other instructions
Change-Id: I526c2ef8d92660e0b821a10f0cf87ee72a84cdf3
- An object is returned that has the current column ID and which icon/sorting needs to take place when sent to the server
- clicking on each header will display to the debug console which way it will be sorted
Change-Id: I686d417a5b9b0e5c9b591380b8a6166c70c3c401
REST API tests were defining a set up method called setUp(), which had
the unwanted side effect of hinding the parent class' implementation.
Made the set up and tear down methods for the tests have unique names so
both will be executed.
Also fixed some javadocs while editing the files.
Change-Id: Ifaa75fe650d5909b066769e5e12cb5c834267a20
- Eclipse complains isA() is ambiguous.
'isA' method does exist in both EasyMock and hamcrest Matcher.
Change-Id: I6b98dbe1b4f1f0ce4fcbc2dcaded9b666fc19b33
Work toward ONOS-509
The following match conditions are added/implemented:
- IN_PHY_PORT
- IP_DSCP
- IP_ECN
- METADATA
Change-Id: I6f529ee90b2b9e0d5046f83c034e8be3faf86d8b
The contract for JSON codecs requires that they have no
local context. Make them all immutable, and test that they
stay immutable.
Change-Id: Ia3930b844ede231940da05699f5f08605f946e0c
DefaultOpenFlowPacketContext.inport() -> pktinInPort()
There is a public method DefaultOpenFlowPacketContext.inPort()
and having another method called inport() is confusing.
Change-Id: I6b703eb640edab24fb0112bd2019395eeb3d8421
Previously, when checking the winning BGP routes, we expect-and-wait until
the size of the table with the winning routes has certain size, and
then we verify whether it contains a particular value.
This is error-prone and time-sensitive. For example, if we are testing
whether a particular route from one BGP peer is replaced with the
same route from another BGP peer, the test might fail because the
table size doesn't change.
Modified the unit test to expect-and-wait until the expected route
is received.
Also, fixed some of the paragraph tags in some of the Javadocs.
Change-Id: Ia96dc7c412e78bbc9279dd935dec6919096adeb3
Fix for following error:
[ERROR] Project requires an incorrect minimum version of Maven.
[ERROR] Either change plugin versions to those compatible with 3.0.0
[ERROR] or update the pom.xml to contain
[ERROR] <prerequisites>
[ERROR] <maven>3.0.1</maven>
[ERROR] </prerequisites>
Change-Id: I0ba1530a97ab37ccfa1655e74ebbc11ebcf2a18f
- Changed color of check and xmark icons for dark and light themes.
- Only appends glyphs that don't have a "-" as the name.
- Wrote unit tests for new icons.
Change-Id: Ia21fa33673e3adcfd8717f899d226b0d24dfcc51
Change-Id: I1125fbc23f1e58bcb8aaf5f67c02da610fa7ef25
ONOS-885: Group store interface definition and in-memory store implementation
Change-Id: Id3794bed63785e10ed86c0b5d90bf875d127224c
- Added configuration parameters for order of instances.
- got rid of 'flicker' flag since it's redundant.
Reference: ONOS-890
Change-Id: I0217e17f2a55d85e0a1fc8f2b3ea8cb54cb87517
