11 Commits

Author SHA1 Message Date
Georgios Katsikas
70671b3253 Server driver implements FlowRuleProgrammable
This patch extends the server device driver with the
ability to manage FlowRule objects on the network interface
cards (NICs) of commodity servers.
With a minimal modification in an existing ONOS class (i.e.,
DefaultFlowRule.java), the server device driver re-uses the
FlowRule and FlowEntry concepts to implement a sub-class
translator that converts FlowRule objects into NicFlowRule
objects.
Currently this new feature supports a handful of possible
NIC rule actions but it can be easily extended in the future.

Addressed comment made by ONOS reviewers and fixed two bugs.
One bug was related to rule installation (ability to send
an array of rules at the same time), while the other bug was
related to the hash code of a NicFlowRule.

Refactoring of this driver according to ONOS reviewers's
comments.

Change-Id: Ie76947df120d6e0df86acf9e5917e237653a8cea
Signed-off-by: Georgios Katsikas <katsikas.gp@gmail.com>
2018-07-09 08:13:45 +00:00
Georgios Katsikas
d472a32e08 Refactoring and fixes in server driver
The fixes are related to the return values when
a device is not present. After this commit, empty
lists are returned instead of NULL to prevent exceptions.

Change-Id: I6ad03126a49dc6fe0f7afd55a860a9dba41d1cb0
Signed-off-by: Georgios Katsikas <katsikas.gp@gmail.com>
2018-07-09 08:10:55 +00:00
Georgios Katsikas
40ecef3be0 New Device type for commodity servers
This device type is now advertized by the server
device driver. Also, the ONOS UI maps this new device
type to a glyph.

Change-Id: Ib4147676474b43202bbdff595a0fa0520b70fe91
Signed-off-by: Georgios Katsikas <katsikas.gp@gmail.com>
2018-07-06 17:38:42 +00:00
Georgios Katsikas
9a5ed3abee RemoveControllers for server device driver
This method was not properly implemented but now
the driver can remove a list of designated controllers.

Refactoring was done according to received comments

Change-Id: I3f4c58d47da52305de491227ab44bd5add14041d
Signed-off-by: Georgios Katsikas <katsikas.gp@gmail.com>
2018-07-04 16:15:38 +00:00
Georgios Katsikas
2ebd8a0de2 Structural changes in Server Device Driver
This patch groups together Network Interface Card (NIC)-related
functionality in devices/nic folder because a subsequent patch
will further extend the functionality of NIC devices with the
ability to implement programmable FlowRules
(i.e, by implementing FlowRuleProgrammable).

Also, some common functionality is moved to BasicServerDriver,
thus removing redundancy from ServerDevicesDiscovery.

Removed forgotten dead code

Change-Id: Ic9088ad5a577608a628d5f62fbc1d08326801f3b
Signed-off-by: Georgios Katsikas <katsikas.gp@gmail.com>
2018-06-28 09:26:26 +00:00
Ray Milkey
5c9e2838e4 Build drivers with bazel
Change-Id: I033ac32b3ef8119fc65e046c821ff17f12709261
2018-06-27 23:34:20 +00:00
Ray Milkey
bca9049101 Starting snapshot 1.14.0-SNAPSHOT
Change-Id: I97bab4e31d2b701f015289eae29d0c58a4937685
2018-04-13 12:47:31 -07:00
Yuta HIGUCHI
53e4796d55 Deprecate potentially error prone constructor methods
Change-Id: I82d95c27dc7c4b1a6dcf5cc48a1c7583b5e30e2c
2018-03-05 20:43:39 +00:00
Ray Milkey
067c44bcba Fix SONAR problems
Change-Id: Id79866971b7b2c894babe45a69f22f44cf3584db
2018-02-26 22:04:06 +00:00
Ray Milkey
c6c9b17b7b Fix some small SONAR issues
Change-Id: I5accbeb3895e5a5e679146c9eb688232fbf0a6b6
2018-02-26 09:36:31 -08:00
Georgios Katsikas
8360098862 New SB driver for commodity servers
Monitoring enhanced with timing stats

Copy constructors for Rx filter values

Driver is updated to provide port statistics to the REST SB controller

Drastic changes to make the driver ONOS compliant. NIC statistics have become 100% compliant with PortStatistics

CPU statistics also compatible with the ONOS approach

Separated timing statistics

Style fix

NIC is included

Proper representation of a CPU. Also some refactoring

Removed unused import and added important comment

CPU vendor has become a class and the servers are now reporting more detailed CPU info

Fixed port statistics' counters for servers

Various fixes that lead to more stable behavior

Additional checks to avoid null pointer exception

Fixed potential casting issues

Updated pom with affiliation information

Updated pom with URL

Bumped rivers to version 1.12

Updated BUCK for version 1.12

NIC speed has become long and NICs are retrieved in a sorted fashion

Fixed warning

Timing statistics contain autoscale measurements

Fixed CPU vendor ID for Intel

Bumped Metron's drivers to version 1.13. Fixed origin and URL in pom.xml

Updated RestServerSBDevice to comply with the extended ONOS RestSBDevice

Total refactoring of the driver to become more generic (NFV -> Server).
Also properly separated the statistics API from implementation.

Refactored server driver and bug fix that occured when port statistics
were called before a device is properly discovered.
Statistics API and implementation are grouped again.

Removed unnecessary stuff from pom and BUCK files

Fixed checkstyle warning

Added short readme to pom.xml

New ControllerConfig behavior added

This patch adds an new ControllerConfig behavior to the server
driver, allowing external applications to get, set, and remove
a server's controller configuration.
Common functions and variables are also shared between the
two basic modules of the driver.

Fixed checkstyle warnings

Refactored controller configuration module

Consistent values returned by the methods of the driver

Unit tests for ServerControllerConfig behavior

Fixed preconditions for NULL and arguments

Improved documentation

Updated pom and BUCK

Addressed comments about sharing some more methods

Refactored the Common.java to become a base class
that extends AbstractHandlerBehaviour and can share
a unique instance of the RestSBController with child
classes. Also, after the removal of some deprecated
methods of the HTTP SB controller, I had to perform
some compatibility changes in the respective methods
of this driver.
The only problem is that my tests are now broken(??)
and I had to remove their code for now until I fix
the issues.

Expose some members and methods of BasicDriver

Renamed BasicDriver to BasicServerDriver

Change-Id: I0126adcb714f7e32695d546cf40a9de342722083
Signed-off-by: Georgios Katsikas <katsikas.gp@gmail.com>
2018-02-22 17:50:09 +00:00