- fix issues detected
- YANG custom registrator should be subject to checkstyle
- fix Java 8 syntax related violations
Change-Id: I0fc52c6612a40d851fd9bc3bf019621776b1f92a
This patch depends on 17671 onos-loxi patch. When we make
the new loxi release we need to change the prebuild
openflowj in lib/BUCK to that of the actual release number.
It provides support for programming l2 unfiltered groups,
the egress vlan table and the egress tpid table.
Depends-On: I3cea6ed2234147c8dbe440ae1701856a60706e7c
Change-Id: I7525f5856300eac25548b5219a5dffed12b291ad
java.lang.NullPointerException
at org.onosproject.provider.of.flow.impl.FlowStatsCollector.stop(FlowStatsCollector.java:96)[180:org.onosproject.onos-providers-openflow-flow:1.12.1.SNAPSHOT]
at org.onosproject.provider.of.flow.impl.OpenFlowRuleProvider.stopCollectorIfNeeded(OpenFlowRuleProvider.java:263)[180:org.onosproject.onos-providers-openflow-flow:1.12.1.SNAPSHOT]
at org.onosproject.provider.of.flow.impl.OpenFlowRuleProvider.access$400(OpenFlowRuleProvider.java:112)[180:org.onosproject.onos-providers-openflow-flow:1.12.1.SNAPSHOT]
at org.onosproject.provider.of.flow.impl.OpenFlowRuleProvider$InternalFlowProvider.switchRemoved(OpenFlowRuleProvider.java:417)[180:org.onosproject.onos-providers-openflow-flow:1.12.1.SNAPSHOT]
at org.onosproject.openflow.controller.impl.OpenFlowControllerImpl$OpenFlowSwitchAgent.removeConnectedSwitch(OpenFlowControllerImpl.java:783)[177:org.onosproject.onos-protocols-openflow-ctl:1.12.1.SNAPSHOT]
at org.onosproject.openflow.controller.driver.AbstractOpenFlowSwitch.removeConnectedSwitch(AbstractOpenFlowSwitch.java:344)[164:org.onosproject.onos-protocols-openflow-api:1.12.1.SNAPSHOT]
at org.onosproject.openflow.controller.impl.OFChannelHandler.channelInactive(OFChannelHandler.java:1288)[177:org.onosproject.onos-protocols-openflow-ctl:1.12.1.SNAPSHOT]
Change-Id: Iae3150f9eb3767c4b579d6b287dededb2da76997
The "FlowEntryBuilder" object calls "getDriver()" twice during a
"build()". These are very expensive calls, they can represent most of the
CPU time from an OF event. Since every instance from "FlowEntryBuilder"
has an unique "DeviceId", move the creation of the DriverHandler to
"OpenFlowRuleProvider".
Change-Id: I378f840b1e971d3b141c1a4fcbcbed62e956b578
- OVS with OF1.4 passed `stc smoke` test
- OVS with OF1.5 still has issue
As of OVS 2.5.0, OF1.5 mode responds with ill-formed of_meter_features_stats_reply
org.projectfloodlight.openflow.exceptions.OFParseError: Wrong length: Expected=40(40), got=32
at org.projectfloodlight.openflow.protocol.ver15.OFMeterFeaturesStatsReplyVer15$Reader.readFrom(OFMeterFeaturesStatsReplyVer15.java:281)
Change-Id: Ib78b9d92ecfb4bb667e24c4ee95bcd09aec160a6
