2809 Commits

Author SHA1 Message Date
Thomas Vachuska
e95da77264 Promoting new GUI resources into place; still hidden behind legacy redirect though.
Change-Id: If1f25cd7297b93374f492474eb321da16e9995ec
2015-02-23 15:50:11 -08:00
Thomas Vachuska
5f39965caa Migrated legacy GUI resources out of the way for the new GUI.
Change-Id: I92dff4012c63d2f60ee61b5d10cbc4a384d49233
2015-02-23 23:18:45 +00:00
sangho
01a883cbd9 ONOS-1160: Bug fix for sending groups stats also for non OF1.3 switches.
Change-Id: I5dd75d23aaf2a22f084a8ad7d91b402a869da038
2015-02-23 23:15:10 +00:00
Ray Milkey
43a2822c10 Refactor tests to use shared mock implementations
Change-Id: Iba4e44b7bb88f8a31add9475a9155f85375ae61a
2015-02-23 22:44:24 +00:00
Madan Jampani
6b5b717d80 Gave threadpools more appropriate names.
Change-Id: Ib7ce71a3028363b1465fbd5775f84e2befaf80c1
2015-02-23 22:40:56 +00:00
Pavlin Radoslavov
dbeab4cc33 Fix a bug when using IpPrefix.contains() and we are mixing IP address
families.

The bug (an exception) is triggered when internally we try to create
a masked IPv4 address with a very long IPv6-derived mask length.

Added the corresponding unit tests.

Change-Id: Id835d27ab3ff38dcf7a1387ff32ccb701aa2fe11
2015-02-23 22:30:55 +00:00
Ray Milkey
5a7787a62c Unit test for intent accumulator
Change-Id: Id9f8c918bdddc7fe24e4eb283676fd94275e58cf
2015-02-23 13:58:21 -08:00
Yuta HIGUCHI
7887b477ce Exclude generated fields from ImmutableClass check
- Eclipse sometimes auto-generates switch table, which fails the immutability unit tests.
  Ignore field name starting with _ or $, which tends to be used for auto-generated names.

----
Failed tests:
  IpAddressTest.testImmutable:41
Expected: is "a properly defined immutable class"
    but : was "a field named '$SWITCH_TABLE$org$onlab$packet$IpAddress$Version' that is not final"
  IpPrefixTest.testImmutable:39
Expected: is "a properly defined immutable class"
    but : was "a field named '$SWITCH_TABLE$org$onlab$packet$IpAddress$Version' that is not final"
----

Change-Id: Ibca5f61b9ca6b6006424a4288f1863b6e60ad484
2015-02-23 21:45:52 +00:00
Simon Hunt
d450da9d18 GUI -- TopoView - mockserver.js -- re-instated the "auto-advance" feature.
Change-Id: I867430cf42483fa7f2cacdd0b6fdd97d0eaa90a9
2015-02-23 13:25:59 -08:00
Madan Jampani
2af244a977 Never process incoming messages on the netty event loop thread pool.
Currently in a lot of places we are deserializing incoming messages on this threadpool and that could be significantly limiting throughput.

Change-Id: I83eb7e91004cea4addb28bc28f27e50de10028fe
2015-02-23 20:37:25 +00:00
Pavlin Radoslavov
a853709a6b Fix IPv6-related bug in SDN-IP.
- Use the correct API to set an IPv6 prefix in the matching condition

Change-Id: I7911a7e886024bff5442821816e4481570ec8172
2015-02-23 20:06:24 +00:00
Brian O'Connor
b28f5d740e Revert "Using CommandSession console instead of System.* in AbstractShellCommand print and error"
This reverts commit ea9ae214f9bca97537378f205910d62b7aa4be47.

The karaf shell explicitly depends on System.{out,err}, so piping to shell commands is broken by this patchset.

Change-Id: Ib7fb6341cfa42418115663413ea406173f5debf4
Note: When running as a service, if a thread that isn't the command thread calls print, it will go to $KARAF/var/System.out
2015-02-23 19:37:48 +00:00
Thomas Vachuska
a0509897a9 Preparing for dynamic GUI extensibility.
Change-Id: Ic25143bb9ad8919d7c9e70d932dde528a9227e6a
2015-02-23 11:31:37 -08:00
Simon Hunt
142166bb96 GUI -- TopoView - Updated "traffic" test scenario.
Change-Id: Ic6fb17f069d87000cfd0f6c68b2f52daf9ef163f
2015-02-23 11:08:34 -08:00
Bri Prebilic Cole
c4403328be GUI -- Refactored ToolbarService to have only new toolbar functions.
Change-Id: I0319335915f37d3a63b3ac734d8f8e00ebed20ae
2015-02-23 10:29:32 -08:00
Thomas Vachuska
93da11f8b5 Providing sample web.xml configuration for enabling basic authentication of REST API & GUI.
Change-Id: I1ee8853945611d7778a4a4dc38883cfe266a5efa
2015-02-23 18:22:53 +00:00
Bri Prebilic Cole
08381ce2a4 GUI -- Button and Toolbar Services with unit tests - finished implementing button widget, started modifying toolbar to use ButtonService
Change-Id: I96078516d396951175fb8d9e69dd7796da9f114e
2015-02-23 17:25:46 +00:00
Thomas Vachuska
4c6c377110 Fixed javadocs.
Change-Id: I74064c7e6dce702c769272cfa5dba99a61ea5abc
2015-02-23 08:50:49 -08:00
Thomas Vachuska
75af68aad9 Enhancing accumulator to allow subclasses to indicate whether they are ready for the batch to be processed. Default behaviour returns true.
Change-Id: I53a3ffc3ecd75ed2607f155a61971e05a6009a66
2015-02-22 20:41:54 +00:00
Thomas Vachuska
a132e3acd3 Made intent perf app multi-threaded; doesn't seem to help.
Made Jono's changes to ECM per Madan's suggesion.
Added cell beast.
Re-enabled anti-entropy.
Added ability to push bits through test proxy for faster upload.

Change-Id: I1455d6d443a697d7a3973c88cb81bfdac0e1dd7f
2015-02-22 20:31:04 +00:00
Madan Jampani
2e5f87b548 Limit the amont of work that happens on netty event loop threads.
Currently we are kryo serializing/deserializing the message envelope which can potentially limit throughput.

Change-Id: I0ae9dab53bbb765b7618ceaefda1edf4f77b0b59
2015-02-22 10:37:15 -08:00
Thomas Vachuska
d32bfdcaa9 Fixing javadocs.
Change-Id: I49faf425e0f9aa53547caf42f1d4025fb8d9dba6
2015-02-21 16:39:25 -08:00
Thomas Vachuska
fe8c98ad0b Adding support for user interface extensions.
Change-Id: I1e41d16efc11be31ad4c2fb0c09e86e3dfd26706
2015-02-21 16:17:35 -08:00
Thomas Vachuska
6f94deddef Converted all executors that previously used namedThreads to use groupedThreads instead.
Change-Id: I048709308270de5b7552bc4e8395b0f7201d5949
2015-02-21 14:02:38 -08:00
Sho SHIMIZU
6c28f8371c ONOS-1066: Move IntentCompilers to the dedicated package
Change-Id: I3e588cab0559093d389c9d44d2c7df536cabe953
2015-02-21 18:05:12 +00:00
Sho SHIMIZU
b70521702d Remove dependency on PointToPointIntentCompiler
Create an installable intent, not relying on an IntentCompiler.
This change enables IntentCompilers to be moved to a dedicated package.

Reference: ONOS-1066

Change-Id: Ie5bca33720232afaa4d6642d4f9fda933f6d00e3
2015-02-21 18:01:51 +00:00
Sho SHIMIZU
0e738806ff Move unit tests to PointToPointIntentCompilerTest
The unit tests only depend on PointToPointIntentCompiler and it would be
obstacles when IntentCompiler subclasses are moved to a dedicated package

Change-Id: Ifbfe5ef2a4bae014d2b6cae599fe8860a54e01ca
Reference: ONOS-1066
2015-02-21 17:58:07 +00:00
Sho SHIMIZU
575a364517 Remove obsolete todo comment
Change-Id: I9ebb573e8c259abd71f2cc90bae20764c10cf620
2015-02-21 09:47:50 -08:00
Sho SHIMIZU
b0a47d41c8 ONOS-1048 - Define interfaces instead of using IntentManager
- Define IntentProcessor interface containing methods to process an intent
- Pull out IntentCompiler related tasks to CompilerRegistry
- Pull out IntentInstaller related tasks to InstallerRegistry
- Create an IntentProcessor subclass as inner class in IntentManager

Change-Id: Ia3e8d574a1053e7ddc9b961873ef758c9e0b1b26
2015-02-21 09:33:13 -08:00
Jonathan Hart
054da97e83 Implement command to view Raft partitions
Change-Id: I9d3cea49877d69c2d7935dadbbad2770349e793a
2015-02-21 17:00:39 +00:00
Pavlin Radoslavov
b9e50dff43 Fixed a bug when parsing configuration properties for ReactiveForwarding
by catching the appropriate exception.

Apparently, if a property is configured/enabled in file Foo.cfg, e.g.:
  flowTimeout = 10
then the corresponding object/value in the Dictionary returned by
ComponentContext.getProperties()
has class type String.

However, if the property is commented-out, e.g.:

then the Dictionary still contains an entry for "flowTimeout", but
its class type is Integer.

Also, updated similar code elsewhere that was catching the generic
Exception with catching more specific exception(s).

Change-Id: I33ec348eb9efe3188e22cfc8cee2bb704948726d
2015-02-21 15:57:17 +00:00
Brian O'Connor
71503cd103 PartitionManager: reduce number of partitions to improve stability
Change-Id: I972583c0ba397017b6bfa40f5ddf6f13253c6d45
2015-02-20 22:15:55 -08:00
Brian O'Connor
b289422189 EventuallyConsistentMapImpl: pushing serialization and sending to caller thread
This has the effect of limiting the caller so that it can't overrun the single thread that previously did the job.

If you let this back up, it will use all of your memory. :(

Change-Id: I0a3b93cfa7004e0430d228a68c60e2b7ba966d4e
2015-02-20 22:15:55 -08:00
Brian O'Connor
64a0369dfb IntentInstaller: changing from Set to Collection to improve perf
Change-Id: Ia7f0f7d893645c7528ac9f51acff133f6d82383d
2015-02-20 22:15:46 -08:00
Sho SHIMIZU
1ee563a503 Remove unnecessary non-null check assertions
Private methods need to ensure to return a non-null value

Change-Id: Ie1fffc52282660c4d32c8fbedd9f47049b2e74ae
2015-02-21 05:53:30 +00:00
Ray Milkey
8dc820868c Fix some compiler warnings about unchecked types
Change-Id: Ib360aa05fd0e194a65bbc0b624447e4bdb4ced93
2015-02-21 05:52:36 +00:00
Pavlin Radoslavov
bf23c550f1 Added new methods IPv4.getDscp() / IPv4.setDscp()
and IPv4.getEcn() / IPv4.setEcn().

Those can be used to get/set the DSCP and ECN bits in the IPv4 header
without explicit bit manipulation at the caller.

Change-Id: Ia7c5779abae5c4fc7a343e3f7ef3355eb7e86e3d
2015-02-21 02:49:01 +00:00
Thomas Vachuska
0249b5377d Enhancing intent-perf logging
Fixing defect in distributed app mgmt
Reducing DB manager heartbeat aggressiveness

Change-Id: I9ba948a2b2166625c56566502143c0d27f9a2c44
2015-02-21 01:32:52 +00:00
Pavlin Radoslavov
ab8553a52a Fix a bug: there are two ECN bits in the IPv4 header, not three.
Change-Id: Ibdfce817f2a506644e0f9cd16f46cf6ab1f75eb7
2015-02-20 14:13:50 -08:00
Ray Milkey
144eec5207 Fix Javadoc warnings
Change-Id: I366f2b9f3c11645a3392e0689619bfbad7a9eedd
2015-02-20 20:54:26 +00:00
Simon Hunt
2bfbad2d7a GUI -- TopoView - Oblique - removed unreferenced ThemeService injection.
Change-Id: Ie993faeaeb62538f52b6289ec3e2af90282be70c
2015-02-20 11:57:11 -08:00
Simon Hunt
c3c5b678a0 GUI -- TopoView - Re-instated the oblique view function. (Keystroke 'Z').
Change-Id: I1bc4c11590660142a6bc9f5f71c06a664dbfa80b
2015-02-20 19:49:51 +00:00
Dusan Pajin
0d1d48f474 Additional configuration parameters in onos-app-fwd
Additional configuration parameters that can be configured in the configuration file (org.onosproject.fwd.ReactiveForwarding.cfg),
that determine application behavior:
- packetOutOfppTable - application will use OFPP_TABLE port in PacketOut message, sending packet back to the OpenFlow pipeline, instead of using switch port
- flowTimeout - configuring reactively installed flow timeout
- flowPriority - configuring reactively installed flow priority
- matchDstMacOnly - reactively installed flows will match only destination MAC address - behavior as legacy L2 switches. This options overrides all other options below.
- matchVlanId - reactively installed flows will match default condition with additionally with VLAN ID field
- matchIpv4Address - reactively installed flows will match default conditions, plus IPv4 address and Protocol field
- matchIpv4Dscp - reactively installed flows will match default condition, IPv4 + with IPv4 DSCP and ECN fields (need matchIPv4Address enabled)
- matchIpv6Address - reactively installed flows will match default condition with IPv6 address and NextHeader field
- matchIpv6FlowLabel - reactively installed flows will match default condition with IPv6 address and IPv6 Flow Label (need matchIPv6Address enabled)
- matchTcpUdpPorts - reactively installed flows will match default condition with IPv4 or IPv6 address and TCP/UDP ports (need matchIPv4Address or matchIPv6Address enabled)
- matchIcmpFields - reactively installed flows will match default condition with IPv4 or IPv6 address and ICMP type and code fields (need matchIPv4Address or matchIPv6Address enabled)

Change-Id: Ieef67a1a12f6341d4de3b07e1226affec66d361a
2015-02-20 19:34:35 +00:00
Yuta HIGUCHI
6a47964aad Instruction related fixes
- Removed redundant equality check. (ONOS-975)
- Enforced using Instruction Factory methods.
- cosmetic fixes.

Change-Id: I178b55f8568c1a9132f0aa88465b8b34dc2b2df2
2015-02-20 19:12:19 +00:00
Jonathan Hart
e6f8400f83 Cleaned up dependencies after routing code shuffle.
Change-Id: I1388749f77ef9b3b327df2ee745fdb7cec510708
2015-02-20 19:08:00 +00:00
Ayaka Koshibe
d2c7ad2068 NullLinkProvider restructured with a CachedThreadPool. This should in theory
allow more LinkDescriptions to be generated.

  - patch 3/4: Some cleanup/sanity checks added.

Reference: ONOS-1033

Change-Id: I0b35585d5fdec3f7e6c921172f39f67dd6723dec
2015-02-20 19:01:56 +00:00
suibin
1a7b7bd956 fix calculation on event rate
Conflicts:
	providers/null/link/src/main/java/org/onosproject/provider/nil/link/impl/NullLinkProvider.java
	tools/package/etc/org.onosproject.provider.nil.link.impl.NullLinkProvider.cfg
Change-Id: I955abaec4c3906441ada91d97ed30854a8ce44f8
2015-02-20 18:55:40 +00:00
Brian O'Connor
8fc739af47 Disabling anti-entropy messages to stabilize performance of intent store
Change-Id: Ic66c6d710e6bc4bc82496c38a5b9955e58f72e73
2015-02-19 22:32:15 -08:00
Brian O'Connor
bcfeadb223 Improvements to IntentPerfInstaller
* adding total to log
* using local devices and keys
* added delay between cycles
* print time if cycle is delayed

Change-Id: I16a3c041dd2e920695ab782d22fe6db8abad7da8
2015-02-19 21:51:29 -08:00
Brian O'Connor
2952e3b7b6 updates to EventuallyConsistenMapImpl to improve parallelism
Change-Id: I7bf29c02380f630e592d980d0795efc6ac13167a
2015-02-19 21:51:27 -08:00