902 Commits

Author SHA1 Message Date
Ray Milkey
0a1a091e5f Remove deprecated Alarm builder API
Change-Id: I2a51096836b918179b1e2b9e7a3358447e7170cb
2018-02-15 19:51:07 +00:00
Yuta HIGUCHI
5ac3443361 Async netconf API + command for netconf troubleshooting
- Added async API for fetching entire config (+ state)
- netconf-get
   issue netcong rpc get
- netconf-get-config
   Revised to use async API to deal with slow device

Example usage:
  onos> netconf-get netconf:192.168.56.1:2022 | ppxml

 for ONOS-7481

Change-Id: Id012e984275109c93bdae113f3fec685a7b2211b
2018-02-15 19:33:05 +00:00
Ray Milkey
0e84f44bfc Remove deprecated HTTP SB controller APIs
Change-Id: Id712a389991c3ba405c1feded64054ccc95e945f
2018-02-15 19:29:08 +00:00
Ray Milkey
a7cf8c8f55 Remove deprecated DefaultPath constructor with a scalar cost
Change-Id: Ifc4104cff773c9c692cc108fda02ce44bc6c2870
2018-02-09 17:51:28 +00:00
Ray Milkey
d4b51c2651 Remove deprecated key file interface
Change-Id: If66006b4ffbe194be2a06eb14e3409219192edcc
2018-02-08 22:33:49 +00:00
Ray Milkey
f3cbc80f16 SONAR suggestion - remove unneeded catch of Exception
Change-Id: Ic83dd4d6048a4fca3582d30a21a37595e1e8a3a8
2018-02-07 17:18:44 +00:00
Ray Milkey
2b4958a463 SONAR suggestion - don't use generic exceptions
Change-Id: I77c4325281e94e189b7f1212a932f7e912b56b51
2018-02-06 18:59:06 -08:00
Ray Milkey
5c7d488269 SONAR suggestion - proper handling of InterruptedException
Change-Id: I67a93c064708c207d9ce83fac319682c2d17db60
2018-02-07 00:59:07 +00:00
Yuta HIGUCHI
e46f09365b Workaround to make mis work
- workaround to make rebuilt without cleaning

Change-Id: I74d444cc73e7304c3ca499d4a01964f28a7d8925
2018-02-06 18:47:33 +00:00
Ray Milkey
ba547f9158 SONAR suggestion - log exceptions, don't print stack traces
Change-Id: I4814a0662912706df005972d44c48a7db39ecd50
2018-02-06 17:55:22 +00:00
Ray Milkey
ef31005fd2 SONAR suggestions - uneccesary instanceof operators
Change-Id: I11b23df5814c23e2a825f8844e6c13f2d99196d2
2018-02-06 17:54:30 +00:00
Ray Milkey
928644f5e6 SONAR suggestions - don't have a public setter in an enum
Change-Id: I96829f6b461ea541c4e8b9af9859724ec139534f
2018-02-05 17:53:30 +00:00
Ray Milkey
3717e604d5 SONAR suggestions - prevent truncation of arithmetic expressions
Change-Id: I4694c0c3183b991a4f0db793f584bc77a5fb7d60
2018-02-02 23:06:44 +00:00
Yi Tseng
e67e14195a [ONOS-7437] Logs more detail from P4Runtime error message
Change-Id: Ia2cc2db332148313c9834cde8bb16484550e18f8
2018-02-01 23:57:05 +00:00
Ray Milkey
42b6203896 SONAR suggestion - problems with string format calls
Change-Id: Ie6b985d2e4db79d6398b17e38a680920f52366b3
2018-02-01 21:09:07 +00:00
Ray Milkey
986a47aa7c SONAR suggestion - generic exceptions
Replace uses of generic RuntimeException
with more appropriate unchecked exceptions

Change-Id: If283743c2cf7252b8d280bdb788708ebbe57da9d
2018-02-01 18:36:33 +00:00
Jordan Halterman
47432589c1 Add distributed lock primitive
Change-Id: I60f4581d5acb5fc9b9a21d4191874bb56348af58
2018-02-01 18:35:59 +00:00
Jonathan Hart
39e2023c6c Don't try and write an empty list of OF messages
Change-Id: Ic18971cd0b4b019906d2bdcbe9aef627f79065f7
2018-02-01 09:26:02 -08:00
Yuta HIGUCHI
f1653a7c39 pom cleanup
+ minor fixes

Change-Id: Ie8a9c42cdcfcff131528f73ace5b9efdc08f05a1
2018-02-01 15:02:21 +00:00
Ray Milkey
2e27ec5b35 SONAR suggestion - constant arrays should be private
Change-Id: Ia51f13e19edcf1cec49331d1aad297ad1373eb6b
2018-02-01 15:00:28 +00:00
Ray Milkey
019fba404e Refactor exception handling in the OSPF protocol
- removed unnecessary throws of Exception from methods
- converted throws of generic Exception to specific OspfParseException

Change-Id: I9d07167d92f221a234e9eba4c6082deb165afc0b
2018-02-01 04:10:13 +00:00
Ray Milkey
b001b55b92 SONAR suggestion - .equals() calls that cannot be true due to type mismatches
Change-Id: I65f867be548530813fc7164b610888b1f84591b5
2018-02-01 04:08:54 +00:00
Yuta HIGUCHI
488a94c31e more error-prone issue fix
Change-Id: I49f2cc0459cfddddc6a99e2ebb8ad52d547e2909
2018-01-29 21:12:15 +00:00
Ray Milkey
d062f362ac Add new REST dependencies to Maven build
Change-Id: I2fb4bb0d4db07959313befc9146414dc3749f4e9
2018-01-29 09:55:10 -08:00
Sean Condon
13b1681824 Add support for RESTCONF standard errors
Change-Id: I74c0997bc8e06bc10c97cd610ff70c7a6aa68c8b
2018-01-27 11:16:26 +00:00
Yuta HIGUCHI
fbd9ae9cdf Various small fixes
Change-Id: I83802169d0d968f7b88d4be2cedba74b15fdd7da
2018-01-25 22:17:25 +00:00
Jonathan Hart
34a14f71f0 Add more logs to help debug packet processing issues
Change-Id: Ia9e36bff44b6bad018305725ebb0fc2a47c86376
2018-01-25 22:13:44 +00:00
Ray Milkey
06297ed618 SONAR suggestion - Synchronize initialization of static fields
Change-Id: I2ddf8220bda49f235ddfc5713174c11a147df354
2018-01-25 00:49:28 +00:00
Yi Tseng
9539082d93 [ONOS-7393] Allows TableEntryEncoder decode action profile group and member id
Change-Id: Iffac08f2d0929144d438dcb61d381fbc2f6393ea
2018-01-24 09:48:29 -08:00
Andrea Campanella
bf9e5ce3f5 [ONOS-7137] Interfaces Discovery through gNMI
Also, bumped version of gNMI proto as supported by PI

Change-Id: If2903b2dc483f545893daae77f993cc7dadee468
2018-01-24 16:54:21 +00:00
Yi Tseng
02c4c579f4 [ONOS-7392] Fix P4Runtime priority bug
Change-Id: I97aabb25ebf4f2d16c3c7f17f369a7744ef03994
2018-01-23 07:50:31 +00:00
Saurav Das
45f4815be0 Take down edge ports on a leaf switch when all uplinks are gone
- Bug fix for case when all uplinks are gone, but dual-homed host continues to send packets to switch;
  We now administratively take down the host port to force the host to use the other leaf in the pair.
- Restructured SR manager by creating a LinkHandler
- fixed/added some log messages

Change-Id: I3722cd364dc8798b16891519bec165627e92bd87
2018-01-19 18:30:10 +00:00
Ray Milkey
7b332f168f SONAR suggestion - possible NPE if date is not set
Change-Id: I35a58ad7a5f82250fa56f49cdca4a22b437ea202
2018-01-19 18:23:04 +00:00
Ray Milkey
fe0e085ed2 SONAR suggestions - boolean expressions that are known to be 'true' or 'false'
Change-Id: I4e089cb606ecf43444b4d567ad63d622f37506ce
2018-01-19 08:59:46 -08:00
Ray Milkey
74e5913ec3 Sonar suggestions - fixes to potential null pointer dereferences
Change-Id: I4e350a9d72a9322971d5d4f831f1bdf167986b87
2018-01-18 19:01:54 +00:00
Laszlo Papp
8596fde581 Fix the JIRA ticket number in a comment
Also, abstract is implicit.

Change-Id: Ia3122058a9ff988dfa71214c922be67eb430e65c
2018-01-17 10:08:14 +00:00
jaegonkim
7b77f71246 [ONOS-7374] OvsdbBridges obtained by DefaultOvsdbClient.getBridges() do not have controller information
Change-Id: I74640e991940e1b63e34c95512466e0807d33271
2018-01-17 00:22:19 +00:00
Ray Milkey
9c9cde4d4d SONAR Suggestion - protected members in final classes are pointless
Change-Id: Ie34d86aecf181e73867a14864d75e0db8a8f48f3
2018-01-17 00:18:50 +00:00
Ray Milkey
d6c4280f5e Sonar suggestion - don't lock on a field that is being modified
This code could also throw an NPE if called at the wrong time.
Fixed by saving the value to lock on before saving the new value.

Change-Id: I6a7570c00135d7cff31f3429af1067f4228e5189
2018-01-16 21:11:23 +00:00
Manjunath Vanaraj
59ad65730a [ONOS-7334] Using Cache Loader to remove stale entries in p4runtime
Change-Id: Ieead6e199faf23f5fa316516adab659d3e192950
2018-01-13 02:05:59 +00:00
Saurav Das
bd071d8227 Bug fix in routing logic - should let routing process continue
if a particular route-path is ignored. Also added info logging for port-status
messages to clearly identify messages coming from the switch as opposed
to possibly fake updates generated by ONOS.

Change-Id: Ib03dfe0e2dcdcfb046d58657473fa4122ec15190
2018-01-10 17:38:52 +00:00
ONOS Jenkins User
45d340c839 Starting snapshot 1.13.0-SNAPSHOT 2018-01-09 01:56:13 +00:00
ONOS Jenkins User
32ebb5add8 Tagging 1.13.0-b8 2018-01-09 01:54:28 +00:00
Thomas Vachuska
d75684aa58 Setting dispatcher to null to pre-empt potential for duplicate
invocations of showdownNow method.

Change-Id: I492e18a38979fa8772039b0e0bac32d6146a2041
2018-01-09 00:54:40 +00:00
Carmelo Cascone
47a853baad ONOS-6680 Clean up implementation of gRPC controller
Change-Id: If84172d0a2dd64090557542af8ae12920260229f
2018-01-05 23:14:37 +00:00
Laszlo Papp
edadbe2574 Do not send table stats request if unsupported
Change-Id: Ia66447aad1eeb0a01577215e4c5985526dadd274
2017-12-20 09:33:44 +00:00
Ray Milkey
b68bbbc5ac Sonar suggestion - use a secure random number generator
Change-Id: I28075845555bcbc384a49e07353b3192c413b8f7
2017-12-19 17:58:54 +00:00
Ray Milkey
9922d5cd64 Sonar suggestions - comparison logic
- make members private
- use Integer.compare()
- use and operation to be sure both pointers are not null in if comparisons
  in compare() method

Change-Id: Iab9da32a28a49bc258ab5f600feff5c155c59a91
2017-12-19 17:58:54 +00:00
Yuta HIGUCHI
f83c8cfdf6 Maintain OFPortDesc up-to-date
- OFPortDesc cache managed by AbstractOpenFlowSwitch was not always maintained properly.
  reorganized data structure to maintain per OFPortDesc, last known instance

Change-Id: I1b26d7ca284e44bf9744c30374394c581653d78f
2017-12-18 14:58:22 -08:00
fahadnaeemkhan
2675a271cb OAuth2 authentication support for patch API, (HttpSbController)
Change-Id: I4b0ae5d0ab60db968812eb5d26b277a1975e8098
2017-12-18 19:52:04 +00:00