68 Commits

Author SHA1 Message Date
Thomas Vachuska
b093c916e5 Renamed IOLoop & Netty to *MessagingManager for consistency.
Change-Id: Id8859e24d0c7ac7f948516388069639093bad524
2015-04-20 17:43:06 +00:00
Madan Jampani
c26eede685 Added a messaging service implementation on top of IOLoop. Added ability to easily switch between netty and io loop (default is netty)
Change-Id: Id9af0756bf0a542f832f3611b486b2ac680b91e4
2015-04-20 05:28:48 +00:00
Ray Milkey
34c959066d ONOS-533 Fix copyrights
- Any files created in 2014 and modified in 2015 got a copyright of
  2014-2015
- Used canonical form of 2014-2015 to be inclusive of extra years.
  Some files had 2014,2015

Change-Id: If9a133618873e4000b8f10299bde7c870eb1fbd5
2015-04-15 17:41:07 +00:00
Madan Jampani
ec5ae341db Use the Executor interface when specifying where to handle incoming messages
This is done so that one can simply specify a direct executor.
Change-Id: I1c3ea977dd7c2d604588d587fd67f7012355eedf
2015-04-13 23:43:52 +00:00
Madan Jampani
2bfa94cf15 Revamped ClusterCommunicationService API
Change-Id: I9326369de3d2413b0882b324979d10483c093de9
2015-04-13 16:51:24 +00:00
Madan Jampani
cd48bfd694 Make sure message handling executor references are appropriately managed when we modify the service configuration
Change-Id: I56866dd8c3359de0fcf827fc247024c65a63c5c2
2015-03-26 03:08:48 +00:00
Madan Jampani
49115e931a Changed netty message type to String from Long to avoid potential collisions
Change-Id: I42014a920917a8022744ae15a9fefa6bae6890a7
2015-03-15 21:40:47 +00:00
Madan Jampani
ba47223f6f Bypass netty stack for messages that are sent to self
Change-Id: Ifb1fd610892bd22a291cda472a8a5ef7a1dcfe6d

Manual serde for ClusterMessage to avoid one additional kryo serialization overhead for each message sent/received

Change-Id: I08d9a2c10403b0e9e9e1736c6bd36fa008bb8db0
2015-03-05 06:55:13 +00:00
Madan Jampani
52860be069 Debug log level where appropriate + Throwing an exception where appropriate
Change-Id: Ica18c122c8a2cb8286d4f48c017a06ffe10452e1
2015-02-27 12:52:37 -08:00
HIGUCHI Yuta
459bddf56a Fix type mismatch
Change-Id: I26d094c4ae0d7c6699e49a0aa9885bd4d6d89e33
2015-02-24 23:46:06 +00:00
Madan Jampani
2af244a977 Never process incoming messages on the netty event loop thread pool.
Currently in a lot of places we are deserializing incoming messages on this threadpool and that could be significantly limiting throughput.

Change-Id: I83eb7e91004cea4addb28bc28f27e50de10028fe
2015-02-23 20:37:25 +00:00
Madan Jampani
2e5f87b548 Limit the amont of work that happens on netty event loop threads.
Currently we are kryo serializing/deserializing the message envelope which can potentially limit throughput.

Change-Id: I0ae9dab53bbb765b7618ceaefda1edf4f77b0b59
2015-02-22 10:37:15 -08:00
Yuta HIGUCHI
0a0b9e46bf Log more info when inter-Node messaging fails.
Change-Id: Ifd749a3023854d688a675c7279c27868b8bed436
2015-02-12 01:43:12 +00:00
Yuta HIGUCHI
c611d927aa Fix Cache Removal listener
- Removal lister will be called even if the entry was manually
  invalidated. Timeout handler should check for the cause.

Note: In both of the cases fixed in this patch, Future should silently ignore
  setException, external behavior-wise no change by this patch.

Change-Id: Id46f23c9ff8dfa607874cfd94807000f03a95b31
2015-02-11 06:21:35 +00:00
Ray Milkey
3f0c97ebc5 ONOS-395 - tighten up exception handling
Change-Id: Ice3ee55adacbd890100def5d9da44c6e2a770945
2014-12-09 00:53:06 +00:00
alshabib
4785eec529 removing some TODOs
Change-Id: Ic98c811573a1b37813993eedddec512ec85729f3
2014-12-05 00:59:35 +00:00
Brian O'Connor
abafb50f58 Changing org.onlab.onos package to org.onosproject
Change-Id: Ic81421faa27acdcff045add47d9e0a715cd4f575
2014-12-02 22:26:20 -08:00
Yuta HIGUCHI
3e51ea467f PingPongTest: turning off fragile test failing randomly
Change-Id: I6ce2df09dafda097f096ea941ba49162fe48934c
2014-11-24 18:29:13 -08:00
Yuta HIGUCHI
91768e30e5 Kryo related fixes
- KryoNamespace to allow control over registration id

Change-Id: Idc2a0e27a09916657c725ee97e4366109144cc66
2014-11-22 19:35:28 -08:00
Madan Jampani
8c35207b3f Merge branch 'master' of ssh://gerrit.onlab.us:29418/onos-next 2014-11-09 01:38:46 -08:00
Madan Jampani
348a9fead4 1. MapDBLog log size calculation bug fix.
2. Minor logging improvements.
2014-11-09 01:37:51 -08:00
Yuta HIGUCHI
5f9d6969d5 NettyMessagingService: add null check
Change-Id: Ic4897e69253526d3c3cd2c0a0fe00df1bdc7d787
2014-11-07 17:07:32 -08:00
Yuta HIGUCHI
813fb90b8d MessageEncoder: lower IOException log level
Change-Id: I7c6eaae3fdb5f87a095722f5b8ed005b460f90cc
2014-11-07 01:49:33 -08:00
Yuta HIGUCHI
5e8ceb455e checkstyle fixes
Change-Id: Ida02536e61f61b8883810866d28bdaad206f645d
2014-11-04 17:22:26 -08:00
Yuta HIGUCHI
f3fbdd050a findbugs
Change-Id: I040eee94d2eb2622b32fbe8dbf06d81b54765065
2014-11-04 09:46:23 -08:00
Yuta HIGUCHI
5c94727a3c javadoc fixes
Change-Id: I3b4fc2d99f42b2413a535fb411b9c19bdd186ad8
2014-11-03 21:39:21 -08:00
Thomas Vachuska
4b42077418 Cleaned up a slew of Javadoc errors in preparation for switch over to Java 8. 2014-10-30 16:46:17 -07:00
Madan Jampani
a5012891b4 Merge branch 'master' of ssh://gerrit.onlab.us:29418/onos-next 2014-10-29 13:48:03 -07:00
Madan Jampani
5f9ec9ac28 Netty Messaging changes:
1. Lowered the timeout value for expiring unanswered sendAndReceive calls to 10s.
2. Marking the future as complete (with exception) when a entry is evicted due to timeout.
3. Improved exception behavior.
2014-10-29 13:45:52 -07:00
Thomas Vachuska
4f1a60c9fd Revised copyright message. 2014-10-28 13:39:11 -07:00
Madan Jampani
15cd0b8fd3 Netty bug fix: Do not use weakValues in a cache where we track outstanding responses. 2014-10-28 08:40:23 -07:00
Thomas Vachuska
24c849c488 Added copyrights to the utils code 2014-10-27 09:53:05 -07:00
Madan Jampani
cfbc05404b Removed exception stack trace for a warning log message 2014-10-24 20:38:07 -07:00
Madan Jampani
24f9efb49e sendAndReceive now returns a Future instead of Reponse 2014-10-24 18:56:23 -07:00
Yuta HIGUCHI
e5ca93bf1f fix some of findbugs issues
Change-Id: I20aa54af16f3a1e3323d735fe53cc26c03d5e52e
2014-10-23 12:14:37 -07:00
Madan Jampani
871009392c Added NettyMessagingService constructor that accepts both ip and port 2014-10-21 16:46:12 -07:00
Madan Jampani
99e9fe2c15 Better netty transport initialization 2014-10-21 13:47:12 -07:00
Madan Jampani
824a7c192a Netty epoll support. Now with updated pom.xml and features.xml to bring in the dependencies 2014-10-21 09:46:15 -07:00
Yuta HIGUCHI
48ec4f75e6 Revert "Using native transport (epoll) with netty"
This reverts commit f22f2043548ddba2c1a2ffc46ff0672006f1bc7e.

- It did not run inside karaf

Change-Id: Ieab6684bbde1029ad53337e9a4ee03623c2e6ab7
2014-10-20 18:05:27 -07:00
Madan Jampani
f22f204354 Using native transport (epoll) with netty 2014-10-20 16:55:54 -07:00
Madan Jampani
e602bb40da Revert netty nativ support 2014-10-20 16:03:41 -07:00
Madan Jampani
5e83f333ca Netty native transport (epoll) support 2014-10-20 15:35:09 -07:00
Yuta HIGUCHI
8d143d2a01 Rename KryoPool -> KryoNamespace
Change-Id: Ife1c311b40eaab133bb3b8dd3314b98c60b4411d
2014-10-20 09:11:06 -07:00
Madan Jampani
cc3295c80b Removed redundant serialization block 2014-10-07 17:51:15 -07:00
Madan Jampani
f4f6fe235f Removed files that no longer needed 2014-10-07 17:43:49 -07:00
Madan Jampani
29e5dfd82b Added logging to netty 2014-10-07 17:26:25 -07:00
Madan Jampani
9621ba1d8b Fixed merge conflict in InternalMessage 2014-10-07 12:45:44 -07:00
Madan Jampani
53e44e623a Simplified how message payloads get serialized/deserialized 2014-10-07 12:42:59 -07:00
Yuta HIGUCHI
c65f51273a Add TODO note
Change-Id: If600ac0f81bc25f9d1d2a6a3cbd9ffdbe19183cf
2014-10-07 10:27:26 -07:00
Madan Jampani
f1d425affe Logging fix in NettyMessagingService + Added a simple unit test. 2014-10-07 09:52:36 -07:00