1948 Commits

Author SHA1 Message Date
pierventre
e73a7270af [SDFAB-753] Optimize several ONOS components
Leverage the improved ClusterEvent to optimize several ONOS components.
The idea behind is that there is no need to react for these components
when an Atomix goes down. Actually, reacting will put additional
pressure in the Atomix nodes for no reason. Moreover, any operation done
in this period can potentially timeout

Change-Id: I5edeb3c1189e4255cdb1efb712da33d397da27bf
(cherry picked from commit 75ac28406acc3adf639385694ebb458d52ad8c88)
2021-11-15 18:28:01 +00:00
pierventre
55a5f39ae6 [SDFAB-753] Improve ONOS cluster event
Main idea of this change is to add an additional parameter
in the event that carries information about the failed instance.

Additionally, prevents several NPE by using hostname as id
when controller hostname cannot be resolved into an ip.

Change-Id: Id9886afe3f1e5ecee0f1414b2722c340680a813e
(cherry picked from commit fa5dc3c137a4deaa020a669388470b511c2b6a8e)
2021-11-15 17:05:23 +00:00
David Glantz
dfb3ceb78d Return intent collection with details
Added backwards compatible flag to GET /intents/ to return full intent JSON.
Added GET /intents/application/{appId} to return application specifc intents.
Extended IntentService to include getIntentsByAppId(appId).
Removed hard-coded intent codec lookup in IntentWebResource.

Change-Id: I38e7b1dbd7669e654afe723f6ec3a4eb7a9af6fb
2021-11-07 09:18:19 +00:00
pierventre
57f7bbb6ac [SDFAB-705] Fix GUI for the control and data plane resiliency
Additionally, fix similar issues in GUI2 and add initial
support for ports with name in GUI/GUI2.

This is also the first step towards supporting port with name widely in ONOS

Change-Id: Ib04f780bf0b7171e82a6beb69b39c0aaeb4be957
(cherry picked from commit 178046ba11ab21d94a1e818fb893931bb015734b)
2021-10-27 06:41:50 +00:00
pierventre
cf6ff90af8 [SDFAB-713] Ensure TrafficMonitor is properly shutdown
This fixes also a potential leak of memory and thread

Change-Id: I266a37365cef3776463a1aca2c1e2717507b4f30
(cherry picked from commit 2c39deac5ae8ee150c8ed8d479470e3c7f31f7fc)
2021-10-26 18:42:55 +00:00
Andrea Campanella
8f6594c6fb [ONOS-8150][VOL-4414] Fix for NPE in rest API after app gets uninstalled
Change-Id: I1cf0b330af43be8ea2211c5831ef715c1eafdea9
(cherry picked from commit 365751943b0c5316e79fbc1201a8d7af659e5008)
2021-10-25 14:08:55 +00:00
Sean Condon
4ceeae7439 ensure that the tests for forcesvg can be run by inlining JSON
Change-Id: I432025c8c02105f4a47fbdbb52384a6514efb495
2021-10-21 15:37:11 +01:00
pierventre
26ac1517c4 [SDFAB-542] Meters cleanup and leftovers v2
- Code clean up (unused code, unuseful comments)
- Remove deprecated internal APIs
- Prevent the ejection of the meter pollers
- Prevent the ejection of the mf pollers
- Fix unproper filter of device events
- Fix delete on store which updated existing meters with dummy value
- Fix NPE in TofinoMeterProgrammable caused by default config
- Update unit tests

Change-Id: Ib2767e3ab3cf146693e61b7e1890419c9743d521
(cherry picked from commit a770879a950d1cc985db1a659da701551700e886)
2021-09-16 16:13:33 +00:00
pierventre
c0914ec586 [SDFAB-500][SDFAB-527] Meters cleanup and leftovers
- Improve ONOS cli enabling CRUD of p4rt trtcm
- Improve ONOS rest enabling CRUD of p4rt trtcm
- Improve MeterService with scope defined reads and integrate in cli/rest
- Add support along the stack for BYTE_PER_SEC unit
- Add support along the stack for COMMITTED and PEAK bands
- Fix several bugs in ONOS cli/rest interfaces
- Improve REST codecs
- Fix NPE in MeterDriverProvider
- Improve PiMeterTransalation by enforcing trtcm config
- Implement explicit translation of the bands
- Fix ONOS reconciliation by removing from the mirror the wrong configs
- Remove unnecessary checks in MeterEntryCodec
- Update unit tests

It will follow a 2nd patch to complete SDFAB-527

Change-Id: I855235b17f60cb1d39f5b9a042c1015105a8a269
2021-09-10 10:22:18 +00:00
Andrea Campanella
5bdbe43567 [VOL-4055][ONOS-8138] Adding annotations to meter to allow passing of associated information
This patch allows for adding key value elements in the meter request and in the meter generated from it.
An example is:
Annotations annotations = DefaultAnnotations.builder().set("MeterForDeviceType", "olt").build();
DefaultMeterRequest.builder().withAnnotations(annotations)
Generates:
 DefaultMeter{device=of:00000a0a0a0a0a0b, cellId=2, appId=org.opencord.olt, unit=KB_PER_SEC, isBurst=true, state=ADDED, bands=[DefaultBand{rate=100000, burst-size=5000, type=DROP, drop-precedence=null}, DefaultBand{rate=100000, burst-size=5000, type=DROP, drop-precedence=null}, DefaultBand{rate=100000, burst-size=0, type=DROP, drop-precedence=null}], annotations={MeterForDeviceType=olt}}

Change-Id: Ifaded96ebeb7956bc60cdf311180c984c3ba954e
2021-05-19 13:05:50 +02:00
pierventre
e7c0bd18af [AETHER-1529] Nodes not READY due to gui/gui2 bundles being in WAITING
In particular gui2 bundle does not get activated due to the missing UiExtensionManager.cfgdef.
This patch manually copy the cfgdef generated for gui bundle into the final jar of gui2

Change-Id: I27fea43faa06f70bc8c0570c53a1dbf5cfd23e89
(cherry picked from commit 37691eb75be5ee295279bb3633bcefeb7166b444)
2021-04-14 08:26:59 +00:00
Charles Chan
4c02a9418a Disable SampleHighlighterFactory
Change-Id: I664152c2f409d4de0b4d5b76a8fd2403b523c06e
(cherry picked from commit 010cd8cc77fea25b2129ca7a2d97d589f7404f31)
2021-04-12 18:02:15 +00:00
Thomas Vachuska
a5e986d31c Added ability to configure GUI traffic refresh rate
Change-Id: Iceb1196a20c16f09218218da2e095fbe9644bb04
2021-04-06 21:31:11 +00:00
Thomas Vachuska
2b4de873e4 Added mechanism for apps to easily add their own custom link/node/host highlighting wihout having to create a new UI extensions
Change-Id: Iefa21d76190c60db79a4b07a8b22e301d29fe58e
2021-04-02 07:12:47 +00:00
Thomas Vachuska
a0410b8f65 Fixed a connectionType glitch
Change-Id: Idcd2cde2ea93ad91892bf6954c70b5c02490c37f
2021-03-29 14:01:18 -07:00
Thomas Vachuska
f06f5d676c [AETHER-1212] Added means to configure host links to appear as 'wireless'
Setting the host "uiType" to 'cellphone' will make the links "wireless"
and appear as dashed lines.
Additionally, a new annotation "connectionType" was added for hosts,
which when set to "wireless" will make links change appearance for any
type of hosts.


Change-Id: Iad87eb5c180b0a9175108c1179d9d28ae906e924
2021-03-10 22:30:38 +00:00
Thomas Vachuska
13b9017465 [AETHER-1243] Adding more host icons and changing the default icon.
Changed default icon to look like server; name is still m_endstation.
New icons are:
- m_terminal (old endstation icon)
- m_tower
- m_slrCamera
- m_videoCamera
- m_cellPhone
- m_endstation1 (alternate server icon)
- m_endstation2 (alternate server icon)

Also enabled other existing icons to serve as host icons, e.g. m_microwave.
Fixed an issue with host icon being different in the detail pane.

To set the icon type, you can use the 'annotate-host' command with 'uiType' annotation, e.g.

annotate-host 00:00:00:00:00:01/None uiType videoCamera

Alternately, use netcfg to configure the 'uiType' attribute.

Change-Id: I5b7e338f3c12319da34012c5a28de8c9a48f0b15
2021-03-03 21:07:18 +00:00
Thomas Vachuska
a4eac6a3b2 [AETHER-1211] Allowing toggling of link labels via Alt-L
Change-Id: I772b6ee0c6c24eeb48466a96a45b44b9ee6eef50
2021-03-01 21:37:31 -08:00
Thomas Vachuska
c8c8f46fd4 [AETHER-1213] GUI1 enhanced to allow scaling host icons and host text.
Scale is proportional to the current zoom level, but can be toggled in
four increments via SHIFT-[ (text) and SHIFT-] (icon) keyboard shortcuts.

The icon size limit was increased to be min 20 and max 70.

Change-Id: I49e983d34a2465fb12d48395c34c1f22911f4f51
2021-03-01 21:37:31 -08:00
Sean Condon
436c60a1f6 Upgraded to bazel 3.7.2 and rules_nodejs 2.3.2
Change-Id: If53686f2475c4f367909de577b4da95de8e16768
2021-01-04 15:42:57 +00:00
Lakshya Thakur
de3e6f52c8 Implemented HttpResponseHeadersFilter to set the CSP frame ancestors header to prevent iframe embedding
Change-Id: Ib58e452e291c4df407d30e8b914ab6aa20ae77bc
2020-12-02 07:32:43 +00:00
Lakshya Thakur
f111f57be9 Added CSP to prevent iframe embedding of gui2 and swagger ui
Change-Id: I77c5524cbb80f8f06de5f1cba8412cfb58a36324
2020-11-27 23:47:55 +05:30
Charles Chan
416ef14b9b [VOL-2950][VOL-3110][AETHER-457] Fix a bug in component readiness check
The existing code checks for onos-core-net only due to the bug

In addition, this patch introduces a new REST API to check health of given app.
Active in app status only indicates that the app has been activated.
This new API will look deeper and make sure all OSGi features, bundles and components of given app are all ready.

Change-Id: If91326ba9cffdbe25821eeaaa092ec9d2ab952ea
(cherry picked from commit 5bdaf106e4b30208d6acee6ad5bf1d58c9057d66)
2020-08-12 00:05:43 +00:00
Thomas Vachuska
a1b624eaa1 Removing the host drop-shadow from the topo GUI2
Change-Id: If6078ee6234370e4a5351d2b01a0a22593c531df
2020-08-03 07:55:09 +00:00
Lakshya Thakur
95e691a72e Fix for secure boolean inside matchSecure method of UrlFnService
Change-Id: I6e7053a62f5c0d6681e4e7c8eb995c6e8aae0c99
2020-07-23 18:44:51 +05:30
Andrea Campanella
0ab52ba618 [ONOS-8102] Moving get(MeterService.class) into each MetersWebResource Method to avoid startup race condition between Web resource and meter service class creation.
Change-Id: Ie1a14aeec91b54a120ccd3d14f9edc846426c857
(cherry picked from commit 6347ff4c46de1531856c3de318f73b62002fcc3c)
2020-06-10 11:57:31 +00:00
Davide Scano
555617a9f9 INT app gui2
This patch contains the files needed by the INT app to work with gui2.
More in detail I reuse/modifie the html and the css, already provided in
the inbandtelemetry folder. I add the file needed to utilize the gui2,
e.g,intapp-gui2-lib.module.ts.

Link to my dropbox for screenshots: 
https://www.dropbox.com/sh/ie2l0flcm8igesk/AAAsP2RdMbNbnt6A88lmBczaa?dl=0

Change-Id: I710c09f3a04a139a4482bb7aae3b3b76b39e67e6
2020-06-04 07:23:58 +00:00
Sean Condon
4de9b920b7 [ONOS-8094] GUI2 Topo details fails to show localized messages for English
Change-Id: I6bd9d64350358fb66afbc0d46a6fd31b5e499af0
2020-06-01 09:37:40 +01:00
Sean Condon
ff5bb451f0 GUI2 fixed some unit tests
and updated documentation

Change-Id: Icb66f91b64172359c9ddadd4bfd2531ed28f5be0
2020-05-27 08:30:48 +01:00
Sean Condon
d3d4ac1d9e [ONOS-8095] GUI2 Adjusted the width of columns in the flow table view
Change-Id: I4ffa81a82d1c7baa0758ce158a4c7a8d0af53a49
2020-05-26 09:42:01 +01:00
Sean Condon
97aa670c9a [ONOS-8097] Pipeconf table top header misaligned
Change-Id: I53177528333684e244478b9ea728b535ce9ad6e6
2020-05-22 15:54:01 +00:00
Sean Condon
8a8bc4b1e5 [ONOS-8096] In GUI2 device panel space before colon creates unnecessary wrap
Change-Id: I08ca8b70dc6c21d12714f510c9fa3473ad41c261
2020-05-22 07:34:24 +00:00
Sean Condon
f86cfc9b3c GUI2 add a karma.conf.js for unit tests
Change-Id: I2db9e9fcbaa6b6cf0dcdae38bff8628c0e706cf4
2020-04-15 17:02:41 +01:00
Sean Condon
3dd062fb14 GUI2 Change gui2-fw-lib refs to abs paths
Change-Id: Iddc121c70ddf9fa69c8d9f99e9768de6c2143eab
2020-04-14 09:29:28 +01:00
Sean Condon
e4e8f6a889 Upgraded to Angular 9.1.0 and rules_nodejs to 1.6
Added in command to generate gui2-fw-lib as NPM package

Change-Id: Id21f6f17b6edcd09cffd237f7ece90cf97a71bc2
2020-04-13 10:14:32 +00:00
Seyeon Jeong
9ceeacb11e Add JSON decoders for Host and HostLocation
- HostsWebResource will use the Host codec in parsing JSON for create-host requests

Change-Id: If51bf3433a4ab45889a94a6d11bbd3db6b96d074
(cherry picked from commit 46d2462e4e49855b0d533035250776589fd05d88)
2020-03-31 21:22:06 +00:00
Seyeon Jeong
8188da17c1 Found a few codec inconsistencies between JSON encoders and decoders
- Fix EtherType inconsistency in coding VLAN_PUSH and MPLS_POP instructions
- Fix group id inconsistency in coding a Group instruction
- Fix Group identifiers to be treated as unsigned integers in GroupCodec
- Add a JSON decoder for FlowEntry

Change-Id: Id80b9e009550e3b71b9274adb116e5179391fa66
(cherry picked from commit 494f586853c1a87ba62f20b477e211f996baded5)
2020-03-26 19:40:46 +00:00
Sean Condon
f9ff66abc2 Display host names given in netcfg
Change-Id: I883c9aa06c09221bdc198ea1d47b4cbf8b31fde5
2020-03-23 09:22:22 +00:00
Sean Condon
ed77aeb7bc Upgraded some components for GUI2
Change-Id: I83795ed9b546940d0a5fa151a40504545270774b
2020-03-16 10:53:38 +00:00
Sean Condon
00e56d0efb Changed how link highlight text is updated
Also added in widening of text box and different kerning options

Change-Id: I141251a2b3258de2cd8f7b0d47510ea9b7340fd4
2020-02-28 15:24:23 +00:00
Thomas Vachuska
edb437a5ad Minor GUI tweaks:
* Fix header margin for all table views to align with the table
* Fix margins in GUI map selector
* Removed node drop-shadow in the GUI topology by reducing blur to 0
* Adjusted device label sizing to favour more white-space than to clip and squeeze text

Change-Id: I9ef3eee30714a5aaa9337582d6b1a2e2fb2b302c
2020-02-28 15:20:55 +00:00
Yi Tseng
bb93b6e7ff
Add missing route to Roadm UI
Change-Id: Iece3e2212e0a227efbc0b015f3826ca3e86b77f8
2020-02-12 17:22:13 -08:00
Sean Condon
6ceebf0392 GUI2 Upgraded Angular to 9rc10 and rules_nodejs to 1.10
Change-Id: I56f5f28dffb9102b2b7920fcbf6a0b084051662c
2020-01-24 09:04:29 +00:00
Sean Condon
5c1c3a8b75 GUI2 changed web socket port to follow main window port rather than hardcode
Change-Id: I0ea090f628ee60f9d930be9307daa8d081465d97
2020-01-22 12:07:35 +00:00
Sean Condon
d6f95bfcef Added the Yang GUI to GUI2
Change-Id: I843db3838668e21a77837faaf00d4d6834676d8d
2020-01-21 20:30:36 +00:00
Charles Chan
5425aae859 Supported recently introduced fields in HostsWebResource
Change-Id: I3bc3fd272008388326041540c10e8a103b01c02c
2020-01-16 20:54:03 +00:00
Andrea Campanella
0fa8787e59 Commenting the GUI2 Bazel files browsers sections to avoid issues with mac
Change-Id: I3212dd3d7e4f57d84af796824b89442ffac6f78a
2020-01-10 18:44:05 +01:00
Charles Chan
eb5bd49982 Added CLI and REST support for auxLocations
Change-Id: I04e78f766dcbb18bce4a2f9160d3740ec2fbd846
2020-01-09 23:34:56 +00:00
Sean Condon
a3ad779274 Added back in Bazel tests for gui2-fw-lib and gui2-topo-lib
Also used a named path in typescript for gui2-fw-lib

Change-Id: I7233565e53b9b86e1766228ecc96b21ea6f7499d
2020-01-08 13:11:31 +00:00
Sean Condon
4fff373774 Updating the README to test the build process
Change-Id: I4db415524372602dd609be547801de9d177b45ef
2020-01-07 18:42:34 +00:00