88 Commits

Author SHA1 Message Date
Kieran McPeake
9e64ab5858 Cleaner warning if a NETCONF session to Juniper device not yet established.
Old version gave in logs ...
2019-06-06T09:34:46,730 | WARN  | FlowRuleDriverProvider-0 | FlowRuleDriverProvider           | 191 - org.onosproject.onos-core-net - 2.2.0.SNAPSHOT | Exception thrown while polling netconf:172.26.138.38:830
java.lang.NullPointerException: null
	at org.onosproject.drivers.juniper.FlowRuleJuniperImpl.getFlowEntries(FlowRuleJuniperImpl.java:92) ~[?:?]
	at org.onosproject.net.flow.impl.FlowRuleDriverProvider.pollDeviceFlowEntries(FlowRuleDriverProvider.java:193) ~[?:?]
	at org.onosproject.net.flow.impl.FlowRuleDriverProvider.access$500(FlowRuleDriverProvider.java:63) ~[?:?]
	at org.onosproject.net.flow.impl.FlowRuleDriverProvider$InternalDeviceListener.handleEvent(FlowRuleDriverProvider.java:249) ~[?:?]
	at org.onosproject.net.flow.impl.FlowRuleDriverProvider$InternalDeviceListener.lambda$event$0(FlowRuleDriverProvider.java:233) ~[?:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:?]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) [?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) [?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [?:?]
	at java.lang.Thread.run(Thread.java:745) [?:?]

New version gives ...
2019-06-07T09:36:07,924 | WARN  | FlowRuleDriverProvider-0 | JuniperAbstractHandlerBehaviour  | 218 - org.onosproject.onos-drivers-juniper - 2.2.0.SNAPSHOT | NETCONF session to device netconf:172.26.138.68:830 not yet established, will be retried

Note in new version this lookup code refactored to be in one place.

Change-Id: Ic78c5ecc67e8e98d14da845d0541d980296750a5
2019-06-10 09:40:45 +00:00
Kieran McPeake
201fe1ffa1 Juniper-NETCONF provider: Extend UTs; fix warnings
New UTs based on NETCONF responses lab devices.
No functional changes here; it is refactoring only.

Change-Id: I6a011fce9496285539c7a11deb8fbac930b12483
2019-06-05 10:09:33 +01:00
Kieran McPeake
e1b418f08b Clean up logging in (or relevant to) Juniper NETCONF provider
Also fix missing chassisId in DefaultDeviceDescription.toString()

Change-Id: I944baf0b3a4eb9960c0cbcec2ad585701d9a2989
2019-06-05 10:09:33 +01:00
Kieran McPeake
bc00cb5d74 Juniper driver - fix NETCONF discovery of JUNOS v19 devices regarding chassis-mac-addresses RPC
Added UT based on XML responses from v15 and v19 devices

Change-Id: Id4e0fe34b12dea6034e75f2276495282ea2e6aa2
2019-05-29 12:38:08 +00:00
DongRyeol Cha
81935a611e Do not create a link if port is disabled.
There is some case regarding link creation.
Let's suppose that there are A and B devices on topology.

The link discovery drivers on onos will gather the link information from device(eg, switches).
In this case, if a port on the device A is unplugged or changed to down state but the link information(eg, LLDP) will be remained because TTL is not reached yet.

So, onos will re-create the link using link information that is gathered from link discovery driver.
This behavior result to link is re-created suddenly even if ports are disabled.

ONOS-7854

Change-Id: I224fb39fee92648600f9c9e40fcc97890d3ea9ef
2018-11-30 16:51:21 +09:00
DongRyeol Cha
e23b18b61f Set the port type using real value of juniper switch's port type.
Currently, juniper port description is only set with hard coded copper type.
So, set the port type using real value of juniper switch's port type.

ONOS-7844

Change-Id: Ifdaca2fdc73ab0006a8d180e42f05831f9266f9a
2018-11-20 15:09:50 +09:00
Ray Milkey
123f0e08ad Merge branch 'master' into dev-karaf-4.2.1
Change-Id: If6c7d5f1dc6434ac8ea2fd9716b8ebeee38daa50
2018-11-08 14:18:52 -08:00
DongRyeol Cha
ce65cc0055 Make a link depends on packet-in LLDP packet.
The ONOS does not process the incoming LLDP packet from switches.
The ONOS only process LLDP packets if LLDP packet has "ONOS Discovery" optional TLV.

So, this changes process incoming LLDP packet from switch and make a link information and onos can utilize it.

Also, this patch changes the requested appId of DefaultForwardingObjective generated by PacketManager.
So, AppId in result of flows cli will be printed to actual requested appId.

ONOS-7748

Change-Id: I2611b34655bec2369b8817ce0cd29fb2edbed845
2018-11-08 18:36:54 +00:00
Thomas Vachuska
07782d262b Eliminated old features.xml and app.xml files required by no-longer supported Maven build.
Change-Id: I060af47c85c1b83d35f6cc8e462d6d609872b15a
2018-11-01 20:41:00 +00:00
Ray Milkey
a218d43062 Merge branch 'master' into merge
Change-Id: Id77bb2de77dd288404c83e331b076aaf9aafacc5
2018-10-30 12:44:55 -07:00
Andrea Campanella
248cc24215 Fix for multiple rtEntries in Juniper Driver
Change-Id: I462ecdeee6597a5daad67ea734f09d56922ad835
2018-10-29 22:24:16 +00:00
Thomas Vachuska
22ea6126e4 Removing BUCK files and other Buck-related auxiliaries.
Change-Id: I23691380efcd9bce4906695605214ed59ada0e87
2018-10-24 20:02:31 +00:00
Ray Milkey
d84f89ba3d [WIP] Upgrade ONOS to karaf version 4.2.1
Change-Id: I7cd40c995bdf1c80f94b1895fb3344e32404c7fa
2018-09-28 11:20:57 -07:00
Ray Milkey
761e80a427 Remove pom files from ONOS
Change-Id: I53e2395466cba10222d638736635b11380421d98
2018-08-21 18:11:58 +00:00
Ray Milkey
312d987732 Starting snapshot 1.15.0-SNAPSHOT
Change-Id: I9239c7695f7faf6dc184a0ff54a34dedf4761b2d
2018-08-20 16:09:54 -07:00
ONOS Jenkins User
03e5521fba Starting snapshot 1.14.0-SNAPSHOT 2018-08-14 22:13:58 +00:00
ONOS Jenkins User
3594c24cb2 Tagging 1.14.0-rc2 2018-08-14 22:13:02 +00:00
ONOS Jenkins User
4e5f2d67ac Starting snapshot 1.14.0-SNAPSHOT 2018-08-13 23:16:37 +00:00
ONOS Jenkins User
cff0bd8922 Tagging 1.14.0-rc1 2018-08-13 23:15:43 +00:00
Ray Milkey
4867af2f9c Revert "Tagging 1.14.0-b1"
This reverts commit 78ce40093ac008fd6d169ab83d2d5961f91f6e31.

Change-Id: I8482f550c30f75d65333f6be9c9115a930abc56f
2018-08-10 16:53:10 -07:00
Ray Milkey
78ce40093a Tagging 1.14.0-b1 2018-08-10 11:16:44 -07:00
donghyeok.ho
e6d7187c18 ONOS-7750
Support Juniper "lldp-remote-port-id" message as String during link discovery

Change-Id: Ic1881c973e07df780692b34772a61dec6cbdc157
2018-07-25 20:44:05 +00:00
Ray Milkey
87a3f855a3 Sonar warning - don't check a value known to be null
Change-Id: I7d6a286b1117944369684848744deaaba29ab7ad
2018-07-18 10:00:52 -07:00
donghyeok.ho
82749aadcb [ONOS-7740] Support lldp-port-description message during link discovery with Juniper
Change-Id: I6f399eb2565ac3a7ba5b41d0e1ea25ab59986bc5
2018-07-17 13:48:22 +00:00
DongRyeol Cha
5f870031c9 Supports ControllerConfig behaviour for juniper.
Juniper drivers does not have ControllerConfig yet.

ONOS-7738

Change-Id: I2ecbb039e94266a87bb3d90a6949a49f092c194d
2018-07-17 13:48:04 +00:00
Ray Milkey
5c9e2838e4 Build drivers with bazel
Change-Id: I033ac32b3ef8119fc65e046c821ff17f12709261
2018-06-27 23:34:20 +00:00
Ray Milkey
bca9049101 Starting snapshot 1.14.0-SNAPSHOT
Change-Id: I97bab4e31d2b701f015289eae29d0c58a4937685
2018-04-13 12:47:31 -07:00
Yuta HIGUCHI
53e4796d55 Deprecate potentially error prone constructor methods
Change-Id: I82d95c27dc7c4b1a6dcf5cc48a1c7583b5e30e2c
2018-03-05 20:43:39 +00:00
Ray Milkey
ca7ee079f7 SONAR suggestion - bit operator instead of logical
Change-Id: I8242767a83ee0ee0a89683f5e42372f647ee9af7
2018-02-06 21:19:52 +00:00
Ray Milkey
3717e604d5 SONAR suggestions - prevent truncation of arithmetic expressions
Change-Id: I4694c0c3183b991a4f0db793f584bc77a5fb7d60
2018-02-02 23:06:44 +00:00
Ray Milkey
986a47aa7c SONAR suggestion - generic exceptions
Replace uses of generic RuntimeException
with more appropriate unchecked exceptions

Change-Id: If283743c2cf7252b8d280bdb788708ebbe57da9d
2018-02-01 18:36:33 +00:00
Ray Milkey
9c9cde4d4d SONAR Suggestion - protected members in final classes are pointless
Change-Id: Ie34d86aecf181e73867a14864d75e0db8a8f48f3
2018-01-17 00:18:50 +00:00
ONOS Jenkins User
45d340c839 Starting snapshot 1.13.0-SNAPSHOT 2018-01-09 01:56:13 +00:00
ONOS Jenkins User
32ebb5add8 Tagging 1.13.0-b8 2018-01-09 01:54:28 +00:00
ONOS Jenkins User
61881df1ee Starting snapshot 1.13.0-SNAPSHOT 2017-12-12 21:19:45 +00:00
ONOS Jenkins User
d22dccc27f Tagging 1.13.0-b7 2017-12-12 21:18:01 +00:00
ONOS Jenkins User
4bf9e3a520 Starting snapshot 1.13.0-SNAPSHOT 2017-12-12 18:46:22 +00:00
ONOS Jenkins User
168ac92b8d Tagging 1.13.0-b6 2017-12-12 18:44:15 +00:00
ONOS Jenkins User
0e78e27f0c Starting snapshot 1.13.0-SNAPSHOT 2017-12-12 03:27:00 +00:00
ONOS Jenkins User
2a7d833cab Tagging 1.13.0-b5 2017-12-12 03:25:23 +00:00
ONOS Jenkins User
c53a15f933 Starting snapshot 1.13.0-SNAPSHOT 2017-12-11 20:43:30 +00:00
ONOS Jenkins User
d06da9e33c Tagging 1.13.0-b3 2017-12-11 20:41:44 +00:00
ONOS Jenkins User
716484c58c Starting snapshot 1.13.0-SNAPSHOT 2017-12-09 03:41:19 +00:00
ONOS Jenkins User
6a6ac1d5a0 Tagging 1.13.0-b1 2017-12-09 03:39:39 +00:00
ONOS Jenkins User
a57a814230 Starting snapshot 1.13.0-SNAPSHOT 2017-12-09 00:57:30 +00:00
ONOS Jenkins User
8977cedde7 Tagging 1.13.0-b0 2017-12-09 00:55:39 +00:00
Ray Milkey
a09f87f02b Starting snapshot 1.13.0-SNAPSHOT
Change-Id: Ib3360118c42aa760632ff80537d585865813060f
2017-11-21 09:38:31 -08:00
Ray Milkey
cc6ec60fb2 Starting snapshot 1.12.0-SNAPSHOT 2017-11-10 16:22:59 -08:00
Ray Milkey
9f9a752bdc Tagging 1.12.0-b2 2017-11-10 16:21:23 -08:00
Ray Milkey
dc48fb2c3b Starting snapshot 1.12.0-SNAPSHOT 2017-09-26 14:42:24 -07:00