From f97f2bc12add6f84f4a3a341dcace6941115c3d6 Mon Sep 17 00:00:00 2001
From: Jian Li <pyguni@gmail.com>
Date: Sun, 19 Mar 2017 22:37:49 +0900
Subject: [PATCH] Further simplify if-else statement for OF default extensions

Change-Id: I0fd3f81ef8aa355f3bf6ff79b798ec5b8449a0f4
---
 .../org/onosproject/driver/extensions/NiciraPopNsh.java   | 8 +-------
 .../org/onosproject/driver/extensions/NiciraPushNsh.java  | 8 +-------
 .../org/onosproject/driver/extensions/Ofdpa3PopCw.java    | 8 +-------
 .../onosproject/driver/extensions/Ofdpa3PopL2Header.java  | 8 +-------
 .../org/onosproject/driver/extensions/Ofdpa3PushCw.java   | 8 +-------
 .../onosproject/driver/extensions/Ofdpa3PushL2Header.java | 8 +-------
 6 files changed, 6 insertions(+), 42 deletions(-)

diff --git a/drivers/default/src/main/java/org/onosproject/driver/extensions/NiciraPopNsh.java b/drivers/default/src/main/java/org/onosproject/driver/extensions/NiciraPopNsh.java
index 2e319f3abd..608697f2a8 100644
--- a/drivers/default/src/main/java/org/onosproject/driver/extensions/NiciraPopNsh.java
+++ b/drivers/default/src/main/java/org/onosproject/driver/extensions/NiciraPopNsh.java
@@ -55,12 +55,6 @@ public class NiciraPopNsh extends AbstractExtension implements ExtensionTreatmen
 
     @Override
     public boolean equals(Object obj) {
-        if (this == obj) {
-            return true;
-        }
-        if (obj instanceof NiciraPopNsh) {
-            return true;
-        }
-        return false;
+        return this == obj || obj instanceof NiciraPopNsh;
     }
 }
diff --git a/drivers/default/src/main/java/org/onosproject/driver/extensions/NiciraPushNsh.java b/drivers/default/src/main/java/org/onosproject/driver/extensions/NiciraPushNsh.java
index 8d3a96d977..2c60da8029 100644
--- a/drivers/default/src/main/java/org/onosproject/driver/extensions/NiciraPushNsh.java
+++ b/drivers/default/src/main/java/org/onosproject/driver/extensions/NiciraPushNsh.java
@@ -56,12 +56,6 @@ public class NiciraPushNsh extends AbstractExtension implements ExtensionTreatme
 
     @Override
     public boolean equals(Object obj) {
-        if (this == obj) {
-            return true;
-        }
-        if (obj instanceof NiciraPushNsh) {
-            return true;
-        }
-        return false;
+        return this == obj || obj instanceof NiciraPushNsh;
     }
 }
diff --git a/drivers/default/src/main/java/org/onosproject/driver/extensions/Ofdpa3PopCw.java b/drivers/default/src/main/java/org/onosproject/driver/extensions/Ofdpa3PopCw.java
index 1dd185efe0..78a39d6990 100644
--- a/drivers/default/src/main/java/org/onosproject/driver/extensions/Ofdpa3PopCw.java
+++ b/drivers/default/src/main/java/org/onosproject/driver/extensions/Ofdpa3PopCw.java
@@ -57,13 +57,7 @@ public class Ofdpa3PopCw extends AbstractExtension implements ExtensionTreatment
 
     @Override
     public boolean equals(Object obj) {
-        if (this == obj) {
-            return true;
-        }
-        if (obj instanceof Ofdpa3PopCw) {
-            return true;
-        }
-        return false;
+        return this == obj || obj instanceof Ofdpa3PopCw;
     }
 
     @Override
diff --git a/drivers/default/src/main/java/org/onosproject/driver/extensions/Ofdpa3PopL2Header.java b/drivers/default/src/main/java/org/onosproject/driver/extensions/Ofdpa3PopL2Header.java
index 03afdaef9c..28d837c25f 100644
--- a/drivers/default/src/main/java/org/onosproject/driver/extensions/Ofdpa3PopL2Header.java
+++ b/drivers/default/src/main/java/org/onosproject/driver/extensions/Ofdpa3PopL2Header.java
@@ -57,13 +57,7 @@ public class Ofdpa3PopL2Header extends AbstractExtension implements ExtensionTre
 
     @Override
     public boolean equals(Object obj) {
-        if (this == obj) {
-            return true;
-        }
-        if (obj instanceof Ofdpa3PopL2Header) {
-            return true;
-        }
-        return false;
+        return this == obj || obj instanceof Ofdpa3PopL2Header;
     }
 
     @Override
diff --git a/drivers/default/src/main/java/org/onosproject/driver/extensions/Ofdpa3PushCw.java b/drivers/default/src/main/java/org/onosproject/driver/extensions/Ofdpa3PushCw.java
index b3d999c783..ff7dec14c1 100644
--- a/drivers/default/src/main/java/org/onosproject/driver/extensions/Ofdpa3PushCw.java
+++ b/drivers/default/src/main/java/org/onosproject/driver/extensions/Ofdpa3PushCw.java
@@ -57,13 +57,7 @@ public class Ofdpa3PushCw extends AbstractExtension implements ExtensionTreatmen
 
     @Override
     public boolean equals(Object obj) {
-        if (this == obj) {
-            return true;
-        }
-        if (obj instanceof Ofdpa3PushCw) {
-            return true;
-        }
-        return false;
+        return this == obj || obj instanceof Ofdpa3PushCw;
     }
 
     @Override
diff --git a/drivers/default/src/main/java/org/onosproject/driver/extensions/Ofdpa3PushL2Header.java b/drivers/default/src/main/java/org/onosproject/driver/extensions/Ofdpa3PushL2Header.java
index ac09a82f61..323e448203 100644
--- a/drivers/default/src/main/java/org/onosproject/driver/extensions/Ofdpa3PushL2Header.java
+++ b/drivers/default/src/main/java/org/onosproject/driver/extensions/Ofdpa3PushL2Header.java
@@ -57,13 +57,7 @@ public class Ofdpa3PushL2Header extends AbstractExtension implements ExtensionTr
 
     @Override
     public boolean equals(Object obj) {
-        if (this == obj) {
-            return true;
-        }
-        if (obj instanceof Ofdpa3PushL2Header) {
-            return true;
-        }
-        return false;
+        return this == obj || obj instanceof Ofdpa3PushL2Header;
     }
 
     @Override