diff --git a/apps/segmentrouting/src/main/java/org/onosproject/segmentrouting/SegmentRoutingManager.java b/apps/segmentrouting/src/main/java/org/onosproject/segmentrouting/SegmentRoutingManager.java index a9c2f04282..d57a681f45 100644 --- a/apps/segmentrouting/src/main/java/org/onosproject/segmentrouting/SegmentRoutingManager.java +++ b/apps/segmentrouting/src/main/java/org/onosproject/segmentrouting/SegmentRoutingManager.java @@ -1353,7 +1353,7 @@ public class SegmentRoutingManager implements SegmentRoutingService { log.warn(e.getMessage() + " Aborting processDeviceAdded."); return; } - log.debug("updating groupHandlerMap with new config for device: {}", + log.debug("updating groupHandlerMap with new grpHdlr for device: {}", deviceId); groupHandlerMap.put(deviceId, groupHandler); } diff --git a/apps/segmentrouting/src/main/java/org/onosproject/segmentrouting/grouphandler/DefaultGroupHandler.java b/apps/segmentrouting/src/main/java/org/onosproject/segmentrouting/grouphandler/DefaultGroupHandler.java index 71f5c1599b..2cb7dc5a2e 100644 --- a/apps/segmentrouting/src/main/java/org/onosproject/segmentrouting/grouphandler/DefaultGroupHandler.java +++ b/apps/segmentrouting/src/main/java/org/onosproject/segmentrouting/grouphandler/DefaultGroupHandler.java @@ -621,7 +621,7 @@ public class DefaultGroupHandler { if (nextId == -1) { if (portUp) { log.debug("**Creating flooding group for first port enabled in" - + " subnet {} on dev {} port {}", vlanId, deviceId, port); + + " vlan {} on dev {} port {}", vlanId, deviceId, port); createBcastGroupFromVlan(vlanId, Collections.singleton(port)); } else { log.warn("Could not find flooding group for subnet {} on dev:{} when" @@ -1017,8 +1017,8 @@ public class DefaultGroupHandler { ); NextObjective nextObj = nextObjBuilder.add(context); flowObjectiveService.next(deviceId, nextObj); - log.debug("createBcastGroupFromVlan: Submitted next objective {} in device {}", - nextId, deviceId); + log.debug("createBcastGroupFromVlan: Submitted next objective {} " + + "for vlan: {} in device {}", nextId, vlanId, deviceId); vlanNextObjStore.put(key, nextId); } diff --git a/core/net/src/main/java/org/onosproject/net/flowobjective/impl/FlowObjectiveManager.java b/core/net/src/main/java/org/onosproject/net/flowobjective/impl/FlowObjectiveManager.java index 4bd4febaa4..09d3a24341 100644 --- a/core/net/src/main/java/org/onosproject/net/flowobjective/impl/FlowObjectiveManager.java +++ b/core/net/src/main/java/org/onosproject/net/flowobjective/impl/FlowObjectiveManager.java @@ -15,6 +15,7 @@ */ package org.onosproject.net.flowobjective.impl; +import com.google.common.collect.Lists; import com.google.common.collect.Maps; import com.google.common.collect.Sets; import org.apache.felix.scr.annotations.Activate; @@ -138,7 +139,7 @@ public class FlowObjectiveManager implements FlowObjectiveService { // instance, via the DistributedFlowObjectiveStore. private final Map> pendingForwards = Maps.newConcurrentMap(); - private final Map> pendingNexts = + private final Map> pendingNexts = Maps.newConcurrentMap(); // local store to track which nextObjectives were sent to which device @@ -317,7 +318,7 @@ public class FlowObjectiveManager implements FlowObjectiveService { pendingNexts.compute(next.id(), (id, pending) -> { PendingFlowObjective pendfo = new PendingFlowObjective(deviceId, next); if (pending == null) { - return Sets.newHashSet(pendfo); + return Lists.newArrayList(pendfo); } else { pending.add(pendfo); return pending; @@ -550,17 +551,18 @@ public class FlowObjectiveManager implements FlowObjectiveService { } // now check for pending next-objectives + List pendNexts; synchronized (pendingNexts) { // needs to be synchronized for queueObjective lookup - pending = pendingNexts.remove(event.subject()); + pendNexts = pendingNexts.remove(event.subject()); } - if (pending == null) { + if (pendNexts == null) { log.debug("No next objectives pending for this " + "obj event {}", event); } else { log.debug("Processing {} pending next objectives for nextId {}", - pending.size(), event.subject()); - pending.forEach(p -> getDevicePipeliner(p.deviceId()) + pendNexts.size(), event.subject()); + pendNexts.forEach(p -> getDevicePipeliner(p.deviceId()) .next((NextObjective) p.flowObjective())); } } @@ -666,7 +668,7 @@ public class FlowObjectiveManager implements FlowObjectiveService { } for (Integer nextId : pendingNexts.keySet()) { - Set pnext = pendingNexts.get(nextId); + List pnext = pendingNexts.get(nextId); StringBuilder pend = new StringBuilder(); pend.append("NextId: ") .append(nextId); diff --git a/drivers/default/src/main/java/org/onosproject/driver/pipeline/ofdpa/Ofdpa2Pipeline.java b/drivers/default/src/main/java/org/onosproject/driver/pipeline/ofdpa/Ofdpa2Pipeline.java index 2d960cee7e..1fdf2aba6a 100644 --- a/drivers/default/src/main/java/org/onosproject/driver/pipeline/ofdpa/Ofdpa2Pipeline.java +++ b/drivers/default/src/main/java/org/onosproject/driver/pipeline/ofdpa/Ofdpa2Pipeline.java @@ -721,7 +721,7 @@ public class Ofdpa2Pipeline extends AbstractHandlerBehaviour implements Pipeline if (matchInPortTmacTable()) { selector.matchInPort(pnum); } else { - log.info("Pipeline does not support IN_PORT matching in TMAC table, " + + log.debug("Pipeline does not support IN_PORT matching in TMAC table, " + "ignoring the IN_PORT criteria"); } } @@ -766,7 +766,7 @@ public class Ofdpa2Pipeline extends AbstractHandlerBehaviour implements Pipeline if (matchInPortTmacTable()) { selector.matchInPort(pnum); } else { - log.info("Pipeline does not support IN_PORT matching in TMAC table, " + + log.debug("Pipeline does not support IN_PORT matching in TMAC table, " + "ignoring the IN_PORT criteria"); } } @@ -811,7 +811,7 @@ public class Ofdpa2Pipeline extends AbstractHandlerBehaviour implements Pipeline if (matchInPortTmacTable()) { selector.matchInPort(pnum); } else { - log.info("Pipeline does not support IN_PORT matching in TMAC table, " + + log.debug("Pipeline does not support IN_PORT matching in TMAC table, " + "ignoring the IN_PORT criteria"); } }