From e559bcf45dff0bbf9a392629b53db6bc052de23a Mon Sep 17 00:00:00 2001 From: Ray Milkey Date: Fri, 15 Dec 2017 15:58:12 -0800 Subject: [PATCH] Sonar suggestion - don't use bit operator in a boolean expression Change-Id: I69e254ffea0c72a040077d6e6a13c326d44c1197 --- utils/misc/src/main/java/org/onlab/packet/PacketUtils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/misc/src/main/java/org/onlab/packet/PacketUtils.java b/utils/misc/src/main/java/org/onlab/packet/PacketUtils.java index d4ec84d46f..81b06e06b1 100644 --- a/utils/misc/src/main/java/org/onlab/packet/PacketUtils.java +++ b/utils/misc/src/main/java/org/onlab/packet/PacketUtils.java @@ -39,7 +39,7 @@ public final class PacketUtils { public static void checkBufferLength(int byteLength, int offset, int length) throws DeserializationException { boolean ok = (offset >= 0 && offset < byteLength); - ok = ok & (length >= 0 && offset + length <= byteLength); + ok = ok && (length >= 0 && offset + length <= byteLength); if (!ok) { throw new DeserializationException("Unable to read " + length + " bytes from a "