From dfb325a88ef88033183b7a2cc74da783c968753d Mon Sep 17 00:00:00 2001 From: Aaron Kruglikov Date: Mon, 23 Nov 2015 14:16:55 -0800 Subject: [PATCH] Cancelling timer at close to prevent attempts to commit closed DB. Change-Id: I01d2984e69ea8329c06a6fc3610d4a419f9bd6a2 --- .../org/onosproject/persistence/impl/PersistenceManager.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/core/store/persistence/src/main/java/org/onosproject/persistence/impl/PersistenceManager.java b/core/store/persistence/src/main/java/org/onosproject/persistence/impl/PersistenceManager.java index 64a8683a9e..3428bce14e 100644 --- a/core/store/persistence/src/main/java/org/onosproject/persistence/impl/PersistenceManager.java +++ b/core/store/persistence/src/main/java/org/onosproject/persistence/impl/PersistenceManager.java @@ -60,12 +60,13 @@ public class PersistenceManager implements PersistenceService { private static final int FLUSH_FREQUENCY_MILLIS = 3000; - private final Timer timer = new Timer(); + private Timer timer; private final CommitTask commitTask = new CommitTask(); @Activate public void activate() { + timer = new Timer(); Path dbPath = Paths.get(DATABASE_PATH); Path dbFolderPath = Paths.get(ENCLOSING_FOLDER); //Make sure the directory exists, if it does not, make it. @@ -96,6 +97,7 @@ public class PersistenceManager implements PersistenceService { @Deactivate public void deactivate() { + timer.cancel(); for (Map.Entry entry : localDB.getAll().entrySet()) { String key = entry.getKey(); Object value = entry.getValue();