Avoid unnecessary boxing.

Change-Id: I8fce87e3b1ba1f65f0e379c60e5d71d637228b61
This commit is contained in:
Yuta HIGUCHI 2015-02-10 22:26:59 -08:00
parent c611d927aa
commit dd9228dedb
3 changed files with 5 additions and 5 deletions

View File

@ -156,7 +156,7 @@ public class NullDeviceProvider extends AbstractProvider implements DeviceProvid
newDevNum = getDevicesConfig(s); newDevNum = getDevicesConfig(s);
} }
s = (String) properties.get("numPorts"); s = (String) properties.get("numPorts");
newPortNum = isNullOrEmpty(s) ? DEF_NUMPORTS : Integer.valueOf(s.trim()); newPortNum = isNullOrEmpty(s) ? DEF_NUMPORTS : Integer.parseInt(s.trim());
} catch (Exception e) { } catch (Exception e) {
log.warn(e.getMessage()); log.warn(e.getMessage());
newDevNum = numDevices; newDevNum = numDevices;
@ -183,7 +183,7 @@ public class NullDeviceProvider extends AbstractProvider implements DeviceProvid
NodeId that = new NodeId(params[0].trim()); NodeId that = new NodeId(params[0].trim());
String nd = params[1]; String nd = params[1];
if (clusterService.getLocalNode().id().equals(that)) { if (clusterService.getLocalNode().id().equals(that)) {
return Integer.valueOf(nd.trim()); return Integer.parseInt(nd.trim());
} }
continue; continue;
} }

View File

@ -163,7 +163,7 @@ public class NullLinkProvider extends AbstractProvider implements LinkProvider {
String newNbor; String newNbor;
try { try {
String s = (String) properties.get("eventRate"); String s = (String) properties.get("eventRate");
newRate = isNullOrEmpty(s) ? eventRate : Integer.valueOf(s.trim()); newRate = isNullOrEmpty(s) ? eventRate : Integer.parseInt(s.trim());
s = (String) properties.get("neighbors"); s = (String) properties.get("neighbors");
newNbor = isNullOrEmpty(s) ? neighbor : getNeighbor(s.trim()); newNbor = isNullOrEmpty(s) ? neighbor : getNeighbor(s.trim());
} catch (Exception e) { } catch (Exception e) {
@ -239,7 +239,7 @@ public class NullLinkProvider extends AbstractProvider implements LinkProvider {
String part = part(did.toString()); String part = part(did.toString());
String npart = nIdPart(did.toString()); String npart = nIdPart(did.toString());
if (part.equals("ffff") & npart.equals(neighbor)) { if (part.equals("ffff") && npart.equals(neighbor)) {
// 'tail' of our neighboring island - link us <- tail // 'tail' of our neighboring island - link us <- tail
tails.add(new ConnectPoint(did, SRCPORT)); tails.add(new ConnectPoint(did, SRCPORT));
} }

View File

@ -122,7 +122,7 @@ public class NullPacketProvider extends AbstractProvider implements
int newRate; int newRate;
try { try {
String s = String.valueOf(properties.get("pktRate")); String s = String.valueOf(properties.get("pktRate"));
newRate = isNullOrEmpty(s) ? pktRate : Integer.valueOf(s.trim()); newRate = isNullOrEmpty(s) ? pktRate : Integer.parseInt(s.trim());
} catch (Exception e) { } catch (Exception e) {
log.warn(e.getMessage()); log.warn(e.getMessage());
newRate = pktRate; newRate = pktRate;