mirrors/onos
1
0
Fork 0
mirror of https://github.com/opennetworkinglab/onos.git synced 2025-10-24 05:41:01 +02:00
Code Issues Projects Releases Wiki Activity

add comments to DatabaseStateMachine

Browse Source 
Change-Id: I775e2f6c0250ac158e301408e423ebdb29d75668
This commit is contained in:
Yuta HIGUCHI 2014-11-05 18:53:09 -08:00
parent 1838f88d2b
commit bddc81c4ec
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
core/store/dist/src/main/java/org/onlab/onos/store/service/impl/DatabaseStateMachine.java vendored
View File

@ -89,6 +89,8 @@ public class DatabaseStateMachine implements StateMachine {
@Command @Command
public List<InternalWriteResult> write(List<WriteRequest> requests) { public List<InternalWriteResult> write(List<WriteRequest> requests) {
// applicability check
boolean abort = false; boolean abort = false;
List<InternalWriteResult.Status> validationResults = new ArrayList<>(requests.size()); List<InternalWriteResult.Status> validationResults = new ArrayList<>(requests.size());
for (WriteRequest request : requests) { for (WriteRequest request : requests) {
@ -132,8 +134,13 @@ public class DatabaseStateMachine implements StateMachine {
return results; return results;
} }
// apply changes
for (WriteRequest request : requests) { for (WriteRequest request : requests) {
Map<String, VersionedValue> table = state.getTables().get(request.tableName()); Map<String, VersionedValue> table = state.getTables().get(request.tableName());
// FIXME: If this method could be called by multiple thread,
// synchronization scope is wrong.
// Whole function including applicability check needs to be protected.
// Confirm copycat's thread safety requirement for StateMachine
synchronized (table) { synchronized (table) {
VersionedValue previousValue = VersionedValue previousValue =
table.put(request.key(), new VersionedValue(request.newValue(), state.nextVersion())); table.put(request.key(), new VersionedValue(request.newValue(), state.nextVersion()));