From 754701c956d2e2e607bad04bc791cb5bf04bbf15 Mon Sep 17 00:00:00 2001 From: Harshada Chaundkar Date: Fri, 8 Mar 2019 14:15:53 -0500 Subject: [PATCH] Fixed potential NPE in packet-stats for ipv4 tcp packets Change-Id: I6b649a689a4e9d7ed1519e7d8f6dd2a4846758ee --- .../org/onosproject/packetstats/PacketStatistics.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/apps/packet-stats/app/src/main/java/org/onosproject/packetstats/PacketStatistics.java b/apps/packet-stats/app/src/main/java/org/onosproject/packetstats/PacketStatistics.java index ad3074e1af..39114d4100 100644 --- a/apps/packet-stats/app/src/main/java/org/onosproject/packetstats/PacketStatistics.java +++ b/apps/packet-stats/app/src/main/java/org/onosproject/packetstats/PacketStatistics.java @@ -46,7 +46,7 @@ import org.onlab.metrics.MetricsService; * Application for Packet Statistics. */ @Component(immediate = true) -public class PacketStatistics { +public class PacketStatistics { @Reference(cardinality = ReferenceCardinality.MANDATORY) protected PacketService packetService; @@ -145,6 +145,10 @@ public class PacketStatistics { metricService.createCounter(packetStatisticsComponent, lldpFeature, "lldpPC"); this.vlanCounter = metricService.createCounter(packetStatisticsComponent, vlanFeature, "vlanPC"); + this.tcpCounter = + metricService.createCounter(packetStatisticsComponent, tcpFeature, "tcpPC"); + this.rarpCounter = + metricService.createCounter(packetStatisticsComponent, rarpFeature, "rarpPC"); this.icmpCounter = metricService.createCounter(packetStatisticsComponent, icmpFeature, "icmpPC"); this.icmp6Counter = @@ -246,7 +250,7 @@ public class PacketStatistics { } else { log.debug("Packet is unknown."); unknownCounter.inc(); - } } } + } }