mirrors/onos
1
0
Fork 0
mirror of https://github.com/opennetworkinglab/onos.git synced 2025-10-26 05:41:08 +01:00
Code Issues Projects Releases Wiki Activity

Eliminate code duplication in initialization

Browse Source 
Change-Id: I067f2e0bb22bc24c3e3ac6ba24920c7ceebeee1e
This commit is contained in:
Ray Milkey 2015-06-10 13:14:15 -07:00 committed by Gerrit Code Review
parent ab8b0c075e
commit 69f03171e9
1 changed files with 16 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
core/api/src/main/java/org/onosproject/net/group/DefaultGroup.java
View File

@ -36,6 +36,20 @@ public class DefaultGroup extends DefaultGroupDescription
private long referenceCount; private long referenceCount;
private GroupId id; private GroupId id;
/**
* Initializes default values.
*
* @param newId group id for new group
*/
private void initialize(GroupId newId) {
id = newId;
state = GroupState.PENDING_ADD;
life = 0;
packets = 0;
bytes = 0;
referenceCount = 0;
}
/** /**
* Default group object constructor with the parameters. * Default group object constructor with the parameters.
* *
@ -44,12 +58,7 @@ public class DefaultGroup extends DefaultGroupDescription
*/ */
public DefaultGroup(GroupId id, GroupDescription groupDesc) { public DefaultGroup(GroupId id, GroupDescription groupDesc) {
super(groupDesc); super(groupDesc);
this.id = id; initialize(id);
this.state = GroupState.PENDING_ADD;
this.life = 0;
this.packets = 0;
this.bytes = 0;
this.referenceCount = 0;
} }
/** /**
@ -66,12 +75,7 @@ public class DefaultGroup extends DefaultGroupDescription
GroupDescription.Type type, GroupDescription.Type type,
GroupBuckets buckets) { GroupBuckets buckets) {
super(deviceId, type, buckets); super(deviceId, type, buckets);
this.id = id; initialize(id);
this.state = GroupState.PENDING_ADD;
this.life = 0;
this.packets = 0;
this.bytes = 0;
this.referenceCount = 0;
} }
/** /**