mirrors/onos
1
0
Fork 0
mirror of https://github.com/opennetworkinglab/onos.git synced 2025-10-17 18:32:28 +02:00
Code Issues Projects Releases Wiki Activity

Avoid sporadic test failure

Browse Source 
- Avoid 2-arg constructor which may endup using different timestamp

Change-Id: Id47d89c8dc9207352b56f6213a45b3cd1b0070c0
This commit is contained in:
Yuta HIGUCHI 2017-05-25 16:25:16 -07:00 committed by Yuta HIGUCHI
parent 04147cafbb
commit 4d04b2c1f6
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
core/api/src/test/java/org/onosproject/cluster/ClusterMetadataEventTest.java
View File

@ -27,6 +27,7 @@ import static org.junit.Assert.assertThat;
* Unit tests for the Cluster Metadata event.
*/
public class ClusterMetadataEventTest {
private final long time1 = System.currentTimeMillis() - 100;
private final long time = System.currentTimeMillis();
private final PartitionId pid1 = PartitionId.from(1);
private final PartitionId pid2 = PartitionId.from(2);
@ -47,21 +48,24 @@ public class ClusterMetadataEventTest {
new ClusterMetadata("baz", ImmutableSet.of(n2), ImmutableSet.of(p3));
private final ClusterMetadataEvent event1 =
new ClusterMetadataEvent(ClusterMetadataEvent.Type.METADATA_CHANGED, metadata1);
new ClusterMetadataEvent(ClusterMetadataEvent.Type.METADATA_CHANGED, metadata1, time1);
private final ClusterMetadataEvent sameAsEvent1 =
new ClusterMetadataEvent(ClusterMetadataEvent.Type.METADATA_CHANGED, metadata1);
new ClusterMetadataEvent(ClusterMetadataEvent.Type.METADATA_CHANGED, metadata1, time1);
private final ClusterMetadataEvent event2 =
new ClusterMetadataEvent(ClusterMetadataEvent.Type.METADATA_CHANGED, metadata2, time);
private final ClusterMetadataEvent sameAsEvent2 =
new ClusterMetadataEvent(ClusterMetadataEvent.Type.METADATA_CHANGED, metadata2, time);
private final ClusterMetadataEvent event3 =
new ClusterMetadataEvent(ClusterMetadataEvent.Type.METADATA_CHANGED, metadata3);
/**
* Tests for proper operation of equals(), hashCode() and toString() methods.
*/
@Test
public void checkEquals() {
public void checkEquals() throws Exception {
// ensure event3 will have different timestamp from `time`
Thread.sleep(1);
ClusterMetadataEvent event3 =
new ClusterMetadataEvent(ClusterMetadataEvent.Type.METADATA_CHANGED, metadata3);
new EqualsTester()
.addEqualityGroup(event1, sameAsEvent1)
.addEqualityGroup(event2, sameAsEvent2)