From 38a4798ea00ce218e67d3b2bdfe8cbd30250dac6 Mon Sep 17 00:00:00 2001
From: Sho SHIMIZU <sshimizu@us.fujitsu.com>
Date: Wed, 13 Jan 2016 23:34:31 -0800
Subject: [PATCH] Refactor: Reduce number of invocations of Stream#collect()

Change-Id: Idde16505cbe0a1e56e2b651678a0169df0d06bf7
---
 .../net/intent/impl/IntentManager.java          | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/core/net/src/main/java/org/onosproject/net/intent/impl/IntentManager.java b/core/net/src/main/java/org/onosproject/net/intent/impl/IntentManager.java
index bc8d342923..063199339c 100644
--- a/core/net/src/main/java/org/onosproject/net/intent/impl/IntentManager.java
+++ b/core/net/src/main/java/org/onosproject/net/intent/impl/IntentManager.java
@@ -54,6 +54,7 @@ import java.util.Optional;
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.ExecutorService;
 import java.util.stream.Collectors;
+import java.util.stream.Stream;
 
 import static com.google.common.base.Preconditions.checkNotNull;
 import static java.util.concurrent.Executors.newFixedThreadPool;
@@ -339,26 +340,24 @@ public class IntentManager
         }
     }
 
-    private List<CompletableFuture<FinalIntentProcessPhase>> createIntentUpdates(Collection<IntentData> data) {
+    private Stream<CompletableFuture<FinalIntentProcessPhase>> createIntentUpdates(Collection<IntentData> data) {
         return data.stream()
-                .map(IntentManager.this::submitIntentData)
-                .collect(Collectors.toList());
+                .map(IntentManager.this::submitIntentData);
     }
 
-    private List<FinalIntentProcessPhase> waitForFutures(List<CompletableFuture<FinalIntentProcessPhase>> futures) {
-        return futures.stream()
+    private Stream<FinalIntentProcessPhase> waitForFutures(Stream<CompletableFuture<FinalIntentProcessPhase>> futures) {
+        return futures
                 .map(x -> x.exceptionally(e -> {
                     //FIXME
                     log.warn("Future failed: {}", e);
                     return null;
                 }))
                 .map(CompletableFuture::join)
-                .filter(Objects::nonNull)
-                .collect(Collectors.toList());
+                .filter(Objects::nonNull);
     }
 
-    private void submitUpdates(List<FinalIntentProcessPhase> updates) {
-        store.batchWrite(updates.stream()
+    private void submitUpdates(Stream<FinalIntentProcessPhase> updates) {
+        store.batchWrite(updates
                 .map(FinalIntentProcessPhase::data)
                 .collect(Collectors.toList()));
     }