mirrors/onos
1
0
Fork 0
mirror of https://github.com/opennetworkinglab/onos.git synced 2026-05-05 12:16:13 +02:00
Code Issues Projects Releases Wiki Activity

Deprecate HexDump

Browse Source 
- Part of reducing dependency to netty 3

Change-Id: I64cf70a03ffc61ca9a9b263e1fe88dbbb9a5389f
This commit is contained in:
Yuta HIGUCHI 2017-05-21 00:30:16 -07:00 committed by Yuta HIGUCHI
parent da4798db96
commit 385348e915
4 changed files with 57 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
protocols/bgp/ctl/src/main/java/org/onosproject/bgp/controller/impl/BgpMessageDecoder.java
View File

@ -23,7 +23,6 @@ import org.jboss.netty.channel.Channel;
import org.jboss.netty.channel.ChannelHandlerContext;
import org.jboss.netty.handler.codec.frame.FrameDecoder;
import org.onosproject.bgpio.protocol.BgpMessage;
import org.onlab.util.HexDump;
import org.onosproject.bgpio.protocol.BgpFactories;
import org.onosproject.bgpio.protocol.BgpMessageReader;
import org.onosproject.bgpio.types.BgpHeader;

2
protocols/bgp/ctl/src/main/java/org/onosproject/bgp/controller/impl/BgpMessageEncoder.java
View File

@ -23,8 +23,6 @@ import org.jboss.netty.channel.Channel;
import org.jboss.netty.channel.ChannelHandlerContext;
import org.jboss.netty.handler.codec.oneone.OneToOneEncoder;
import org.onosproject.bgpio.protocol.BgpMessage;
import org.onlab.util.HexDump;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

54
protocols/bgp/ctl/src/main/java/org/onosproject/bgp/controller/impl/HexDump.java Normal file
View File

@ -0,0 +1,54 @@
/*
* Copyright 2015-present Open Networking Laboratory
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.onosproject.bgp.controller.impl;
import org.jboss.netty.buffer.ChannelBuffer;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/**
* HexDump class an utility to dump buffer in hex format.
*/
public final class HexDump {
protected static final Logger log = LoggerFactory.getLogger(HexDump.class);
private HexDump() {
}
/**
* Dump the buffer content in hex format.
*
* @param buff buffer content to dump in hex format
*/
public static void dump(ChannelBuffer buff) {
buff.markReaderIndex();
try {
do {
StringBuilder sb = new StringBuilder();
for (int k = 0; (k < 16) && (buff.readableBytes() != 0); ++k) {
if (0 == k % 4) {
sb.append(String.format(" ")); // blank after 4 bytes
}
sb.append(String.format("%02X ", buff.readByte()));
}
log.debug(sb.toString());
} while (buff.readableBytes() != 0);
} catch (Exception e) {
log.error("[HexDump] Invalid buffer: " + e.toString());
}
buff.resetReaderIndex();
}
}

3
utils/misc/src/main/java/org/onlab/util/HexDump.java
View File

@ -21,7 +21,10 @@ import org.slf4j.LoggerFactory;
/**
* HexDump class an utility to dump buffer in hex format.
*
* @deprecated in 1.11.0
*/
@Deprecated
public final class HexDump {
protected static final Logger log = LoggerFactory.getLogger(HexDump.class);