diff --git a/core/api/src/main/java/org/onosproject/net/intent/constraint/BooleanConstraint.java b/core/api/src/main/java/org/onosproject/net/intent/constraint/BooleanConstraint.java index f1d4ad9f57..b644692754 100644 --- a/core/api/src/main/java/org/onosproject/net/intent/constraint/BooleanConstraint.java +++ b/core/api/src/main/java/org/onosproject/net/intent/constraint/BooleanConstraint.java @@ -53,12 +53,8 @@ public abstract class BooleanConstraint implements Constraint { @Override public boolean validate(Path path, LinkResourceService resourceService) { - for (Link link : path.links()) { - if (!isValid(link, resourceService)) { - return false; - } - } - return true; + return path.links().stream() + .allMatch(link -> isValid(link, resourceService)); } } diff --git a/core/api/src/main/java/org/onosproject/net/intent/constraint/LinkTypeConstraint.java b/core/api/src/main/java/org/onosproject/net/intent/constraint/LinkTypeConstraint.java index ffa4405b22..fae76d68d7 100644 --- a/core/api/src/main/java/org/onosproject/net/intent/constraint/LinkTypeConstraint.java +++ b/core/api/src/main/java/org/onosproject/net/intent/constraint/LinkTypeConstraint.java @@ -60,7 +60,7 @@ public class LinkTypeConstraint extends BooleanConstraint { @Override public boolean isValid(Link link, LinkResourceService resourceService) { boolean contains = types.contains(link.type()); - return isInclusive ? contains : !contains; + return isInclusive == contains; } /**