mirrors/onos
1
0
Fork 0
mirror of https://github.com/opennetworkinglab/onos.git synced 2025-10-22 04:40:59 +02:00
Code Issues Projects Releases Wiki Activity

Remove groupId casting to short from rest handler

Browse Source 
Problem: The decoder in GroupCodec (used by the REST layer) chopped the
upper 16 bit in caller-provided group IDs. Since group IDs are
inherently greater than 16-bit on any OFDPA-based device, the current
casting rendered the REST layer unusable for such devices.

Fix: removed casting, verified that all tests pass, and verified that I
can now create healthy group entries on OFDPA-based switches.

Change-Id: Ieb51071ff9b0d47f4ff1f90d80970b6c0df946b7
This commit is contained in:
Zsolt Haraszti 2016-02-25 08:40:34 -08:00
parent 964d948699
commit 265cd83437
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/common/src/main/java/org/onosproject/codec/impl/GroupCodec.java
View File

@ -113,7 +113,7 @@ public final class GroupCodec extends JsonCodec<Group> {
// parse group id
int groupIdInt = nullIsIllegal(json.get(GROUP_ID),
GROUP_ID + MISSING_MEMBER_MESSAGE).asInt();
GroupId groupId = new DefaultGroupId((short) groupIdInt);
GroupId groupId = new DefaultGroupId(groupIdInt);
// parse group key (appCookie)
String groupKeyStr = nullIsIllegal(json.get(APP_COOKIE),