From fa2cd3ba6585784cf1357475d062a372bc204594 Mon Sep 17 00:00:00 2001 From: Sho SHIMIZU Date: Tue, 11 Nov 2014 14:10:32 -0800 Subject: [PATCH] Use DeviceId instead of ElementId in WaypointConstraint for consistency - More consistent with ObstacleConstraint Change-Id: I0988de74a4917ed91580f078c1dae653c030e5bc --- .../net/intent/constraint/WaypointConstraint.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/core/api/src/main/java/org/onlab/onos/net/intent/constraint/WaypointConstraint.java b/core/api/src/main/java/org/onlab/onos/net/intent/constraint/WaypointConstraint.java index 2a1e3e3302..3a132f0893 100644 --- a/core/api/src/main/java/org/onlab/onos/net/intent/constraint/WaypointConstraint.java +++ b/core/api/src/main/java/org/onlab/onos/net/intent/constraint/WaypointConstraint.java @@ -17,7 +17,7 @@ package org.onlab.onos.net.intent.constraint; import com.google.common.base.MoreObjects; import com.google.common.collect.ImmutableList; -import org.onlab.onos.net.ElementId; +import org.onlab.onos.net.DeviceId; import org.onlab.onos.net.Link; import org.onlab.onos.net.Path; import org.onlab.onos.net.intent.Constraint; @@ -35,20 +35,20 @@ import static com.google.common.base.Preconditions.checkNotNull; */ public class WaypointConstraint implements Constraint { - private final List waypoints; + private final List waypoints; /** * Creates a new waypoint constraint. * * @param waypoints waypoints */ - public WaypointConstraint(ElementId... waypoints) { + public WaypointConstraint(DeviceId... waypoints) { checkNotNull(waypoints, "waypoints cannot be null"); checkArgument(waypoints.length > 0, "length of waypoints should be more than 0"); this.waypoints = ImmutableList.copyOf(waypoints); } - public List waypoints() { + public List waypoints() { return waypoints; } @@ -60,8 +60,8 @@ public class WaypointConstraint implements Constraint { @Override public boolean validate(Path path, LinkResourceService resourceService) { - LinkedList waypoints = new LinkedList<>(this.waypoints); - ElementId current = waypoints.poll(); + LinkedList waypoints = new LinkedList<>(this.waypoints); + DeviceId current = waypoints.poll(); // This is safe because Path class ensures the number of links are more than 0 Link firstLink = path.links().get(0); if (firstLink.src().elementId().equals(current)) {