Improving null safety of GossipIntentStore peer update function

Change-Id: I4f517d899c98f7c6cd0964465dfbcebae17363a3
This commit is contained in:
Brian O'Connor 2015-07-06 11:38:44 -07:00 committed by Gerrit Code Review
parent c615485959
commit 148ba2f86c

View File

@ -195,7 +195,7 @@ public class GossipIntentStore
NodeId origin = (data != null) ? data.origin() : null;
if (master == null || origin == null) {
log.warn("Intent {} has no home; master = {}, origin = {}",
data.key(), master, origin);
key, master, origin);
}
NodeId me = clusterService.getLocalNode().id();
@ -208,8 +208,8 @@ public class GossipIntentStore
} else if (isOrigin) {
return master != null ? ImmutableList.of(master) : getRandomNode();
} else {
log.warn("Not master or origin for intent {}", data.key());
return ImmutableList.of(master);
log.warn("Not master or origin for intent {}", key);
return master != null ? ImmutableList.of(master) : getRandomNode();
}
}